diff mbox series

[4/4] drm/i915/display: Set source_support even if panel do not support PSR

Message ID 20210209181439.215104-4-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/4] drm/i915/display: Rename for_each_intel_encoder.*_can_psr to for_each_intel_encoder.*_with_psr | expand

Commit Message

Souza, Jose Feb. 9, 2021, 6:14 p.m. UTC
This will set the right value of source_support when the port
encoder/port supports PSR but sink don't.

This change will also be needed in future for panel replay as psr
struct needs to be initialized even if disconnected or current sink
don't support PSR.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mun, Gwan-gyeong Feb. 22, 2021, 9:57 a.m. UTC | #1
On Tue, 2021-02-09 at 10:14 -0800, José Roberto de Souza wrote:
> This will set the right value of source_support when the port
> encoder/port supports PSR but sink don't.
> 
> This change will also be needed in future for panel replay as psr
> struct needs to be initialized even if disconnected or current sink
> don't support PSR.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index e0111b470570..6b3e2120161e 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1837,9 +1837,6 @@ void intel_psr_init(struct intel_dp *intel_dp)
>         if (!HAS_PSR(dev_priv))
>                 return;
>  
> -       if (!intel_dp->psr.sink_support)
> -               return;
> -
>         /*
>          * HSW spec explicitly says PSR is tied to port A.
>          * BDW+ platforms have a instance of PSR registers per
> transcoder but

Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index e0111b470570..6b3e2120161e 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1837,9 +1837,6 @@  void intel_psr_init(struct intel_dp *intel_dp)
 	if (!HAS_PSR(dev_priv))
 		return;
 
-	if (!intel_dp->psr.sink_support)
-		return;
-
 	/*
 	 * HSW spec explicitly says PSR is tied to port A.
 	 * BDW+ platforms have a instance of PSR registers per transcoder but