diff mbox series

[2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state()

Message ID 20210212182201.155043-2-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping | expand

Commit Message

Souza, Jose Feb. 12, 2021, 6:22 p.m. UTC
There is nothing else to be executed after this if block.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Ville Syrjala Feb. 12, 2021, 6:33 p.m. UTC | #1
On Fri, Feb 12, 2021 at 10:22:00AM -0800, José Roberto de Souza wrote:
> There is nothing else to be executed after this if block.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Looks like leftovers I forgot to clean up.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8c42fa51c0f6..8cc67f9c4e58 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6182,9 +6182,6 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc,
>  
>  		skl_wm_level_from_reg_val(val, &wm->trans_wm);
>  	}
> -
> -	if (!crtc->active)
> -		return;
>  }
>  
>  void skl_wm_get_hw_state(struct drm_i915_private *dev_priv)
> -- 
> 2.30.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 8c42fa51c0f6..8cc67f9c4e58 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6182,9 +6182,6 @@  void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc,
 
 		skl_wm_level_from_reg_val(val, &wm->trans_wm);
 	}
-
-	if (!crtc->active)
-		return;
 }
 
 void skl_wm_get_hw_state(struct drm_i915_private *dev_priv)