| Message ID | 20210219215326.2227596-8-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers | expand |
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss <robert.foss@linaro.org> On Fri, 19 Feb 2021 at 22:56, Lyude Paul <lyude@redhat.com> wrote: > > Surprisingly, this bridge actually registers it's AUX adapter at the > correct time already. Nice job! However, it does forget to actually > unregister the AUX adapter, so let's add a bridge function to handle that. > > Signed-off-by: Lyude Paul <lyude@redhat.com> > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 81debd02c169..ec4607dc01eb 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -942,6 +942,11 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > return 0; > } > > +static void anx78xx_bridge_detach(struct drm_bridge *bridge) > +{ > + drm_dp_aux_unregister(&bridge_to_anx78xx(bridge)->aux); > +} > + > static enum drm_mode_status > anx78xx_bridge_mode_valid(struct drm_bridge *bridge, > const struct drm_display_info *info, > @@ -1013,6 +1018,7 @@ static void anx78xx_bridge_enable(struct drm_bridge *bridge) > > static const struct drm_bridge_funcs anx78xx_bridge_funcs = { > .attach = anx78xx_bridge_attach, > + .detach = anx78xx_bridge_detach, > .mode_valid = anx78xx_bridge_mode_valid, > .disable = anx78xx_bridge_disable, > .mode_set = anx78xx_bridge_mode_set, > -- > 2.29.2 >
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c index 81debd02c169..ec4607dc01eb 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c @@ -942,6 +942,11 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, return 0; } +static void anx78xx_bridge_detach(struct drm_bridge *bridge) +{ + drm_dp_aux_unregister(&bridge_to_anx78xx(bridge)->aux); +} + static enum drm_mode_status anx78xx_bridge_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info, @@ -1013,6 +1018,7 @@ static void anx78xx_bridge_enable(struct drm_bridge *bridge) static const struct drm_bridge_funcs anx78xx_bridge_funcs = { .attach = anx78xx_bridge_attach, + .detach = anx78xx_bridge_detach, .mode_valid = anx78xx_bridge_mode_valid, .disable = anx78xx_bridge_disable, .mode_set = anx78xx_bridge_mode_set,
Surprisingly, this bridge actually registers it's AUX adapter at the correct time already. Nice job! However, it does forget to actually unregister the AUX adapter, so let's add a bridge function to handle that. Signed-off-by: Lyude Paul <lyude@redhat.com> --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 6 ++++++ 1 file changed, 6 insertions(+)