diff mbox series

[v2,07/23] drm/i915/xelpd: add XE_LPD display characteristics

Message ID 20210311153415.3024607-8-matthew.d.roper@intel.com (mailing list archive)
State New, archived
Headers show
Series Separate display version numbering and add XE_LPD (version 13) | expand

Commit Message

Matt Roper March 11, 2021, 3:33 p.m. UTC
Let's start preparing for upcoming platforms that will use an XE_LPD
design.

v2:
 - Use the now-preferred "XE_LPD" term to refer to this design
 - Utilize DISPLAY_VER() rather than a feature flag
 - Drop unused mbus_size field (Lucas)

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Jani Nikula March 17, 2021, 5:15 p.m. UTC | #1
On Thu, 11 Mar 2021, Matt Roper <matthew.d.roper@intel.com> wrote:
> Let's start preparing for upcoming platforms that will use an XE_LPD
> design.
>
> v2:
>  - Use the now-preferred "XE_LPD" term to refer to this design
>  - Utilize DISPLAY_VER() rather than a feature flag
>  - Drop unused mbus_size field (Lucas)
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 5bfd94e2cc6f..3f06502e1d85 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -936,6 +936,16 @@ static const struct intel_device_info adl_s_info = {
>  	.dma_mask_size = 46,
>  };
>  
> +#define XE_LPD_FEATURES \
> +	.display_ver = 13,						\

I guess this begs the question why .display_ver and not
.display.version, if we want to keep the display substruct.

Side note, a lot of the stuff below should be moved under display too,
but that's for another series.

BR,
Jani.

> +	.display.has_psr_hw_tracking = 0,				\
> +	.abox_mask = GENMASK(1, 0),					\
> +	.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
> +	.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |	\
> +		BIT(TRANSCODER_C) | BIT(TRANSCODER_D),			\
> +	.ddb_size = 4096,						\
> +	.num_supported_dbuf_slices = 4
> +
>  #undef GEN
>  #undef PLATFORM
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 5bfd94e2cc6f..3f06502e1d85 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -936,6 +936,16 @@  static const struct intel_device_info adl_s_info = {
 	.dma_mask_size = 46,
 };
 
+#define XE_LPD_FEATURES \
+	.display_ver = 13,						\
+	.display.has_psr_hw_tracking = 0,				\
+	.abox_mask = GENMASK(1, 0),					\
+	.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
+	.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |	\
+		BIT(TRANSCODER_C) | BIT(TRANSCODER_D),			\
+	.ddb_size = 4096,						\
+	.num_supported_dbuf_slices = 4
+
 #undef GEN
 #undef PLATFORM