diff mbox series

drivers: gpu: drm: Remove repeated declaration

Message ID 20210325050059.848207-1-wanjiabing@vivo.com (mailing list archive)
State New, archived
Headers show
Series drivers: gpu: drm: Remove repeated declaration | expand

Commit Message

Wan Jiabing March 25, 2021, 5 a.m. UTC
struct drm_i915_private, struct intel_crtc_state and
struct intel_crtc have been declared before. 
Remove the duplicate.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/gpu/drm/i915/display/intel_crt.h     | 1 -
 drivers/gpu/drm/i915/display/intel_display.h | 1 -
 drivers/gpu/drm/i915/display/intel_vrr.h     | 1 -
 3 files changed, 3 deletions(-)

Comments

Souza, Jose March 25, 2021, 9:04 p.m. UTC | #1
The changes looks good but can you resend changing the commit message to: "drm/i915: Remove repeated declaration"?
To better match with i915 patches.

With this change you can add

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

On Thu, 2021-03-25 at 13:00 +0800, Wan Jiabing wrote:
> struct drm_i915_private, struct intel_crtc_state and
> struct intel_crtc have been declared before. 
> Remove the duplicate.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/gpu/drm/i915/display/intel_crt.h     | 1 -
>  drivers/gpu/drm/i915/display/intel_display.h | 1 -
>  drivers/gpu/drm/i915/display/intel_vrr.h     | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.h b/drivers/gpu/drm/i915/display/intel_crt.h
> index 1b3fba359efc..6c5c44600cbd 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.h
> +++ b/drivers/gpu/drm/i915/display/intel_crt.h
> @@ -11,7 +11,6 @@
>  enum pipe;
>  struct drm_encoder;
>  struct drm_i915_private;
> -struct drm_i915_private;
>  
> 
>  bool intel_crt_port_enabled(struct drm_i915_private *dev_priv,
>  			    i915_reg_t adpa_reg, enum pipe *pipe);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 76f8a805b0a3..29cb6d84ed70 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -48,7 +48,6 @@ struct i915_ggtt_view;
>  struct intel_atomic_state;
>  struct intel_crtc;
>  struct intel_crtc_state;
> -struct intel_crtc_state;
>  struct intel_digital_port;
>  struct intel_dp;
>  struct intel_encoder;
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h b/drivers/gpu/drm/i915/display/intel_vrr.h
> index fac01bf4ab50..96f9c9c27ab9 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.h
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.h
> @@ -15,7 +15,6 @@ struct intel_crtc;
>  struct intel_crtc_state;
>  struct intel_dp;
>  struct intel_encoder;
> -struct intel_crtc;
>  
> 
>  bool intel_vrr_is_capable(struct drm_connector *connector);
>  void intel_vrr_check_modeset(struct intel_atomic_state *state);
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_crt.h b/drivers/gpu/drm/i915/display/intel_crt.h
index 1b3fba359efc..6c5c44600cbd 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.h
+++ b/drivers/gpu/drm/i915/display/intel_crt.h
@@ -11,7 +11,6 @@ 
 enum pipe;
 struct drm_encoder;
 struct drm_i915_private;
-struct drm_i915_private;
 
 bool intel_crt_port_enabled(struct drm_i915_private *dev_priv,
 			    i915_reg_t adpa_reg, enum pipe *pipe);
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 76f8a805b0a3..29cb6d84ed70 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -48,7 +48,6 @@  struct i915_ggtt_view;
 struct intel_atomic_state;
 struct intel_crtc;
 struct intel_crtc_state;
-struct intel_crtc_state;
 struct intel_digital_port;
 struct intel_dp;
 struct intel_encoder;
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h b/drivers/gpu/drm/i915/display/intel_vrr.h
index fac01bf4ab50..96f9c9c27ab9 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.h
+++ b/drivers/gpu/drm/i915/display/intel_vrr.h
@@ -15,7 +15,6 @@  struct intel_crtc;
 struct intel_crtc_state;
 struct intel_dp;
 struct intel_encoder;
-struct intel_crtc;
 
 bool intel_vrr_is_capable(struct drm_connector *connector);
 void intel_vrr_check_modeset(struct intel_atomic_state *state);