| Message ID | 20210614092227.97421-1-matthew.auld@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: allow DG1 autoprobe for CONFIG_BROKEN | expand |
On 6/14/21 11:22 AM, Matthew Auld wrote: > Purely for CI so we can get some pre-merge results for DG1. This is > especially useful for cross driver TTM changes where CI can hopefully > catch regressions. This is similar to how we already handle the DG1 > specific uAPI, which are also hidden behind CONFIG_BROKEN. > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Dave Airlie <airlied@gmail.com> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> + CC: Christian König, With this in place, I think The mock memory_region and hugepages selftests will be sensitive to changes in TTM on most intel platforms, as well as all DG1 selftests, and any passing DG1 igt tests. /Thomas
Op 14-06-2021 om 11:22 schreef Matthew Auld: > Purely for CI so we can get some pre-merge results for DG1. This is > especially useful for cross driver TTM changes where CI can hopefully > catch regressions. This is similar to how we already handle the DG1 > specific uAPI, which are also hidden behind CONFIG_BROKEN. > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Dave Airlie <airlied@gmail.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 83b500bb170c..78742157aaa3 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1040,6 +1040,9 @@ static const struct pci_device_id pciidlist[] = { > INTEL_RKL_IDS(&rkl_info), > INTEL_ADLS_IDS(&adl_s_info), > INTEL_ADLP_IDS(&adl_p_info), > +#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM) > + INTEL_DG1_IDS(&dg1_info), > +#endif > {0, 0, 0} > }; > MODULE_DEVICE_TABLE(pci, pciidlist); Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
On Mon, 14 Jun 2021 at 10:22, Matthew Auld <matthew.auld@intel.com> wrote: > > Purely for CI so we can get some pre-merge results for DG1. This is > especially useful for cross driver TTM changes where CI can hopefully > catch regressions. This is similar to how we already handle the DG1 > specific uAPI, which are also hidden behind CONFIG_BROKEN. > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Dave Airlie <airlied@gmail.com> Daniel, any objections to landing this? > --- > drivers/gpu/drm/i915/i915_pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 83b500bb170c..78742157aaa3 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1040,6 +1040,9 @@ static const struct pci_device_id pciidlist[] = { > INTEL_RKL_IDS(&rkl_info), > INTEL_ADLS_IDS(&adl_s_info), > INTEL_ADLP_IDS(&adl_p_info), > +#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM) > + INTEL_DG1_IDS(&dg1_info), > +#endif > {0, 0, 0} > }; > MODULE_DEVICE_TABLE(pci, pciidlist); > -- > 2.26.3 >
On Wed, Jun 16, 2021 at 03:29:26PM +0100, Matthew Auld wrote: > On Mon, 14 Jun 2021 at 10:22, Matthew Auld <matthew.auld@intel.com> wrote: > > > > Purely for CI so we can get some pre-merge results for DG1. This is > > especially useful for cross driver TTM changes where CI can hopefully > > catch regressions. This is similar to how we already handle the DG1 > > specific uAPI, which are also hidden behind CONFIG_BROKEN. > > > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Dave Airlie <airlied@gmail.com> > > Daniel, any objections to landing this? I think stuffing this into topic/core-for-CI is fine, lets wait a bit more until mesa and everything is ready with adding the pciids to an official tree. (Catching up on mails, apologies and all that). -Daniel > > > --- > > drivers/gpu/drm/i915/i915_pci.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > > index 83b500bb170c..78742157aaa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -1040,6 +1040,9 @@ static const struct pci_device_id pciidlist[] = { > > INTEL_RKL_IDS(&rkl_info), > > INTEL_ADLS_IDS(&adl_s_info), > > INTEL_ADLP_IDS(&adl_p_info), > > +#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM) > > + INTEL_DG1_IDS(&dg1_info), > > +#endif > > {0, 0, 0} > > }; > > MODULE_DEVICE_TABLE(pci, pciidlist); > > -- > > 2.26.3 > >
On Thu, 17 Jun 2021, Daniel Vetter <daniel@ffwll.ch> wrote: > I think stuffing this into topic/core-for-CI is fine, lets wait a bit more > until mesa and everything is ready with adding the pciids to an official > tree. On a related note, I think we'll need rationale documented for each commit in topic/core-for-CI going forward. Why is the commit in topic/core-for-CI? What's the plan for moving it out? Etc. topic/core-for-CI has become a dumping ground for odd patches without proper rationale why they exist. The ideal is zero commits in the branch. BR, Jani.
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 83b500bb170c..78742157aaa3 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1040,6 +1040,9 @@ static const struct pci_device_id pciidlist[] = { INTEL_RKL_IDS(&rkl_info), INTEL_ADLS_IDS(&adl_s_info), INTEL_ADLP_IDS(&adl_p_info), +#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM) + INTEL_DG1_IDS(&dg1_info), +#endif {0, 0, 0} }; MODULE_DEVICE_TABLE(pci, pciidlist);
Purely for CI so we can get some pre-merge results for DG1. This is especially useful for cross driver TTM changes where CI can hopefully catch regressions. This is similar to how we already handle the DG1 specific uAPI, which are also hidden behind CONFIG_BROKEN. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Dave Airlie <airlied@gmail.com> --- drivers/gpu/drm/i915/i915_pci.c | 3 +++ 1 file changed, 3 insertions(+)