| Message ID | 20210622165511.3169559-2-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | implicit fencing/dma-resv rules for shared buffers | expand |
On Tue, Jun 22, 2021 at 12:55 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > Oversight from > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > Author: Christian König <christian.koenig@amd.com> > Date: Mon May 10 16:14:09 2021 +0200 > > dma-buf: rename and cleanup dma_resv_get_excl v3 > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > include/linux/dma-resv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > index 562b885cf9c3..e1ca2080a1ff 100644 > --- a/include/linux/dma-resv.h > +++ b/include/linux/dma-resv.h > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) > } > > /** > - * dma_resv_exclusive - return the object's exclusive fence > + * dma_resv_excl_fence - return the object's exclusive fence > * @obj: the reservation object > * > * Returns the exclusive fence (if any). Caller must either hold the objects > -- > 2.32.0.rc2 >
Hi Daniel, On Tue, Jun 22, 2021 at 06:54:57PM +0200, Daniel Vetter wrote: > Oversight from > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > Author: Christian König <christian.koenig@amd.com> > Date: Mon May 10 16:14:09 2021 +0200 this is what we uses Fixes: ... for. It looks wrong to hide it in the description. Sam > > dma-buf: rename and cleanup dma_resv_get_excl v3 > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > --- > include/linux/dma-resv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > index 562b885cf9c3..e1ca2080a1ff 100644 > --- a/include/linux/dma-resv.h > +++ b/include/linux/dma-resv.h > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) > } > > /** > - * dma_resv_exclusive - return the object's exclusive fence > + * dma_resv_excl_fence - return the object's exclusive fence > * @obj: the reservation object > * > * Returns the exclusive fence (if any). Caller must either hold the objects > -- > 2.32.0.rc2
On Tue, Jun 22, 2021 at 8:50 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Daniel, > > On Tue, Jun 22, 2021 at 06:54:57PM +0200, Daniel Vetter wrote: > > Oversight from > > > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > > Author: Christian König <christian.koenig@amd.com> > > Date: Mon May 10 16:14:09 2021 +0200 > > this is what we uses Fixes: ... for. > > It looks wrong to hide it in the description. I've honestly become a bit vary of using Fixes: for docs/comments because the stable autoselect bots are _really_ keen on picking up anything with a Fixes: line in it. And that feels a bit like nonsense. -Daniel > > Sam > > > > > dma-buf: rename and cleanup dma_resv_get_excl v3 > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > Cc: "Christian König" <christian.koenig@amd.com> > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > --- > > include/linux/dma-resv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > > index 562b885cf9c3..e1ca2080a1ff 100644 > > --- a/include/linux/dma-resv.h > > +++ b/include/linux/dma-resv.h > > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) > > } > > > > /** > > - * dma_resv_exclusive - return the object's exclusive fence > > + * dma_resv_excl_fence - return the object's exclusive fence > > * @obj: the reservation object > > * > > * Returns the exclusive fence (if any). Caller must either hold the objects > > -- > > 2.32.0.rc2
Am 22.06.21 um 18:54 schrieb Daniel Vetter: > Oversight from > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > Author: Christian König <christian.koenig@amd.com> > Date: Mon May 10 16:14:09 2021 +0200 > > dma-buf: rename and cleanup dma_resv_get_excl v3 > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org Reviewed-by: Christian König <christian.koenig@amd.com> > --- > include/linux/dma-resv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > index 562b885cf9c3..e1ca2080a1ff 100644 > --- a/include/linux/dma-resv.h > +++ b/include/linux/dma-resv.h > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) > } > > /** > - * dma_resv_exclusive - return the object's exclusive fence > + * dma_resv_excl_fence - return the object's exclusive fence > * @obj: the reservation object > * > * Returns the exclusive fence (if any). Caller must either hold the objects
On Wed, Jun 23, 2021 at 10:31:18AM +0200, Christian König wrote: > Am 22.06.21 um 18:54 schrieb Daniel Vetter: > > Oversight from > > > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > > Author: Christian König <christian.koenig@amd.com> > > Date: Mon May 10 16:14:09 2021 +0200 > > > > dma-buf: rename and cleanup dma_resv_get_excl v3 > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > Cc: "Christian König" <christian.koenig@amd.com> > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Reviewed-by: Christian König <christian.koenig@amd.com> Pushed to drm-misc-next. -Daniel > > > --- > > include/linux/dma-resv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > > index 562b885cf9c3..e1ca2080a1ff 100644 > > --- a/include/linux/dma-resv.h > > +++ b/include/linux/dma-resv.h > > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) > > } > > /** > > - * dma_resv_exclusive - return the object's exclusive fence > > + * dma_resv_excl_fence - return the object's exclusive fence > > * @obj: the reservation object > > * > > * Returns the exclusive fence (if any). Caller must either hold the objects >
diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h index 562b885cf9c3..e1ca2080a1ff 100644 --- a/include/linux/dma-resv.h +++ b/include/linux/dma-resv.h @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struct dma_resv *obj) } /** - * dma_resv_exclusive - return the object's exclusive fence + * dma_resv_excl_fence - return the object's exclusive fence * @obj: the reservation object * * Returns the exclusive fence (if any). Caller must either hold the objects
Oversight from commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 Author: Christian König <christian.koenig@amd.com> Date: Mon May 10 16:14:09 2021 +0200 dma-buf: rename and cleanup dma_resv_get_excl v3 Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: "Christian König" <christian.koenig@amd.com> Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org --- include/linux/dma-resv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)