| Message ID | 20210716061634.2446357-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] vgaarb: remove VGA_DEFAULT_DEVICE | expand |
Am 16.07.21 um 08:16 schrieb Christoph Hellwig: > The define is entirely unused. > > Signed-off-by: Christoph Hellwig <hch@lst.de> I'm not an expert for this particular code, but at least of hand everything you do here makes totally sense. Whole series is Acked-by: Christian König <christian.koenig@amd.com> Regards, Christian. > --- > include/linux/vgaarb.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h > index dc6ddce92066..26ec8a057d2a 100644 > --- a/include/linux/vgaarb.h > +++ b/include/linux/vgaarb.h > @@ -42,12 +42,6 @@ > #define VGA_RSRC_NORMAL_IO 0x04 > #define VGA_RSRC_NORMAL_MEM 0x08 > > -/* Passing that instead of a pci_dev to use the system "default" > - * device, that is the one used by vgacon. Archs will probably > - * have to provide their own vga_default_device(); > - */ > -#define VGA_DEFAULT_DEVICE (NULL) > - > struct pci_dev; > > /* For use by clients */
On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote: > Am 16.07.21 um 08:16 schrieb Christoph Hellwig: > > The define is entirely unused. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > I'm not an expert for this particular code, but at least of hand everything > you do here makes totally sense. > > Whole series is Acked-by: Christian König <christian.koenig@amd.com> Care to also push this into drm-misc-next since you looked already? -Daniel > > Regards, > Christian. > > > --- > > include/linux/vgaarb.h | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h > > index dc6ddce92066..26ec8a057d2a 100644 > > --- a/include/linux/vgaarb.h > > +++ b/include/linux/vgaarb.h > > @@ -42,12 +42,6 @@ > > #define VGA_RSRC_NORMAL_IO 0x04 > > #define VGA_RSRC_NORMAL_MEM 0x08 > > -/* Passing that instead of a pci_dev to use the system "default" > > - * device, that is the one used by vgacon. Archs will probably > > - * have to provide their own vga_default_device(); > > - */ > > -#define VGA_DEFAULT_DEVICE (NULL) > > - > > struct pci_dev; > > /* For use by clients */ >
Am 20.07.21 um 15:50 schrieb Daniel Vetter: > On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote: >> Am 16.07.21 um 08:16 schrieb Christoph Hellwig: >>> The define is entirely unused. >>> >>> Signed-off-by: Christoph Hellwig <hch@lst.de> >> I'm not an expert for this particular code, but at least of hand everything >> you do here makes totally sense. >> >> Whole series is Acked-by: Christian König <christian.koenig@amd.com> > Care to also push this into drm-misc-next since you looked already? Sure, but Christoph doesn't has push access himself? Christian. > -Daniel > >> Regards, >> Christian. >> >>> --- >>> include/linux/vgaarb.h | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h >>> index dc6ddce92066..26ec8a057d2a 100644 >>> --- a/include/linux/vgaarb.h >>> +++ b/include/linux/vgaarb.h >>> @@ -42,12 +42,6 @@ >>> #define VGA_RSRC_NORMAL_IO 0x04 >>> #define VGA_RSRC_NORMAL_MEM 0x08 >>> -/* Passing that instead of a pci_dev to use the system "default" >>> - * device, that is the one used by vgacon. Archs will probably >>> - * have to provide their own vga_default_device(); >>> - */ >>> -#define VGA_DEFAULT_DEVICE (NULL) >>> - >>> struct pci_dev; >>> /* For use by clients */
Am 20.07.21 um 15:50 schrieb Daniel Vetter: > On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote: >> Am 16.07.21 um 08:16 schrieb Christoph Hellwig: >>> The define is entirely unused. >>> >>> Signed-off-by: Christoph Hellwig <hch@lst.de> >> I'm not an expert for this particular code, but at least of hand everything >> you do here makes totally sense. >> >> Whole series is Acked-by: Christian König <christian.koenig@amd.com> > Care to also push this into drm-misc-next since you looked already? Done. Christian. > -Daniel > >> Regards, >> Christian. >> >>> --- >>> include/linux/vgaarb.h | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h >>> index dc6ddce92066..26ec8a057d2a 100644 >>> --- a/include/linux/vgaarb.h >>> +++ b/include/linux/vgaarb.h >>> @@ -42,12 +42,6 @@ >>> #define VGA_RSRC_NORMAL_IO 0x04 >>> #define VGA_RSRC_NORMAL_MEM 0x08 >>> -/* Passing that instead of a pci_dev to use the system "default" >>> - * device, that is the one used by vgacon. Archs will probably >>> - * have to provide their own vga_default_device(); >>> - */ >>> -#define VGA_DEFAULT_DEVICE (NULL) >>> - >>> struct pci_dev; >>> /* For use by clients */
diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h index dc6ddce92066..26ec8a057d2a 100644 --- a/include/linux/vgaarb.h +++ b/include/linux/vgaarb.h @@ -42,12 +42,6 @@ #define VGA_RSRC_NORMAL_IO 0x04 #define VGA_RSRC_NORMAL_MEM 0x08 -/* Passing that instead of a pci_dev to use the system "default" - * device, that is the one used by vgacon. Archs will probably - * have to provide their own vga_default_device(); - */ -#define VGA_DEFAULT_DEVICE (NULL) - struct pci_dev; /* For use by clients */
The define is entirely unused. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)