| Message ID | 20210825152233.2151037-3-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/i915/runtime_pm: Consolidate runtime_pm functions | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo > Vivi > Sent: Wednesday, August 25, 2021 8:53 PM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Daniel Vetter > <daniel.vetter@ffwll.ch>; David Weinehall <david.weinehall@linux.intel.com>; > Tangudu, Tilak <tilak.tangudu@intel.com>; Deak, Imre <imre.deak@intel.com> > Subject: [Intel-gfx] [PATCH 3/4] drm/i915: Enable runtime pm autosuspend by > default > > Let's enable runtime pm autosuspend by default everywhere. > > But at this time let's not touch the autosuspend_delay time, what caused some > regression on our previous attempt. > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: David Weinehall <david.weinehall@linux.intel.com> > Cc: Tilak Tangudu <tilak.tangudu@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > b/drivers/gpu/drm/i915/intel_runtime_pm.c > index f28b5bab61b4..8f052bd4f58c 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -605,6 +605,8 @@ void intel_runtime_pm_enable(struct intel_runtime_pm > *rpm) > pm_runtime_use_autosuspend(kdev); > } > > + pm_runtime_allow(kdev); Looks good to me. Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com> > + > /* > * The core calls the driver load handler with an RPM reference held. > * We drop that here and will reacquire it during unloading in > -- > 2.31.1
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index f28b5bab61b4..8f052bd4f58c 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -605,6 +605,8 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); } + pm_runtime_allow(kdev); + /* * The core calls the driver load handler with an RPM reference held. * We drop that here and will reacquire it during unloading in
Let's enable runtime pm autosuspend by default everywhere. But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt. Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: David Weinehall <david.weinehall@linux.intel.com> Cc: Tilak Tangudu <tilak.tangudu@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 ++ 1 file changed, 2 insertions(+)