| Message ID | 20210825152233.2151037-4-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/i915/runtime_pm: Consolidate runtime_pm functions | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo > Vivi > Sent: Wednesday, August 25, 2021 8:53 PM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Daniel Vetter > <daniel.vetter@ffwll.ch>; David Weinehall <david.weinehall@linux.intel.com>; > Tangudu, Tilak <tilak.tangudu@intel.com> > Subject: [Intel-gfx] [PATCH 4/4] drm/i915/runtime_pm: Reduce autosuspend > delay to 1s. > > Let's try to be more aggressive on the power savings, but not as much as 0.1s > that caused us some regression in the past. In IGT we are already using 0 second as auto suspend delay. Looks good to me. Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com> > > Also let's have this in a separated patch so that can be bisected and increased > back (or reverted) as needed. > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: David Weinehall <david.weinehall@linux.intel.com> > Cc: Tilak Tangudu <tilak.tangudu@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > b/drivers/gpu/drm/i915/intel_runtime_pm.c > index 8f052bd4f58c..3244ac85d13c 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -585,7 +585,7 @@ void intel_runtime_pm_enable(struct intel_runtime_pm > *rpm) > */ > dev_pm_set_driver_flags(kdev, DPM_FLAG_NO_DIRECT_COMPLETE); > > - pm_runtime_set_autosuspend_delay(kdev, 10000); /* 10s */ > + pm_runtime_set_autosuspend_delay(kdev, 1000); /* 1s */ > pm_runtime_mark_last_busy(kdev); > > /* > -- > 2.31.1
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 8f052bd4f58c..3244ac85d13c 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -585,7 +585,7 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) */ dev_pm_set_driver_flags(kdev, DPM_FLAG_NO_DIRECT_COMPLETE); - pm_runtime_set_autosuspend_delay(kdev, 10000); /* 10s */ + pm_runtime_set_autosuspend_delay(kdev, 1000); /* 1s */ pm_runtime_mark_last_busy(kdev); /*
Let's try to be more aggressive on the power savings, but not as much as 0.1s that caused us some regression in the past. Also let's have this in a separated patch so that can be bisected and increased back (or reverted) as needed. Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: David Weinehall <david.weinehall@linux.intel.com> Cc: Tilak Tangudu <tilak.tangudu@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)