| Message ID | 20211003052334.15764-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gvt: clean up kernel-doc in gtt.c | expand |
On 10/3/21 5:23 AM, Randy Dunlap wrote: > Fix kernel-doc warnings in gtt.c: > > gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Check if can do 2M page > gtt.c:1152: warning: missing initial short description on line: > * Check if can do 2M page > gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead > > Fixes: a752b070a678 ("drm/i915/gvt: Fix function comment doc errors") > Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com> > Cc: Zhi Wang <zhi.a.wang@intel.com> > Cc: Colin Xu <colin.xu@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Cc: intel-gvt-dev@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20211001.orig/drivers/gpu/drm/i915/gvt/gtt.c > +++ linux-next-20211001/drivers/gpu/drm/i915/gvt/gtt.c > @@ -1148,7 +1148,7 @@ static inline void ppgtt_generate_shadow > ops->set_pfn(se, s->shadow_page.mfn); > } > > -/** > +/* > * Check if can do 2M page > * @vgpu: target vgpu > * @entry: target pfn's gtt entry > @@ -2193,7 +2193,7 @@ static int emulate_ggtt_mmio_read(struct > } > > /** > - * intel_vgpu_emulate_gtt_mmio_read - emulate GTT MMIO register read > + * intel_vgpu_emulate_ggtt_mmio_read - emulate GTT MMIO register read > * @vgpu: a vGPU > * @off: register offset > * @p_data: data will be returned to guest > Thanks for the patch. queued. Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
--- linux-next-20211001.orig/drivers/gpu/drm/i915/gvt/gtt.c +++ linux-next-20211001/drivers/gpu/drm/i915/gvt/gtt.c @@ -1148,7 +1148,7 @@ static inline void ppgtt_generate_shadow ops->set_pfn(se, s->shadow_page.mfn); } -/** +/* * Check if can do 2M page * @vgpu: target vgpu * @entry: target pfn's gtt entry @@ -2193,7 +2193,7 @@ static int emulate_ggtt_mmio_read(struct } /** - * intel_vgpu_emulate_gtt_mmio_read - emulate GTT MMIO register read + * intel_vgpu_emulate_ggtt_mmio_read - emulate GTT MMIO register read * @vgpu: a vGPU * @off: register offset * @p_data: data will be returned to guest
Fix kernel-doc warnings in gtt.c: gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Check if can do 2M page gtt.c:1152: warning: missing initial short description on line: * Check if can do 2M page gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead Fixes: a752b070a678 ("drm/i915/gvt: Fix function comment doc errors") Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> Cc: Zhi Wang <zhi.a.wang@intel.com> Cc: Colin Xu <colin.xu@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-gfx@lists.freedesktop.org Cc: intel-gvt-dev@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)