| Message ID | 20211015091129.83226-1-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Clean-up bonding debug message. | expand |
On Fri, 15 Oct 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > We should stop using the gen name and the "+" to reference > the newer platforms. > And on this case specifically we can simplify the debug > message even further. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index d225d3dd0b40..30759b651180 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -479,7 +479,7 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data) > if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) && > !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) { > drm_dbg(&i915->drm, > - "Bonding on gen12+ aside from TGL, RKL, and ADL_S not supported\n"); > + "Bonding not supported on this platform\n"); > return -ENODEV; > }
On Mon, Oct 18, 2021 at 11:24:21AM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > We should stop using the gen name and the "+" to reference > > the newer platforms. > > And on this case specifically we can simplify the debug > > message even further. > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> thanks, pushed > > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > Cc: Matthew Brost <matthew.brost@intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > index d225d3dd0b40..30759b651180 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > @@ -479,7 +479,7 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data) > > if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) && > > !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) { > > drm_dbg(&i915->drm, > > - "Bonding on gen12+ aside from TGL, RKL, and ADL_S not supported\n"); > > + "Bonding not supported on this platform\n"); > > return -ENODEV; > > } > > -- > Jani Nikula, Intel Open Source Graphics Center
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index d225d3dd0b40..30759b651180 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -479,7 +479,7 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data) if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) && !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) { drm_dbg(&i915->drm, - "Bonding on gen12+ aside from TGL, RKL, and ADL_S not supported\n"); + "Bonding not supported on this platform\n"); return -ENODEV; }
We should stop using the gen name and the "+" to reference the newer platforms. And on this case specifically we can simplify the debug message even further. Cc: Jani Nikula <jani.nikula@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)