| Message ID | 20211116155238.3226516-1-tilak.tangudu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/i915/rpm: Enable runtime pm autosuspend by default | expand |
> -----Original Message----- > From: Tangudu, Tilak <tilak.tangudu@intel.com> > Sent: Tuesday, November 16, 2021 9:23 PM > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Tangudu, Tilak <tilak.tangudu@intel.com>; Ewins, Jon > <jon.ewins@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Nilawar, Badal > <badal.nilawar@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>; > Syrjala, Ville <ville.syrjala@intel.com> > Subject: [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default > > v1: Enable runtime pm autosuspend by default for Gen12 and later versions. > > v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) > > v3: Change commit message(Nikula Jani) > Let's enable runtime pm autosuspend by default everywhere. > So, we can allow D3hot and bigger power savings on idle scenarios. > > But at this time let's not touch the autosuspend_delay time, what caused some > regression on our previous attempt. > > Also, the latest identified issue on GuC PM has been fixed by commit > 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering > context") > > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > b/drivers/gpu/drm/i915/intel_runtime_pm.c > index 0d85f3c5c526..22dab36afcb6 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm > *rpm) > pm_runtime_use_autosuspend(kdev); > } > > + /* Enable by default */ > + pm_runtime_allow(kdev); > + BAT is failing due to soft lockup on SKL. How about to enable the runtime PM only for discrete platforms till we fixes all issues on Gen9 for hybrid gfx use cases. (when discrete card will used only for rendering) Thanks, Anshuman Gupta. > /* > * The core calls the driver load handler with an RPM reference held. > * We drop that here and will reacquire it during unloading in > -- > 2.25.1
Hi Lakshmi ,
Could you please create a gitlab issue for the below failure and re-report the results.
Below failure is present on drm-tip builds as well not related to this patch.
• igt@kms_psr@primary_page_flip:
o fi-skl-6600u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-skl-6600u/igt@kms_psr@primary_page_flip.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
Thanks ,
Anshuman Gupta
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Patchwork
Sent: Thursday, November 18, 2021 4:29 AM
To: Tangudu, Tilak <tilak.tangudu@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)
Patch Details
Series:
drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)
URL:
https://patchwork.freedesktop.org/series/96741/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/index.html
CI Bug Log - changes from CI_DRM_10896 -> Patchwork_21622
Summary
FAILURE
Serious unknown changes coming with Patchwork_21622 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21622, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/index.html
Participating hosts (40 -> 34)
Additional (1): fi-tgl-1115g4
Missing (7): bat-dg1-6 fi-tgl-u2 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 bat-jsl-2 bat-jsl-1
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_21622:
IGT changes
Possible regressions
• igt@gem_lmem_swapping@verify-random:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@gem_lmem_swapping@verify-random.html +3 similar issues
• igt@kms_psr@primary_page_flip:
o fi-skl-6600u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-skl-6600u/igt@kms_psr@primary_page_flip.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
Known issues
Here are the changes found in Patchwork_21622 that come from known issues:
IGT changes
Issues hit
• igt@amdgpu/amd_basic@query-info:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html (https://bugs.freedesktop.org/show_bug.cgi?id=109315)
• igt@amdgpu/amd_cs_nop@nop-gfx0:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html (https://bugs.freedesktop.org/show_bug.cgi?id=109315 / https://gitlab.freedesktop.org/drm/intel/issues/2575) +16 similar issues
• igt@amdgpu/amd_cs_nop@sync-fork-compute0:
o fi-snb-2600: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +17 similar issues
• igt@gem_huc_copy@huc-copy:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html (https://gitlab.freedesktop.org/drm/intel/issues/2190)
• igt@i915_pm_backlight@basic-brightness:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html (https://gitlab.freedesktop.org/drm/intel/issues/1155)
• igt@i915_selftest@live@execlists:
o fi-bsw-nick: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-bsw-nick/igt@i915_selftest@live@execlists.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-bsw-nick/igt@i915_selftest@live@execlists.html (https://gitlab.freedesktop.org/drm/intel/issues/2940)
• igt@i915_selftest@live@workarounds:
o fi-rkl-guc: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-rkl-guc/igt@i915_selftest@live@workarounds.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-rkl-guc/igt@i915_selftest@live@workarounds.html (https://gitlab.freedesktop.org/drm/intel/issues/4433)
• igt@kms_chamelium@common-hpd-after-suspend:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html (https://bugs.freedesktop.org/show_bug.cgi?id=111827) +8 similar issues
• igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html (https://gitlab.freedesktop.org/drm/intel/issues/4103) +1 similar issue
• igt@kms_force_connector_basic@force-load-detect:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html (https://bugs.freedesktop.org/show_bug.cgi?id=109285)
• igt@kms_psr@primary_mmap_gtt:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html (https://gitlab.freedesktop.org/drm/intel/issues/1072) +3 similar issues
• igt@prime_vgem@basic-userptr:
o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html (https://gitlab.freedesktop.org/drm/intel/issues/3301)
• igt@runner@aborted:
o fi-skl-6600u: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/3363 / https://gitlab.freedesktop.org/drm/intel/issues/4312)
o fi-bsw-nick: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-bsw-nick/igt@runner@aborted.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271 / https://gitlab.freedesktop.org/drm/intel/issues/1436 / https://gitlab.freedesktop.org/drm/intel/issues/3428 / https://gitlab.freedesktop.org/drm/intel/issues/4312)
Possible fixes
• igt@i915_selftest@live@evict:
o fi-kbl-soraka: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-kbl-soraka/igt@i915_selftest@live@evict.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-kbl-soraka/igt@i915_selftest@live@evict.html
• igt@i915_selftest@live@hangcheck:
o fi-snb-2600: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-snb-2600/igt@i915_selftest@live@hangcheck.html (https://gitlab.freedesktop.org/drm/intel/issues/3921) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
• igt@kms_frontbuffer_tracking@basic:
o fi-cml-u2: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html (https://gitlab.freedesktop.org/drm/intel/issues/4269) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
Warnings
• igt@runner@aborted:
o fi-rkl-guc: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-rkl-guc/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/3928 / https://gitlab.freedesktop.org/drm/intel/issues/4312) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-rkl-guc/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/2426 / https://gitlab.freedesktop.org/drm/intel/issues/3928 / https://gitlab.freedesktop.org/drm/intel/issues/4312)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
• Linux: CI_DRM_10896 -> Patchwork_21622
CI-20190529: 20190529
CI_DRM_10896: bf11e5f354ac51635d032893d80a1d0015d277dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6283: a2cd90a7c24bb7a4c19ca74c75ed8c950820dee2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21622: 484aebf14e509e06b03907388f3536fbd012bc66 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
484aebf14e50 drm/i915/rpm: Enable runtime pm autosuspend by default
Re-reported. -----Original Message----- From: Gupta, Anshuman <anshuman.gupta@intel.com> Sent: Friday, November 19, 2021 2:40 AM To: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Cc: Tangudu, Tilak <tilak.tangudu@intel.com>; intel-gfx@lists.freedesktop.org Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) Hi Lakshmi , Could you please create a gitlab issue for the below failure and re-report the results. Below failure is present on drm-tip builds as well not related to this patch. • igt@kms_psr@primary_page_flip: o fi-skl-6600u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-skl-6600u/igt@kms_psr@primary_page_flip.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@kms_psr@primary_page_flip.html Thanks , Anshuman Gupta From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Patchwork Sent: Thursday, November 18, 2021 4:29 AM To: Tangudu, Tilak <tilak.tangudu@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) Patch Details Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) URL: https://patchwork.freedesktop.org/series/96741/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/index.html CI Bug Log - changes from CI_DRM_10896 -> Patchwork_21622 Summary FAILURE Serious unknown changes coming with Patchwork_21622 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_21622, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/index.html Participating hosts (40 -> 34) Additional (1): fi-tgl-1115g4 Missing (7): bat-dg1-6 fi-tgl-u2 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 bat-jsl-2 bat-jsl-1 Possible new issues Here are the unknown changes that may have been introduced in Patchwork_21622: IGT changes Possible regressions • igt@gem_lmem_swapping@verify-random: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@gem_lmem_swapping@verify-random.html +3 similar issues • igt@kms_psr@primary_page_flip: o fi-skl-6600u: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-skl-6600u/igt@kms_psr@primary_page_flip.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@kms_psr@primary_page_flip.html Known issues Here are the changes found in Patchwork_21622 that come from known issues: IGT changes Issues hit • igt@amdgpu/amd_basic@query-info: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html (https://bugs.freedesktop.org/show_bug.cgi?id=109315) • igt@amdgpu/amd_cs_nop@nop-gfx0: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html (https://bugs.freedesktop.org/show_bug.cgi?id=109315 / https://gitlab.freedesktop.org/drm/intel/issues/2575) +16 similar issues • igt@amdgpu/amd_cs_nop@sync-fork-compute0: o fi-snb-2600: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271) +17 similar issues • igt@gem_huc_copy@huc-copy: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html (https://gitlab.freedesktop.org/drm/intel/issues/2190) • igt@i915_pm_backlight@basic-brightness: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html (https://gitlab.freedesktop.org/drm/intel/issues/1155) • igt@i915_selftest@live@execlists: o fi-bsw-nick: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-bsw-nick/igt@i915_selftest@live@execlists.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-bsw-nick/igt@i915_selftest@live@execlists.html (https://gitlab.freedesktop.org/drm/intel/issues/2940) • igt@i915_selftest@live@workarounds: o fi-rkl-guc: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-rkl-guc/igt@i915_selftest@live@workarounds.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-rkl-guc/igt@i915_selftest@live@workarounds.html (https://gitlab.freedesktop.org/drm/intel/issues/4433) • igt@kms_chamelium@common-hpd-after-suspend: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html (https://bugs.freedesktop.org/show_bug.cgi?id=111827) +8 similar issues • igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html (https://gitlab.freedesktop.org/drm/intel/issues/4103) +1 similar issue • igt@kms_force_connector_basic@force-load-detect: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html (https://bugs.freedesktop.org/show_bug.cgi?id=109285) • igt@kms_psr@primary_mmap_gtt: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html (https://gitlab.freedesktop.org/drm/intel/issues/1072) +3 similar issues • igt@prime_vgem@basic-userptr: o fi-tgl-1115g4: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html (https://gitlab.freedesktop.org/drm/intel/issues/3301) • igt@runner@aborted: o fi-skl-6600u: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-skl-6600u/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/3363 / https://gitlab.freedesktop.org/drm/intel/issues/4312) o fi-bsw-nick: NOTRUN -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-bsw-nick/igt@runner@aborted.html (https://bugs.freedesktop.org/show_bug.cgi?id=109271 / https://gitlab.freedesktop.org/drm/intel/issues/1436 / https://gitlab.freedesktop.org/drm/intel/issues/3428 / https://gitlab.freedesktop.org/drm/intel/issues/4312) Possible fixes • igt@i915_selftest@live@evict: o fi-kbl-soraka: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-kbl-soraka/igt@i915_selftest@live@evict.html -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-kbl-soraka/igt@i915_selftest@live@evict.html • igt@i915_selftest@live@hangcheck: o fi-snb-2600: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-snb-2600/igt@i915_selftest@live@hangcheck.html (https://gitlab.freedesktop.org/drm/intel/issues/3921) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-snb-2600/igt@i915_selftest@live@hangcheck.html • igt@kms_frontbuffer_tracking@basic: o fi-cml-u2: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html (https://gitlab.freedesktop.org/drm/intel/issues/4269) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html Warnings • igt@runner@aborted: o fi-rkl-guc: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-rkl-guc/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/3928 / https://gitlab.freedesktop.org/drm/intel/issues/4312) -> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21622/fi-rkl-guc/igt@runner@aborted.html (https://gitlab.freedesktop.org/drm/intel/issues/2426 / https://gitlab.freedesktop.org/drm/intel/issues/3928 / https://gitlab.freedesktop.org/drm/intel/issues/4312) {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). Build changes • Linux: CI_DRM_10896 -> Patchwork_21622 CI-20190529: 20190529 CI_DRM_10896: bf11e5f354ac51635d032893d80a1d0015d277dc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6283: a2cd90a7c24bb7a4c19ca74c75ed8c950820dee2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21622: 484aebf14e509e06b03907388f3536fbd012bc66 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 484aebf14e50 drm/i915/rpm: Enable runtime pm autosuspend by default
On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote: > v1: Enable runtime pm autosuspend by default for Gen12 > and later versions. > > v2: Enable runtime pm autosuspend by default for all > platforms(Syrjala Ville) > > v3: Change commit message(Nikula Jani) It would require to reorder the commit log, version log need to move after commit message. Thanks, Anshuman. > Let's enable runtime pm autosuspend by default everywhere. > So, we can allow D3hot and bigger power savings on idle scenarios. > > But at this time let's not touch the autosuspend_delay time, > what caused some regression on our previous attempt. > > Also, the latest identified issue on GuC PM has been fixed by > commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering > context") > > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c > index 0d85f3c5c526..22dab36afcb6 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) > pm_runtime_use_autosuspend(kdev); > } > > + /* Enable by default */ > + pm_runtime_allow(kdev); > + > /* > * The core calls the driver load handler with an RPM reference held. > * We drop that here and will reacquire it during unloading in > -- > 2.25.1 >
On Mon, Nov 22, 2021 at 07:18:17PM +0530, Anshuman Gupta wrote: > On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote: > > v1: Enable runtime pm autosuspend by default for Gen12 > > and later versions. > > > > v2: Enable runtime pm autosuspend by default for all > > platforms(Syrjala Ville) > > > > v3: Change commit message(Nikula Jani) > It would require to reorder the commit log, version log > need to move after commit message. Well noticed. I changed while pushing. So, for the record: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Thanks, > Anshuman. > > Let's enable runtime pm autosuspend by default everywhere. > > So, we can allow D3hot and bigger power savings on idle scenarios. > > > > But at this time let's not touch the autosuspend_delay time, > > what caused some regression on our previous attempt. > > > > Also, the latest identified issue on GuC PM has been fixed by > > commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering > > context") > > > > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com> > > --- > > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c > > index 0d85f3c5c526..22dab36afcb6 100644 > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > > @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) > > pm_runtime_use_autosuspend(kdev); > > } > > > > + /* Enable by default */ > > + pm_runtime_allow(kdev); > > + > > /* > > * The core calls the driver load handler with an RPM reference held. > > * We drop that here and will reacquire it during unloading in > > -- > > 2.25.1 > >
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 0d85f3c5c526..22dab36afcb6 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); } + /* Enable by default */ + pm_runtime_allow(kdev); + /* * The core calls the driver load handler with an RPM reference held. * We drop that here and will reacquire it during unloading in
v1: Enable runtime pm autosuspend by default for Gen12 and later versions. v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) v3: Change commit message(Nikula Jani) Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios. But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt. Also, the latest identified issue on GuC PM has been fixed by commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering context") Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com> --- drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+)