| Message ID | 20211216115920.15981-1-jslaby@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: remove circ_buf.h includes | expand |
On Thu, 16 Dec 2021, Jiri Slaby <jslaby@suse.cz> wrote: > The last user of macros from that include was removed in 2018 by the > commit below. > > Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc interface") > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_pipe_crc.c | 1 - > drivers/gpu/drm/i915/i915_irq.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c b/drivers/gpu/drm/i915/display/intel_pipe_crc.c > index 8ac263f471be..9070935b0443 100644 > --- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c > +++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c > @@ -24,7 +24,6 @@ > * > */ > > -#include <linux/circ_buf.h> > #include <linux/ctype.h> > #include <linux/debugfs.h> > #include <linux/seq_file.h> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 5b98fb0532b5..e77f644d41e8 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -28,7 +28,6 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > -#include <linux/circ_buf.h> > #include <linux/slab.h> > #include <linux/sysrq.h>
On Thu, 16 Dec 2021, Patchwork <patchwork@emeril.freedesktop.org> wrote: > == Series Details == > > Series: drm/i915: remove circ_buf.h includes > URL : https://patchwork.freedesktop.org/series/98130/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 24a5cb6b532c drm/i915: remove circ_buf.h includes > -:44: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jiri Slaby <jirislaby@kernel.org>' != 'Signed-off-by: Jiri Slaby <jslaby@suse.cz>' > > total: 0 errors, 1 warnings, 0 checks, 14 lines checked Now, this is interesting. The patch email has no mention of jirislaby@kernel.org. However, .mailmap in kernel source root has line: Jiri Slaby <jirislaby@kernel.org> <jslaby@suse.cz> indicating that you prefer jirislaby@kernel.org. When I apply the patch, git am looks that up, and sets: Author: Jiri Slaby <jirislaby@kernel.org> With that, we end up with an Author/Signed-off-by mismatch. If you prefer Jiri Slaby <jirislaby@kernel.org>, I think you should have that in git config too. BR, Jani.
On Fri, 17 Dec 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Thu, 16 Dec 2021, Patchwork <patchwork@emeril.freedesktop.org> wrote: >> == Series Details == >> >> Series: drm/i915: remove circ_buf.h includes >> URL : https://patchwork.freedesktop.org/series/98130/ >> State : warning >> >> == Summary == >> >> $ dim checkpatch origin/drm-tip >> 24a5cb6b532c drm/i915: remove circ_buf.h includes >> -:44: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jiri Slaby <jirislaby@kernel.org>' != 'Signed-off-by: Jiri Slaby <jslaby@suse.cz>' >> >> total: 0 errors, 1 warnings, 0 checks, 14 lines checked > > Now, this is interesting. The patch email has no mention of > jirislaby@kernel.org. > > However, .mailmap in kernel source root has line: > > Jiri Slaby <jirislaby@kernel.org> <jslaby@suse.cz> > > indicating that you prefer jirislaby@kernel.org. When I apply the patch, > git am looks that up, and sets: > > Author: Jiri Slaby <jirislaby@kernel.org> > > With that, we end up with an Author/Signed-off-by mismatch. > > If you prefer Jiri Slaby <jirislaby@kernel.org>, I think you should have > that in git config too. Ping.
diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c b/drivers/gpu/drm/i915/display/intel_pipe_crc.c index 8ac263f471be..9070935b0443 100644 --- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c +++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c @@ -24,7 +24,6 @@ * */ -#include <linux/circ_buf.h> #include <linux/ctype.h> #include <linux/debugfs.h> #include <linux/seq_file.h> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 5b98fb0532b5..e77f644d41e8 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -28,7 +28,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -#include <linux/circ_buf.h> #include <linux/slab.h> #include <linux/sysrq.h>
The last user of macros from that include was removed in 2018 by the commit below. Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc interface") Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 1 - drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 2 deletions(-)