diff mbox series

[v3,i-g-t,12/15] tests/i915/gem_exec_fence: Configure correct context

Message ID 20220113195947.1536897-13-John.C.Harrison@Intel.com (mailing list archive)
State New, archived
Headers show
Series Fixes for i915_hangman and gem_exec_capture | expand

Commit Message

John Harrison Jan. 13, 2022, 7:59 p.m. UTC 
From: John Harrison <John.C.Harrison@Intel.com>

The update to use intel_ctx_t missed a line that configures the
context to allow hanging. Fix that.

Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 tests/i915/gem_exec_fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthew Brost Jan. 13, 2022, 9:06 p.m. UTC | #1 
On Thu, Jan 13, 2022 at 11:59:44AM -0800, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> The update to use intel_ctx_t missed a line that configures the
> context to allow hanging. Fix that.
> 
> Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f

Typically I thought the Fixes comment was the sha from "git log
--oneline" + first line of commit message from that surrounded by ("").

So:
Fixes: <small sha> ("<message>")

With that fixed:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> ---
>  tests/i915/gem_exec_fence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
> index 196236b27..5e45d0518 100644
> --- a/tests/i915/gem_exec_fence.c
> +++ b/tests/i915/gem_exec_fence.c
> @@ -3139,7 +3139,7 @@ igt_main
>  			igt_hang_t hang;
>  
>  			igt_fixture {
> -				hang = igt_allow_hang(i915, 0, 0);
> +				hang = igt_allow_hang(i915, ctx->id, 0);
>  				intel_allocator_multiprocess_start();
>  			}
>  
> -- 
> 2.25.1
>
John Harrison Jan. 13, 2022, 9:23 p.m. UTC | #2 
On 1/13/2022 13:06, Matthew Brost wrote:
> On Thu, Jan 13, 2022 at 11:59:44AM -0800, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The update to use intel_ctx_t missed a line that configures the
>> context to allow hanging. Fix that.
>>
>> Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f
> Typically I thought the Fixes comment was the sha from "git log
> --oneline" + first line of commit message from that surrounded by ("").
>
> So:
> Fixes: <small sha> ("<message>")
Oops, yeah. Not sure what happened here. Brain fart most likely ;).

John.

>
> With that fixed:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> ---
>>   tests/i915/gem_exec_fence.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
>> index 196236b27..5e45d0518 100644
>> --- a/tests/i915/gem_exec_fence.c
>> +++ b/tests/i915/gem_exec_fence.c
>> @@ -3139,7 +3139,7 @@ igt_main
>>   			igt_hang_t hang;
>>   
>>   			igt_fixture {
>> -				hang = igt_allow_hang(i915, 0, 0);
>> +				hang = igt_allow_hang(i915, ctx->id, 0);
>>   				intel_allocator_multiprocess_start();
>>   			}
>>   
>> -- 
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 196236b27..5e45d0518 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_fence.c
@@ -3139,7 +3139,7 @@  igt_main
 			igt_hang_t hang;
 
 			igt_fixture {
-				hang = igt_allow_hang(i915, 0, 0);
+				hang = igt_allow_hang(i915, ctx->id, 0);
 				intel_allocator_multiprocess_start();
 			}