| Message ID | 20220126203702.1784589-10-lucas.demarchi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/guc: Refactor ADS access to use dma_buf_map | expand |
Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > Just like memcpy_toio(), there is also need to write a direct value to a > memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() > > Cc: Matt Roper <matthew.d.roper@intel.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Christian König <christian.koenig@amd.com> > Cc: linux-media@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > include/linux/dma-buf-map.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h > index 3514a859f628..c9fb04264cd0 100644 > --- a/include/linux/dma-buf-map.h > +++ b/include/linux/dma-buf-map.h > @@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct dma_buf_map *dst, const void *sr > memcpy(dst->vaddr, src, len); > } > > +/** > + * dma_buf_map_memset - Memset into dma-buf mapping > + * @dst: The dma-buf mapping structure > + * @value: The value to set > + * @len: The number of bytes to set in dst > + * > + * Set value in dma-buf mapping. Depending on the buffer's location, the helper > + * picks the correct method of accessing the memory. > + */ > +static inline void dma_buf_map_memset(struct dma_buf_map *dst, int value, size_t len) > +{ > + if (dst->is_iomem) > + memset_io(dst->vaddr_iomem, value, len); > + else > + memset(dst->vaddr, value, len); > +} > + Yeah, that's certainly a valid use case. But maybe directly add a dma_buf_map_memset_with_offset() variant as well when that helps to avoid patch #2. Regards, Christian. > /** > * dma_buf_map_incr - Increments the address stored in a dma-buf mapping > * @map: The dma-buf mapping structure
Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > Just like memcpy_toio(), there is also need to write a direct value to a > memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() > > Cc: Matt Roper <matthew.d.roper@intel.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Christian König <christian.koenig@amd.com> > Cc: linux-media@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > include/linux/dma-buf-map.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h > index 3514a859f628..c9fb04264cd0 100644 > --- a/include/linux/dma-buf-map.h > +++ b/include/linux/dma-buf-map.h > @@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct dma_buf_map *dst, const void *sr > memcpy(dst->vaddr, src, len); > } > > +/** > + * dma_buf_map_memset - Memset into dma-buf mapping > + * @dst: The dma-buf mapping structure > + * @value: The value to set > + * @len: The number of bytes to set in dst > + * > + * Set value in dma-buf mapping. Depending on the buffer's location, the helper > + * picks the correct method of accessing the memory. > + */ > +static inline void dma_buf_map_memset(struct dma_buf_map *dst, int value, size_t len) > +{ > + if (dst->is_iomem) > + memset_io(dst->vaddr_iomem, value, len); > + else > + memset(dst->vaddr, value, len); > +} Maybe add an offset parameter here. Best regards Thomas > + > /** > * dma_buf_map_incr - Increments the address stored in a dma-buf mapping > * @map: The dma-buf mapping structure
On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: >Hi > >Am 26.01.22 um 21:36 schrieb Lucas De Marchi: >>Just like memcpy_toio(), there is also need to write a direct value to a >>memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() >> >>Cc: Matt Roper <matthew.d.roper@intel.com> >>Cc: Sumit Semwal <sumit.semwal@linaro.org> >>Cc: Christian König <christian.koenig@amd.com> >>Cc: linux-media@vger.kernel.org >>Cc: dri-devel@lists.freedesktop.org >>Cc: linaro-mm-sig@lists.linaro.org >>Cc: linux-kernel@vger.kernel.org >>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >>--- >> include/linux/dma-buf-map.h | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >>diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h >>index 3514a859f628..c9fb04264cd0 100644 >>--- a/include/linux/dma-buf-map.h >>+++ b/include/linux/dma-buf-map.h >>@@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct dma_buf_map *dst, const void *sr >> memcpy(dst->vaddr, src, len); >> } >>+/** >>+ * dma_buf_map_memset - Memset into dma-buf mapping >>+ * @dst: The dma-buf mapping structure >>+ * @value: The value to set >>+ * @len: The number of bytes to set in dst >>+ * >>+ * Set value in dma-buf mapping. Depending on the buffer's location, the helper >>+ * picks the correct method of accessing the memory. >>+ */ >>+static inline void dma_buf_map_memset(struct dma_buf_map *dst, int value, size_t len) >>+{ >>+ if (dst->is_iomem) >>+ memset_io(dst->vaddr_iomem, value, len); >>+ else >>+ memset(dst->vaddr, value, len); >>+} > >Maybe add an offset parameter here. yep, on v2 I will have 2 APIs, one with and one without offset. thanks Lucas De Marchi > >Best regards >Thomas > >>+ >> /** >> * dma_buf_map_incr - Increments the address stored in a dma-buf mapping >> * @map: The dma-buf mapping structure > >-- >Thomas Zimmermann >Graphics Driver Developer >SUSE Software Solutions Germany GmbH >Maxfeldstr. 5, 90409 Nürnberg, Germany >(HRB 36809, AG Nürnberg) >Geschäftsführer: Ivo Totev
Am 27.01.22 um 16:38 schrieb Lucas De Marchi: > On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: >> Hi >> >> Am 26.01.22 um 21:36 schrieb Lucas De Marchi: >>> Just like memcpy_toio(), there is also need to write a direct value to a >>> memory block. Add dma_buf_map_memset() to abstract memset() vs >>> memset_io() >>> >>> Cc: Matt Roper <matthew.d.roper@intel.com> >>> Cc: Sumit Semwal <sumit.semwal@linaro.org> >>> Cc: Christian König <christian.koenig@amd.com> >>> Cc: linux-media@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linaro-mm-sig@lists.linaro.org >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >>> --- >>> include/linux/dma-buf-map.h | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h >>> index 3514a859f628..c9fb04264cd0 100644 >>> --- a/include/linux/dma-buf-map.h >>> +++ b/include/linux/dma-buf-map.h >>> @@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct >>> dma_buf_map *dst, const void *sr >>> memcpy(dst->vaddr, src, len); >>> } >>> +/** >>> + * dma_buf_map_memset - Memset into dma-buf mapping >>> + * @dst: The dma-buf mapping structure >>> + * @value: The value to set >>> + * @len: The number of bytes to set in dst >>> + * >>> + * Set value in dma-buf mapping. Depending on the buffer's location, >>> the helper >>> + * picks the correct method of accessing the memory. >>> + */ >>> +static inline void dma_buf_map_memset(struct dma_buf_map *dst, int >>> value, size_t len) >>> +{ >>> + if (dst->is_iomem) >>> + memset_io(dst->vaddr_iomem, value, len); >>> + else >>> + memset(dst->vaddr, value, len); >>> +} >> >> Maybe add an offset parameter here. > > yep, on v2 I will have 2 APIs, one with and one without offset. Please, no. Just add the parameter here and pass 0 if yo don't need it. Best regards Thomas > > thanks > Lucas De Marchi > >> >> Best regards >> Thomas >> >>> + >>> /** >>> * dma_buf_map_incr - Increments the address stored in a dma-buf >>> mapping >>> * @map: The dma-buf mapping structure >> >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Maxfeldstr. 5, 90409 Nürnberg, Germany >> (HRB 36809, AG Nürnberg) >> Geschäftsführer: Ivo Totev > > >
diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h index 3514a859f628..c9fb04264cd0 100644 --- a/include/linux/dma-buf-map.h +++ b/include/linux/dma-buf-map.h @@ -317,6 +317,23 @@ static inline void dma_buf_map_memcpy_to(struct dma_buf_map *dst, const void *sr memcpy(dst->vaddr, src, len); } +/** + * dma_buf_map_memset - Memset into dma-buf mapping + * @dst: The dma-buf mapping structure + * @value: The value to set + * @len: The number of bytes to set in dst + * + * Set value in dma-buf mapping. Depending on the buffer's location, the helper + * picks the correct method of accessing the memory. + */ +static inline void dma_buf_map_memset(struct dma_buf_map *dst, int value, size_t len) +{ + if (dst->is_iomem) + memset_io(dst->vaddr_iomem, value, len); + else + memset(dst->vaddr, value, len); +} + /** * dma_buf_map_incr - Increments the address stored in a dma-buf mapping * @map: The dma-buf mapping structure
Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper <matthew.d.roper@intel.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Christian König <christian.koenig@amd.com> Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-sig@lists.linaro.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- include/linux/dma-buf-map.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)