| Message ID | 20220328171650.1900674-1-fei.yang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: avoid concurrent writes to aux_inv | expand |
On 28/03/2022 18:16, fei.yang@intel.com wrote: > From: Fei Yang <fei.yang@intel.com> > > GPU hangs have been observed when multiple engines write to the > same aux_inv register at the same time. To avoid this each engine > should only invalidate its own auxiliary table. The function > gen12_emit_flush_xcs() currently invalidate the auxiliary table for > all engines because the rq->engine is not necessarily the engine > eventually carrying out the request, and potentially the engine > could even be a virtual one (with engine->instance being -1). > With the MMIO remap feature, we can actually set bit 17 of MI_LRI > instruction and let the hardware to figure out the local aux_inv > register at runtime to avoid invalidating auxiliary table for all > engines. > > Bspec: 45728 > > v2: Invalidate AUX table for indirect context as well. > > Cc: Stuart Summers <stuart.summers@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Chris Wilson <chris.p.wilson@intel.com> > Signed-off-by: Fei Yang <fei.yang@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 50 +++++--------------- > drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 4 +- > drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 + > drivers/gpu/drm/i915/gt/intel_lrc.c | 12 +++++ > 4 files changed, 27 insertions(+), 40 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > index 36148887c699..047b5a710149 100644 > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > @@ -6,7 +6,6 @@ > #include "gen8_engine_cs.h" > #include "i915_drv.h" > #include "intel_gpu_commands.h" > -#include "intel_gt_regs.h" > #include "intel_lrc.h" > #include "intel_ring.h" > > @@ -165,33 +164,9 @@ static u32 preparser_disable(bool state) > return MI_ARB_CHECK | 1 << 8 | state; > } > > -static i915_reg_t aux_inv_reg(const struct intel_engine_cs *engine) > +u32 *gen12_emit_aux_table_inv(u32 *cs, const i915_reg_t inv_reg) > { > - static const i915_reg_t vd[] = { > - GEN12_VD0_AUX_NV, > - GEN12_VD1_AUX_NV, > - GEN12_VD2_AUX_NV, > - GEN12_VD3_AUX_NV, > - }; > - > - static const i915_reg_t ve[] = { > - GEN12_VE0_AUX_NV, > - GEN12_VE1_AUX_NV, > - }; > - > - if (engine->class == VIDEO_DECODE_CLASS) > - return vd[engine->instance]; > - > - if (engine->class == VIDEO_ENHANCEMENT_CLASS) > - return ve[engine->instance]; > - > - GEM_BUG_ON("unknown aux_inv reg\n"); > - return INVALID_MMIO_REG; > -} > - > -static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs) > -{ > - *cs++ = MI_LOAD_REGISTER_IMM(1); > + *cs++ = MI_LOAD_REGISTER_IMM(1) | MI_LRI_MMIO_REMAP_EN; > *cs++ = i915_mmio_reg_offset(inv_reg); > *cs++ = AUX_INV; > *cs++ = MI_NOOP; > @@ -274,7 +249,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) > > if (!HAS_FLAT_CCS(rq->engine->i915)) { > /* hsdes: 1809175790 */ > - cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs); > + cs = gen12_emit_aux_table_inv(cs, GEN12_GFX_CCS_AUX_NV); > } > > *cs++ = preparser_disable(false); > @@ -293,10 +268,12 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) > if (mode & EMIT_INVALIDATE) { > cmd += 2; > > - if (!HAS_FLAT_CCS(rq->engine->i915)) { > + if (!HAS_FLAT_CCS(rq->engine->i915) && > + (rq->engine->class == VIDEO_DECODE_CLASS || > + rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) { > aux_inv = rq->engine->mask & ~BIT(BCS0); > if (aux_inv) > - cmd += 2 * hweight32(aux_inv) + 2; > + cmd += 4; > } > } > > @@ -329,15 +306,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) > *cs++ = 0; /* value */ > > if (aux_inv) { /* hsdes: 1809175790 */ > - struct intel_engine_cs *engine; > - unsigned int tmp; > - > - *cs++ = MI_LOAD_REGISTER_IMM(hweight32(aux_inv)); > - for_each_engine_masked(engine, rq->engine->gt, aux_inv, tmp) { > - *cs++ = i915_mmio_reg_offset(aux_inv_reg(engine)); > - *cs++ = AUX_INV; > - } > - *cs++ = MI_NOOP; > + if (rq->engine->class == VIDEO_DECODE_CLASS) > + cs = gen12_emit_aux_table_inv(cs, GEN12_VD0_AUX_NV); > + else > + cs = gen12_emit_aux_table_inv(cs, GEN12_VE0_AUX_NV); > } > > if (mode & EMIT_INVALIDATE) > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.h b/drivers/gpu/drm/i915/gt/gen8_engine_cs.h > index cc6e21d3662a..107ab42539ab 100644 > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.h > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.h > @@ -10,7 +10,7 @@ > #include <linux/types.h> > > #include "i915_gem.h" /* GEM_BUG_ON */ > - > +#include "intel_gt_regs.h" > #include "intel_gpu_commands.h" > > struct i915_request; > @@ -38,6 +38,8 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); > u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); > u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); > > +u32 *gen12_emit_aux_table_inv(u32 *cs, const i915_reg_t inv_reg); > + > static inline u32 * > __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset) > { > diff --git a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h > index d112ffd56418..4243be030bc1 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h > +++ b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h > @@ -144,6 +144,7 @@ > #define MI_LOAD_REGISTER_IMM(x) MI_INSTR(0x22, 2*(x)-1) > /* Gen11+. addr = base + (ctx_restore ? offset & GENMASK(12,2) : offset) */ > #define MI_LRI_LRM_CS_MMIO REG_BIT(19) > +#define MI_LRI_MMIO_REMAP_EN REG_BIT(17) > #define MI_LRI_FORCE_POSTED (1<<12) > #define MI_LOAD_REGISTER_IMM_MAX_REGS (126) > #define MI_STORE_REGISTER_MEM MI_INSTR(0x24, 1) > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 07bef7128fdb..dffef6ab4baf 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1208,6 +1208,10 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs) > IS_DG2_G11(ce->engine->i915)) > cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0); > > + /* hsdes: 1809175790 */ > + if (!HAS_FLAT_CCS(ce->engine->i915)) > + cs = gen12_emit_aux_table_inv(cs, GEN12_GFX_CCS_AUX_NV); > + > return cs; > } > > @@ -1225,6 +1229,14 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs) > PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, > 0); > > + /* hsdes: 1809175790 */ > + if (!HAS_FLAT_CCS(ce->engine->i915)) { > + if (ce->engine->class == VIDEO_DECODE_CLASS) > + cs = gen12_emit_aux_table_inv(cs, GEN12_VD0_AUX_NV); > + else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS) > + cs = gen12_emit_aux_table_inv(cs, GEN12_VE0_AUX_NV); > + } > + > return cs; > } >
On 29/03/2022 03:30, Patchwork wrote: > *Patch Details* > *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) > *URL:* https://patchwork.freedesktop.org/series/100772/ > <https://patchwork.freedesktop.org/series/100772/> > *State:* success > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html> > > > CI Bug Log - changes from CI_DRM_11415_full -> Patchwork_22704_full > > > Summary > > *SUCCESS* > > No regressions found. And pushed. Does this have any chance of fixing hangs in multiple simultaneous media workloads? Regards, Tvrtko > > > Participating hosts (10 -> 10) > > No changes in participating hosts > > > Known issues > > Here are the changes found in Patchwork_22704_full that come from known > issues: > > > IGT changes > > > Issues hit > > * > > igt@gem_ctx_isolation@preservation-s3@bcs0: > > o shard-kbl: NOTRUN -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html> > ([i915#180]) +1 similar issue > * > > igt@gem_ctx_persistence@legacy-engines-mixed: > > o shard-snb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb4/igt@gem_ctx_persistence@legacy-engines-mixed.html> > ([fdo#109271] / [i915#1099]) > * > > igt@gem_exec_fair@basic-none-rrul@rcs0: > > o > > shard-iclb: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html> > ([i915#2852]) > > o > > shard-glk: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@gem_exec_fair@basic-none-rrul@rcs0.html> > ([i915#2842]) +2 similar issues > > o > > shard-tglb: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html> > ([i915#2842]) > > * > > igt@gem_exec_fair@basic-pace-share@rcs0: > > o shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html> > ([i915#2842]) > * > > igt@gem_exec_fair@basic-throttle@rcs0: > > o shard-iclb: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html> > ([i915#2849]) > * > > igt@gem_exec_params@rsvd2-dirt: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb3/igt@gem_exec_params@rsvd2-dirt.html> > ([fdo#109283]) > * > > igt@gem_exec_schedule@u-semaphore-user: > > o shard-snb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb4/igt@gem_exec_schedule@u-semaphore-user.html> > ([fdo#109271]) +55 similar issues > * > > igt@gem_huc_copy@huc-copy: > > o > > shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl1/igt@gem_huc_copy@huc-copy.html> > ([fdo#109271] / [i915#2190]) > > o > > shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk9/igt@gem_huc_copy@huc-copy.html> > ([fdo#109271] / [i915#2190]) > > * > > igt@gem_lmem_swapping@basic: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl2/igt@gem_lmem_swapping@basic.html> > ([fdo#109271] / [i915#4613]) +1 similar issue > * > > igt@gem_lmem_swapping@heavy-verify-random: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@gem_lmem_swapping@heavy-verify-random.html> > ([fdo#109271] / [i915#4613]) > * > > igt@gem_lmem_swapping@parallel-random-engines: > > o shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk7/igt@gem_lmem_swapping@parallel-random-engines.html> > ([fdo#109271] / [i915#4613]) > * > > igt@gem_lmem_swapping@smem-oom: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@gem_lmem_swapping@smem-oom.html> > ([fdo#109271] / [i915#4613]) > * > > igt@gem_pipe_control_store_loop@reused-buffer: > > o shard-snb: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb7/igt@gem_pipe_control_store_loop@reused-buffer.html> > ([i915#5441]) > * > > igt@gem_ppgtt@blt-vs-render-ctx0: > > o shard-snb: NOTRUN -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctx0.html> > ([i915#5441]) > * > > igt@gem_ppgtt@blt-vs-render-ctxn: > > o shard-iclb: NOTRUN -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb4/igt@gem_ppgtt@blt-vs-render-ctxn.html> > ([i915#5441]) > * > > igt@gem_pread@exhaustion: > > o > > shard-tglb: NOTRUN -> WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb2/igt@gem_pread@exhaustion.html> > ([i915#2658]) > > o > > shard-iclb: NOTRUN -> WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb3/igt@gem_pread@exhaustion.html> > ([i915#2658]) > > o > > shard-skl: NOTRUN -> WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl9/igt@gem_pread@exhaustion.html> > ([i915#2658]) > > * > > igt@gem_pxp@verify-pxp-stale-buf-execution: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@gem_pxp@verify-pxp-stale-buf-execution.html> > ([i915#4270]) +1 similar issue > * > > igt@gem_render_copy@x-tiled@smem: > > o shard-skl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-skl7/igt@gem_render_copy@x-tiled@smem.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl6/igt@gem_render_copy@x-tiled@smem.html> > ([i915#5441]) > * > > igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled.html> > ([i915#768]) > * > > igt@gem_softpin@noreloc-s3: > > o shard-kbl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-kbl3/igt@gem_softpin@noreloc-s3.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl1/igt@gem_softpin@noreloc-s3.html> > ([i915#180]) > * > > igt@gem_tiled_blits@basic: > > o shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-tglb1/igt@gem_tiled_blits@basic.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb1/igt@gem_tiled_blits@basic.html> > ([i915#5441]) +8 similar issues > * > > igt@gem_tiled_partial_pwrite_pread@reads: > > o shard-apl: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@gem_tiled_partial_pwrite_pread@reads.html> > ([i915#5441]) +1 similar issue > * > > igt@gem_tiled_partial_pwrite_pread@writes: > > o shard-tglb: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@gem_tiled_partial_pwrite_pread@writes.html> > ([i915#5441]) +4 similar issues > * > > igt@gem_userptr_blits@dmabuf-sync: > > o > > shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@gem_userptr_blits@dmabuf-sync.html> > ([i915#3323]) > > o > > shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@gem_userptr_blits@dmabuf-sync.html> > ([fdo#109271] / [i915#3323]) > > o > > shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@gem_userptr_blits@dmabuf-sync.html> > ([fdo#109271] / [i915#3323]) > > * > > igt@gem_userptr_blits@invalid-mmap-offset-unsync: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@gem_userptr_blits@invalid-mmap-offset-unsync.html> > ([i915#3297]) +1 similar issue > * > > igt@gem_userptr_blits@unsync-overlap: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb2/igt@gem_userptr_blits@unsync-overlap.html> > ([i915#3297]) +1 similar issue > * > > igt@gem_userptr_blits@vma-merge: > > o > > shard-iclb: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@gem_userptr_blits@vma-merge.html> > ([i915#3318]) > > o > > shard-kbl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl6/igt@gem_userptr_blits@vma-merge.html> > ([i915#3318]) > > * > > igt@gen3_render_linear_blits: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@gen3_render_linear_blits.html> > ([fdo#109289]) +1 similar issue > * > > igt@gen9_exec_parse@allowed-all: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@gen9_exec_parse@allowed-all.html> > ([i915#2856]) +1 similar issue > * > > igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html> > ([fdo#109271] / [i915#1937]) > * > > igt@i915_pm_rpm@gem-execbuf-stress-pc8: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html> > ([fdo#109293] / [fdo#109506]) > * > > igt@i915_query@query-topology-unsupported: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@i915_query@query-topology-unsupported.html> > ([fdo#109302]) > * > > igt@i915_suspend@fence-restore-untiled: > > o shard-skl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-skl9/igt@i915_suspend@fence-restore-untiled.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl10/igt@i915_suspend@fence-restore-untiled.html> > ([i915#4817]) > * > > igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip: > > o > > shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip.html> > ([i915#5286]) +1 similar issue > > o > > shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip.html> > ([i915#5286]) > > * > > igt@kms_big_fb@linear-32bpp-rotate-180: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-iclb2/igt@kms_big_fb@linear-32bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_big_fb@linear-32bpp-rotate-180.html> > ([i915#5441]) +1 similar issue > * > > igt@kms_big_fb@linear-32bpp-rotate-90: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_big_fb@linear-32bpp-rotate-90.html> > ([fdo#110725] / [fdo#111614]) +1 similar issue > * > > igt@kms_big_fb@linear-8bpp-rotate-180: > > o shard-kbl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-kbl6/igt@kms_big_fb@linear-8bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl7/igt@kms_big_fb@linear-8bpp-rotate-180.html> > ([i915#5441]) +2 similar issues > * > > igt@kms_big_fb@x-tiled-16bpp-rotate-0: > > o > > shard-iclb: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb3/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html> > ([i915#5441]) +2 similar issues > > o > > shard-skl: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl9/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html> > ([i915#5441]) +3 similar issues > > * > > igt@kms_big_fb@x-tiled-16bpp-rotate-180: > > o > > shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-glk6/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk7/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > ([i915#5441]) > > o > > shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-apl1/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl8/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > ([i915#1373] / [i915#5441]) > > o > > shard-kbl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-kbl7/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl7/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html> > ([i915#1373] / [i915#5441]) > > * > > igt@kms_big_fb@x-tiled-64bpp-rotate-180: > > o > > shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-tglb3/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb5/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html> > ([i915#2828] / [i915#5441]) > > o > > shard-snb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-snb7/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb4/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html> > ([i915#5441]) > > * > > igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html> > ([fdo#109271] / [i915#3777]) > * > > igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-iclb5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html> > ([i915#1982] / [i915#5441]) > * > > igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html> > ([fdo#109271] / [i915#3777]) +1 similar issue > * > > igt@kms_big_fb@y-tiled-32bpp-rotate-180: > > o shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-apl1/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl7/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html> > ([i915#5441]) +1 similar issue > * > > igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip: > > o shard-kbl: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html> > ([i915#5441]) +2 similar issues > * > > igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip: > > o > > shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html> > ([fdo#109271] / [i915#3777]) +2 similar issues > > o > > shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html> > ([fdo#109271] / [i915#3777]) +1 similar issue > > * > > igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html> > ([fdo#111615]) > * > > igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html> > ([fdo#110723]) > * > > igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs.html> > ([fdo#111615] / [i915#3689]) > * > > igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl2/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html> > ([fdo#109271] / [i915#3886]) +4 similar issues > * > > igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html> > ([fdo#109271] / [i915#3886]) +2 similar issues > * > > igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs: > > o > > shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html> > ([fdo#109278] / [i915#3886]) +6 similar issues > > o > > shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html> > ([i915#3689] / [i915#3886]) +1 similar issue > > * > > igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: > > o shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html> > ([fdo#109271] / [i915#3886]) +1 similar issue > * > > igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html> > ([fdo#109271] / [i915#3886]) +1 similar issue > * > > igt@kms_chamelium@dp-hpd-after-suspend: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb3/igt@kms_chamelium@dp-hpd-after-suspend.html> > ([fdo#109284] / [fdo#111827]) +1 similar issue > * > > igt@kms_chamelium@dp-mode-timings: > > o > > shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@kms_chamelium@dp-mode-timings.html> > ([fdo#109271] / [fdo#111827]) +4 similar issues > > o > > shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@kms_chamelium@dp-mode-timings.html> > ([fdo#109271] / [fdo#111827]) +5 similar issues > > o > > shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@kms_chamelium@dp-mode-timings.html> > ([fdo#109284] / [fdo#111827]) +3 similar issues > > * > > igt@kms_chamelium@hdmi-mode-timings: > > o shard-snb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-snb4/igt@kms_chamelium@hdmi-mode-timings.html> > ([fdo#109271] / [fdo#111827]) +3 similar issues > * > > igt@kms_color@pipe-d-ctm-max: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl7/igt@kms_color@pipe-d-ctm-max.html> > ([fdo#109271]) +87 similar issues > * > > igt@kms_color@pipe-d-ctm-negative: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_color@pipe-d-ctm-negative.html> > ([fdo#109278] / [i915#1149]) > * > > igt@kms_color_chamelium@pipe-a-ctm-negative: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-negative.html> > ([fdo#109271] / [fdo#111827]) +1 similar issue > * > > igt@kms_color_chamelium@pipe-d-degamma: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl10/igt@kms_color_chamelium@pipe-d-degamma.html> > ([fdo#109271] / [fdo#111827]) +3 similar issues > * > > igt@kms_content_protection@atomic: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@kms_content_protection@atomic.html> > ([fdo#109300] / [fdo#111066]) > * > > igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen.html> > ([i915#3319]) > * > > igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html> > ([fdo#109278] / [fdo#109279]) +3 similar issues > * > > igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen.html> > ([fdo#109278]) +26 similar issues > * > > igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding.html> > ([fdo#109279] / [i915#3359]) +1 similar issue > * > > igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen: > > o shard-kbl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html> > ([fdo#109271]) +81 similar issues > * > > igt@kms_cursor_crc@pipe-d-cursor-32x10-random: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-32x10-random.html> > ([i915#3359]) > * > > igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html> > ([fdo#109274] / [fdo#109278]) +2 similar issues > * > > igt@kms_cursor_legacy@pipe-d-single-bo: > > o shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk4/igt@kms_cursor_legacy@pipe-d-single-bo.html> > ([fdo#109271] / [i915#533]) > * > > igt@kms_cursor_legacy@pipe-d-torture-bo: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html> > ([fdo#109271] / [i915#533]) > * > > igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled: > > o > > shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled.html> > ([i915#5287]) +1 similar issue > > o > > shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled.html> > ([i915#5287]) > > * > > igt@kms_flip@2x-flip-vs-blocking-wf-vblank: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb2/igt@kms_flip@2x-flip-vs-blocking-wf-vblank.html> > ([fdo#109274] / [fdo#111825]) +5 similar issues > * > > igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2: > > o shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html> > ([i915#79]) > * > > igt@kms_flip@2x-flip-vs-rmfb-interruptible: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html> > ([fdo#109274]) +6 similar issues > * > > igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1: > > o shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html> > ([i915#79]) > * > > igt@kms_flip@flip-vs-suspend@c-dp1: > > o shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html> > ([i915#180]) +2 similar issues > * > > igt@kms_flip@plain-flip-fb-recreate@b-edp1: > > o shard-skl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl10/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html> > ([i915#2122]) > * > > igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling.html> > ([i915#2587]) > * > > igt@kms_force_connector_basic@force-load-detect: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb5/igt@kms_force_connector_basic@force-load-detect.html> > ([fdo#109285]) > * > > igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html> > ([fdo#109280]) +19 similar issues > * > > igt@kms_frontbuffer_tracking@fbc-suspend: > > o shard-kbl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html> > ([i915#180] / [i915#1982]) > * > > igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt: > > o shard-tglb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html> > ([fdo#109280] / [fdo#111825]) +8 similar issues > * > > igt@kms_frontbuffer_tracking@fbcpsr-tiling-4: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html> > ([i915#5438]) > * > > igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render: > > o shard-glk: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-glk6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html> > ([fdo#109271]) +58 similar issues > * > > igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-apl4/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html> > ([fdo#109271] / [i915#533]) +1 similar issue > * > > igt@kms_plane_alpha_blend@pipe-b-alpha-7efc: > > o shard-kbl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html> > ([fdo#108145] / [i915#265]) > * > > igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: > > o shard-kbl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html> > ([i915#265]) +1 similar issue > * > > igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: > > o shard-skl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html> > ([fdo#108145] / [i915#265]) +2 similar issues > * > > igt@kms_plane_lowres@pipe-c-tiling-y: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb7/igt@kms_plane_lowres@pipe-c-tiling-y.html> > ([i915#3536]) > * > > igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11415/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html> > ([i915#5293]) > * > > igt@kms_psr2_sf@plane-move-sf-dmg-area: > > o shard-iclb: NOTRUN -> [SKIP][129] ( >
> On 29/03/2022 03:30, Patchwork wrote: >> *Patch Details* >> *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) >> *URL:* https://patchwork.freedesktop.org/series/100772/ >> <https://patchwork.freedesktop.org/series/100772/> >> *State:* success >> *Details:* >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html> >> >> >> CI Bug Log - changes from CI_DRM_11415_full -> Patchwork_22704_full >> >> >> Summary >> >> *SUCCESS* >> >> No regressions found. > > And pushed. Thank you so much. > > Does this have any chance of fixing hangs in multiple simultaneous media workloads? I hope so. The hang fixed by this patch is pretty easy to reproduce on TGL with two parallel video decoding processes. -Fei > Regards, > > Tvrtko
On 29/03/2022 16:59, Yang, Fei wrote: >> On 29/03/2022 03:30, Patchwork wrote: >>> *Patch Details* >>> *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) >>> *URL:* https://patchwork.freedesktop.org/series/100772/ >>> <https://patchwork.freedesktop.org/series/100772/> >>> *State:* success >>> *Details:* >>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >>> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html> >>> >>> >>> CI Bug Log - changes from CI_DRM_11415_full -> Patchwork_22704_full >>> >>> >>> Summary >>> >>> *SUCCESS* >>> >>> No regressions found. >> >> And pushed. > Thank you so much. > >> >> Does this have any chance of fixing hangs in multiple simultaneous media workloads? > I hope so. The hang fixed by this patch is pretty easy to reproduce on TGL with two parallel video decoding processes. Great! Do you want to send it to stable in this case? Would need to look how far back it would be easy to backport. Regards, Tvrtko
>>>> *Patch Details* >>>> *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) >>>> *URL:* https://patchwork.freedesktop.org/series/100772/ >>>> <https://patchwork.freedesktop.org/series/100772/> >>>> *State:* success >>>> *Details:* >>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >>>> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >>>> > >>>> >>>> >>>> CI Bug Log - changes from CI_DRM_11415_full -> >>>> Patchwork_22704_full >>>> >>>> >>>> Summary >>>> >>>> *SUCCESS* >>>> >>>> No regressions found. >>> >>> And pushed. >> Thank you so much. >> >>> >>> Does this have any chance of fixing hangs in multiple simultaneous media workloads? >> I hope so. The hang fixed by this patch is pretty easy to reproduce on TGL with two parallel video decoding processes. > > Great! > > Do you want to send it to stable in this case? Would need to look how far back it would be easy to backport. How far back? The change is only applicable for GEN12, so I believe this won't go farther than 5.4? > Regards, > > Tvrtko
On 30/03/2022 16:37, Yang, Fei wrote: >>>>> *Patch Details* >>>>> *Series:* drm/i915: avoid concurrent writes to aux_inv (rev10) >>>>> *URL:* https://patchwork.freedesktop.org/series/100772/ >>>>> <https://patchwork.freedesktop.org/series/100772/> >>>>> *State:* success >>>>> *Details:* >>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >>>>> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22704/index.html >>>>>> >>>>> >>>>> >>>>> CI Bug Log - changes from CI_DRM_11415_full -> >>>>> Patchwork_22704_full >>>>> >>>>> >>>>> Summary >>>>> >>>>> *SUCCESS* >>>>> >>>>> No regressions found. >>>> >>>> And pushed. >>> Thank you so much. >>> >>>> >>>> Does this have any chance of fixing hangs in multiple simultaneous media workloads? >>> I hope so. The hang fixed by this patch is pretty easy to reproduce on TGL with two parallel video decoding processes. >> >> Great! >> >> Do you want to send it to stable in this case? Would need to look how far back it would be easy to backport. > > How far back? The change is only applicable for GEN12, so I believe this won't go farther than 5.4? No need to go beyond 5.9 AFAICT since that is when d248b371f747 ("drm/i915/gen12: Invalidate aux table entries forcibly") was added. That would mean 5.10, 5.15, 5.16 and 5.17 are potential candidates. We recently had https://gitlab.freedesktop.org/drm/intel/-/issues/5271 and there is also https://gitlab.freedesktop.org/drm/intel/-/issues/5025 so it is probably worth propagating the fix to distros via stable since people are hitting it. Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c index 36148887c699..047b5a710149 100644 --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c @@ -6,7 +6,6 @@ #include "gen8_engine_cs.h" #include "i915_drv.h" #include "intel_gpu_commands.h" -#include "intel_gt_regs.h" #include "intel_lrc.h" #include "intel_ring.h" @@ -165,33 +164,9 @@ static u32 preparser_disable(bool state) return MI_ARB_CHECK | 1 << 8 | state; } -static i915_reg_t aux_inv_reg(const struct intel_engine_cs *engine) +u32 *gen12_emit_aux_table_inv(u32 *cs, const i915_reg_t inv_reg) { - static const i915_reg_t vd[] = { - GEN12_VD0_AUX_NV, - GEN12_VD1_AUX_NV, - GEN12_VD2_AUX_NV, - GEN12_VD3_AUX_NV, - }; - - static const i915_reg_t ve[] = { - GEN12_VE0_AUX_NV, - GEN12_VE1_AUX_NV, - }; - - if (engine->class == VIDEO_DECODE_CLASS) - return vd[engine->instance]; - - if (engine->class == VIDEO_ENHANCEMENT_CLASS) - return ve[engine->instance]; - - GEM_BUG_ON("unknown aux_inv reg\n"); - return INVALID_MMIO_REG; -} - -static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs) -{ - *cs++ = MI_LOAD_REGISTER_IMM(1); + *cs++ = MI_LOAD_REGISTER_IMM(1) | MI_LRI_MMIO_REMAP_EN; *cs++ = i915_mmio_reg_offset(inv_reg); *cs++ = AUX_INV; *cs++ = MI_NOOP; @@ -274,7 +249,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) if (!HAS_FLAT_CCS(rq->engine->i915)) { /* hsdes: 1809175790 */ - cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs); + cs = gen12_emit_aux_table_inv(cs, GEN12_GFX_CCS_AUX_NV); } *cs++ = preparser_disable(false); @@ -293,10 +268,12 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) if (mode & EMIT_INVALIDATE) { cmd += 2; - if (!HAS_FLAT_CCS(rq->engine->i915)) { + if (!HAS_FLAT_CCS(rq->engine->i915) && + (rq->engine->class == VIDEO_DECODE_CLASS || + rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) { aux_inv = rq->engine->mask & ~BIT(BCS0); if (aux_inv) - cmd += 2 * hweight32(aux_inv) + 2; + cmd += 4; } } @@ -329,15 +306,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) *cs++ = 0; /* value */ if (aux_inv) { /* hsdes: 1809175790 */ - struct intel_engine_cs *engine; - unsigned int tmp; - - *cs++ = MI_LOAD_REGISTER_IMM(hweight32(aux_inv)); - for_each_engine_masked(engine, rq->engine->gt, aux_inv, tmp) { - *cs++ = i915_mmio_reg_offset(aux_inv_reg(engine)); - *cs++ = AUX_INV; - } - *cs++ = MI_NOOP; + if (rq->engine->class == VIDEO_DECODE_CLASS) + cs = gen12_emit_aux_table_inv(cs, GEN12_VD0_AUX_NV); + else + cs = gen12_emit_aux_table_inv(cs, GEN12_VE0_AUX_NV); } if (mode & EMIT_INVALIDATE) diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.h b/drivers/gpu/drm/i915/gt/gen8_engine_cs.h index cc6e21d3662a..107ab42539ab 100644 --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.h +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.h @@ -10,7 +10,7 @@ #include <linux/types.h> #include "i915_gem.h" /* GEM_BUG_ON */ - +#include "intel_gt_regs.h" #include "intel_gpu_commands.h" struct i915_request; @@ -38,6 +38,8 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); +u32 *gen12_emit_aux_table_inv(u32 *cs, const i915_reg_t inv_reg); + static inline u32 * __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset) { diff --git a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h index d112ffd56418..4243be030bc1 100644 --- a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h +++ b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h @@ -144,6 +144,7 @@ #define MI_LOAD_REGISTER_IMM(x) MI_INSTR(0x22, 2*(x)-1) /* Gen11+. addr = base + (ctx_restore ? offset & GENMASK(12,2) : offset) */ #define MI_LRI_LRM_CS_MMIO REG_BIT(19) +#define MI_LRI_MMIO_REMAP_EN REG_BIT(17) #define MI_LRI_FORCE_POSTED (1<<12) #define MI_LOAD_REGISTER_IMM_MAX_REGS (126) #define MI_STORE_REGISTER_MEM MI_INSTR(0x24, 1) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 07bef7128fdb..dffef6ab4baf 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1208,6 +1208,10 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs) IS_DG2_G11(ce->engine->i915)) cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0); + /* hsdes: 1809175790 */ + if (!HAS_FLAT_CCS(ce->engine->i915)) + cs = gen12_emit_aux_table_inv(cs, GEN12_GFX_CCS_AUX_NV); + return cs; } @@ -1225,6 +1229,14 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs) PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0); + /* hsdes: 1809175790 */ + if (!HAS_FLAT_CCS(ce->engine->i915)) { + if (ce->engine->class == VIDEO_DECODE_CLASS) + cs = gen12_emit_aux_table_inv(cs, GEN12_VD0_AUX_NV); + else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS) + cs = gen12_emit_aux_table_inv(cs, GEN12_VE0_AUX_NV); + } + return cs; }