| Message ID | 20220512161638.272601-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/audio: fix audio code enable/disable pipe logging | expand |
On Thu, May 12, 2022 at 07:16:38PM +0300, Jani Nikula wrote: > Need to use pipe_name(pipe) instead of pipe directly. > > Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug logging") > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c > index 1c87bf66b092..f0f0dfce27ce 100644 > --- a/drivers/gpu/drm/i915/display/intel_audio.c > +++ b/drivers/gpu/drm/i915/display/intel_audio.c > @@ -827,7 +827,7 @@ void intel_audio_codec_enable(struct intel_encoder *encoder, > drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n", > connector->base.id, connector->name, > encoder->base.base.id, encoder->base.name, > - pipe, drm_eld_size(connector->eld)); > + pipe_name(pipe), drm_eld_size(connector->eld)); > > /* FIXME precompute the ELD in .compute_config() */ > if (!connector->eld[0]) > @@ -888,7 +888,7 @@ void intel_audio_codec_disable(struct intel_encoder *encoder, > > drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n", > connector->base.id, connector->name, > - encoder->base.base.id, encoder->base.name, pipe); > + encoder->base.base.id, encoder->base.name, pipe_name(pipe)); > > if (dev_priv->audio.funcs) > dev_priv->audio.funcs->audio_codec_disable(encoder, > -- > 2.30.2
On Thu, 12 May 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, May 12, 2022 at 07:16:38PM +0300, Jani Nikula wrote: >> Need to use pipe_name(pipe) instead of pipe directly. >> >> Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug logging") >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Thanks, pushed to din. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c >> index 1c87bf66b092..f0f0dfce27ce 100644 >> --- a/drivers/gpu/drm/i915/display/intel_audio.c >> +++ b/drivers/gpu/drm/i915/display/intel_audio.c >> @@ -827,7 +827,7 @@ void intel_audio_codec_enable(struct intel_encoder *encoder, >> drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n", >> connector->base.id, connector->name, >> encoder->base.base.id, encoder->base.name, >> - pipe, drm_eld_size(connector->eld)); >> + pipe_name(pipe), drm_eld_size(connector->eld)); >> >> /* FIXME precompute the ELD in .compute_config() */ >> if (!connector->eld[0]) >> @@ -888,7 +888,7 @@ void intel_audio_codec_disable(struct intel_encoder *encoder, >> >> drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n", >> connector->base.id, connector->name, >> - encoder->base.base.id, encoder->base.name, pipe); >> + encoder->base.base.id, encoder->base.name, pipe_name(pipe)); >> >> if (dev_priv->audio.funcs) >> dev_priv->audio.funcs->audio_codec_disable(encoder, >> -- >> 2.30.2
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 1c87bf66b092..f0f0dfce27ce 100644 --- a/drivers/gpu/drm/i915/display/intel_audio.c +++ b/drivers/gpu/drm/i915/display/intel_audio.c @@ -827,7 +827,7 @@ void intel_audio_codec_enable(struct intel_encoder *encoder, drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n", connector->base.id, connector->name, encoder->base.base.id, encoder->base.name, - pipe, drm_eld_size(connector->eld)); + pipe_name(pipe), drm_eld_size(connector->eld)); /* FIXME precompute the ELD in .compute_config() */ if (!connector->eld[0]) @@ -888,7 +888,7 @@ void intel_audio_codec_disable(struct intel_encoder *encoder, drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s][ENCODER:%d:%s] Disable audio codec on pipe %c\n", connector->base.id, connector->name, - encoder->base.base.id, encoder->base.name, pipe); + encoder->base.base.id, encoder->base.name, pipe_name(pipe)); if (dev_priv->audio.funcs) dev_priv->audio.funcs->audio_codec_disable(encoder,
Need to use pipe_name(pipe) instead of pipe directly. Fixes: 1f31e35f2e88 ("drm/i915/audio: unify audio codec enable/disable debug logging") Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)