| Message ID | 20220616120106.24353-9-anshuman.gupta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DG2 VRAM_SR Support | expand |
On Thu, 16 Jun 2022, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Store a pointer to respective local memory region in intel_gt so it can be > used when memory local to a GT needs to be allocated. > > Cc: Andi Shyti <andi.shyti@intel.com> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 1 + > drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > index f33290358c51..7a535f670ae1 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -91,6 +91,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt) > GEM_BUG_ON(!HAS_REGION(i915, id)); > GEM_BUG_ON(i915->mm.regions[id]); > i915->mm.regions[id] = mem; > + gt->lmem = mem; > > return 0; > } > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h > index df708802889d..cd7744eaaeaa 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h > @@ -23,6 +23,7 @@ > #include "intel_gt_buffer_pool_types.h" > #include "intel_hwconfig.h" > #include "intel_llc_types.h" > +#include "intel_memory_region.h" Please never add includes in headers when a forward declaration is sufficient. I'm spending a lot of time trying to reduce the include dependencies we have. BR, Jani. > #include "intel_reset_types.h" > #include "intel_rc6_types.h" > #include "intel_rps_types.h" > @@ -202,6 +203,8 @@ struct intel_gt { > */ > phys_addr_t phys_addr; > > + struct intel_memory_region *lmem; > + > struct intel_gt_info { > unsigned int id;
Hi, On Thu, Jun 16, 2022 at 05:31:05PM +0530, Anshuman Gupta wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Store a pointer to respective local memory region in intel_gt so it can be > used when memory local to a GT needs to be allocated. > > Cc: Andi Shyti <andi.shyti@intel.com> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 1 + > drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > index f33290358c51..7a535f670ae1 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -91,6 +91,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt) > GEM_BUG_ON(!HAS_REGION(i915, id)); > GEM_BUG_ON(i915->mm.regions[id]); > i915->mm.regions[id] = mem; > + gt->lmem = mem; > > return 0; > } > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h > index df708802889d..cd7744eaaeaa 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h > @@ -23,6 +23,7 @@ > #include "intel_gt_buffer_pool_types.h" > #include "intel_hwconfig.h" > #include "intel_llc_types.h" > +#include "intel_memory_region.h" > #include "intel_reset_types.h" > #include "intel_rc6_types.h" > #include "intel_rps_types.h" > @@ -202,6 +203,8 @@ struct intel_gt { > */ > phys_addr_t phys_addr; > > + struct intel_memory_region *lmem; > + this was somewhere in my next patch that is getting very delayed... anyway, with Jani's include note: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi > struct intel_gt_info { > unsigned int id; > > -- > 2.26.2
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index f33290358c51..7a535f670ae1 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -91,6 +91,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt) GEM_BUG_ON(!HAS_REGION(i915, id)); GEM_BUG_ON(i915->mm.regions[id]); i915->mm.regions[id] = mem; + gt->lmem = mem; return 0; } diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h index df708802889d..cd7744eaaeaa 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h @@ -23,6 +23,7 @@ #include "intel_gt_buffer_pool_types.h" #include "intel_hwconfig.h" #include "intel_llc_types.h" +#include "intel_memory_region.h" #include "intel_reset_types.h" #include "intel_rc6_types.h" #include "intel_rps_types.h" @@ -202,6 +203,8 @@ struct intel_gt { */ phys_addr_t phys_addr; + struct intel_memory_region *lmem; + struct intel_gt_info { unsigned int id;