| Message ID | 20220706215205.2830951-1-umesh.nerlige.ramappa@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i915/perf: Disable OA sseu config param for non-gen11 platforms | expand |
On 07/07/2022 00:52, Nerlige Ramappa, Umesh wrote: > The global sseu config is applicable only to gen11 platforms where > concurrent media, render and OA use cases may cause some subslices to be > turned off and hence lose NOA configuration. Return ENODEV for non-gen11 > platforms. > > Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> The problem is that we have gfx12 platforms shipped using this. So I guess have to disable it on gfx12.5+ where it was never accepted. -Lionel > --- > drivers/gpu/drm/i915/i915_perf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index 1577ab6754db..512c163fdbeb 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf, > case DRM_I915_PERF_PROP_GLOBAL_SSEU: { > struct drm_i915_gem_context_param_sseu user_sseu; > > + if (GRAPHICS_VER(perf->i915) != 11) { > + DRM_DEBUG("Global SSEU config not supported on gen%d\n", > + GRAPHICS_VER(perf->i915)); > + return -ENODEV; > + } > + > if (copy_from_user(&user_sseu, > u64_to_user_ptr(value), > sizeof(user_sseu))) {
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 1577ab6754db..512c163fdbeb 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf, case DRM_I915_PERF_PROP_GLOBAL_SSEU: { struct drm_i915_gem_context_param_sseu user_sseu; + if (GRAPHICS_VER(perf->i915) != 11) { + DRM_DEBUG("Global SSEU config not supported on gen%d\n", + GRAPHICS_VER(perf->i915)); + return -ENODEV; + } + if (copy_from_user(&user_sseu, u64_to_user_ptr(value), sizeof(user_sseu))) {
The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Return ENODEV for non-gen11 platforms. Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> --- drivers/gpu/drm/i915/i915_perf.c | 6 ++++++ 1 file changed, 6 insertions(+)