From patchwork Mon Aug 29 13:11:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12957914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2153C0502C for ; Mon, 29 Aug 2022 13:26:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC46210F345; Mon, 29 Aug 2022 13:26:08 +0000 (UTC) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDB7710F2DE; Mon, 29 Aug 2022 13:25:49 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 440132B06089; Mon, 29 Aug 2022 09:16:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 29 Aug 2022 09:16:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661778972; x= 1661786172; bh=m0bX0yVVXPuP/oiIMrVxVPH8Yeb69EPj7qYI2Vvf/WI=; b=Z PfNQDvfQdg4O/9q5B6QdM4lFRA5ZWXziurkzxm7eLvq12NY96Cl0xdSvybGsKhPw L/R/NtZk/hRdkppkQ2vKyLZ92DTp+c/dcZJvzky6SugiRRbu8sViWJ2Ly8QirghV huf/UgU7uq/yxq13hVu8uEdLw1Aiofnn44QFVPZ1EacRWn8TfUvVMaATqKiU38IV hUvq/x38aUkWISJT7e+7L1nqgj6ZiAyVWZ1zI0hY2lQ4H8BggH8mhxJnSckk2FVN 5Kd3Y9vhCdmvylUwZ21w+wEmIJ4VXEscMiDBHDoPUsuTbsi/+s8SfifxCB/aDh86 /m3Mx+LXGp1g3k7bXuv0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661778972; x= 1661786172; bh=m0bX0yVVXPuP/oiIMrVxVPH8Yeb69EPj7qYI2Vvf/WI=; b=W S5LLf8pI/X2rsE2aqg+J53OTUs72AvcN18KCU3py4vRy2VRNnFvF+upF5spN2gUZ /7zZkNpy6+mtGqyz/beYOidQfU5hUKT0RKVLPsCgU4mpYkcPKzhsF+dFlLsPHybU NOVsiGZSQW6RvAbQetYXEbvnwKvWcWX02FJ7Wo5CqBYVcqzmTA5MP1qauZIRmhfY y5e5M195xjUTZHG3joT1wkI8U3pA9JRyglm3qfI67RHiueZa3pJijuKqBbAg47il dwBud1K0F0PnkNm9vXP6YvHdsEk7U2B1yf8QTjnEXaO6lZJgtnO9O/D14IYw94rR oelDLHECeIJyt2LeVfHfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfogfesthhqredtredtjeenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeefiedvfefggffgffehveejieffuddtgffhjefggeetieduvdeileet lefgveegtdenucevlhhushhtvghrufhiiigvpeeknecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 09:16:11 -0400 (EDT) From: Maxime Ripard To: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen Date: Mon, 29 Aug 2022 15:11:52 +0200 Message-Id: <20220728-rpi-analog-tv-properties-v2-38-459522d653a7@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> MIME-Version: 1.0 X-Mailer: b4 0.10.0-dev-65ba7 X-Developer-Signature: v=1; a=openpgp-sha256; l=1164; i=maxime@cerno.tech; h=from:subject:message-id; bh=54ghzoAkQN+pfS+MGQnqBXckT+/90z2OxxUOtpxMDb8=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMk8uxT7n319YvL7yoeD2997z8petNc1U6DvmO3Ucrtgd/9t Sk73O0pZGMS4GGTFFFlihM2XxJ2a9bqTjW8ezBxWJpAhDFycAjCR248ZGfZ9CtRb/kOU93rd4rlvhS e9m5vw8na/gvVqrc4Xh055Sd5n+Kf1vmrykkDm9B+JV/gMnyvO5bpgbzxLiltO9XRK7htPN24A X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Subject: [Intel-gfx] [PATCH v2 38/41] drm/sun4i: tv: Remove useless destroy function X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Geert Uytterhoeven , Maxime Ripard , Mateusz Kwiatkowski , Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Our destroy implementation is just calling the generic helper, so let's just remove our function and directly use the helper. Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index 52bbba8f19dc..6d7e1d51569a 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -491,15 +491,9 @@ static const struct drm_connector_helper_funcs sun4i_tv_comp_connector_helper_fu .get_modes = sun4i_tv_comp_get_modes, }; -static void -sun4i_tv_comp_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static const struct drm_connector_funcs sun4i_tv_comp_connector_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = sun4i_tv_comp_connector_destroy, + .destroy = drm_connector_cleanup, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,