From patchwork Mon Aug 29 13:11:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12957895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50540ECAAD5 for ; Mon, 29 Aug 2022 13:26:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D2BB10F299; Mon, 29 Aug 2022 13:25:57 +0000 (UTC) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id E25CD10F2C7; Mon, 29 Aug 2022 13:25:48 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 1F6682B0608F; Mon, 29 Aug 2022 09:16:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 29 Aug 2022 09:16:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661778985; x= 1661786185; bh=lN7bNSOCMzy68afbhfiVt1hAVLOOacA7oPD2TeryXSs=; b=g aeOBAyFL3r2QIe8OCH1iFRgWnMODA4K0311mTQusoNqJTsW7pyd4XnwmegAiCpt9 +En8iXRtrSPElJv91UWRtxnyPn/aYJldPEebV0n95tUpwahYP6UyLB+LTesuYSeg Gbt4eFuQyw+NwzT2V6cB1qsCx0Y5yM78mV333wM/GHS5OjKxRw+dfph989WqMoR+ QgiGEf4sCj5YmcKNBvCAKvJLRD05ae0jQ27z5Exs4qJrN2jm07+5dIuL+zBCQCmW KB/CrUcgOdohHUrYImGxpXLotbR4wJaev5JNNlba7zadu67EqptVuogoxmSiLN1o 4L2wXaX/NLI+l7KxLpqfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661778985; x= 1661786185; bh=lN7bNSOCMzy68afbhfiVt1hAVLOOacA7oPD2TeryXSs=; b=T NGs8CcQ9zOUdtTiQPSqj65UfjOy2DqmcoCtDZ+24PqWm9TtsDUYyWT9vrrwMliod MjooPslBJABqRez7Dy7PwgG5Aflf0XXeZ+m1qjiQycHYbjfRQc3UJhyv1SQl+j9L j9xQuhKPPBMlXGPbJZJuZNqtPiMNcqA1tPSRNSTyiotKgD/PK9BNTKbHXxk+hdyT XnLEVDrk+d8Ea2wtXa4vTAoIxOI75qlZ/M6t8xrMvyVcwgePO2L5SC4e05xm+sMo UvJy0VSVVvzB0BXjB6vUjsBj8zbnYVXrfTiEqp+WKms66VJPXNDuuib4fowtrrGY 8JRPKVGvPMsha+caC4cwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfogfesthhqredtredtjeenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeefiedvfefggffgffehveejieffuddtgffhjefggeetieduvdeileet lefgveegtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 09:16:24 -0400 (EDT) From: Maxime Ripard To: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen Date: Mon, 29 Aug 2022 15:11:54 +0200 Message-Id: <20220728-rpi-analog-tv-properties-v2-40-459522d653a7@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> MIME-Version: 1.0 X-Mailer: b4 0.10.0-dev-65ba7 X-Developer-Signature: v=1; a=openpgp-sha256; l=815; i=maxime@cerno.tech; h=from:subject:message-id; bh=r7LcpFs7qXcJi8XUdtLYEk3itduP1hTLzq2Bc5XOe7Q=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMk8uxR5qjSTzZ5o7LpVE7xN9dyhQ549wbl2azjmXeU0dlrf 906/o5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABOZpcDIcE9cdX7DrmXcxb/Y7f67c/ IXqTOzfJ62UcRzrd/Wc9/NHjH8s779wy7khmruMYsYS3e5B3z58Ssabv2u33eslvGSVa0bAwA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Subject: [Intel-gfx] [PATCH v2 40/41] drm/sun4i: tv: Add missing reset assertion X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Geert Uytterhoeven , Maxime Ripard , Mateusz Kwiatkowski , Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The reset line is deasserted at bind, and asserted if we ever encounter an error there. However, it's never asserted in unbind which will lead to a resource unbalance. Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index ad6a3739bfa9..74ff5ad6a8b9 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -605,6 +605,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master, drm_connector_cleanup(&tv->connector); drm_encoder_cleanup(&tv->encoder); clk_disable_unprepare(tv->clk); + reset_control_assert(tv->reset); } static const struct component_ops sun4i_tv_ops = {