diff mbox series

[1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity

Message ID 20220907093534.29004-1-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915/bios: Fix VBT ACPI DPMS bit polarity | expand

Commit Message

Ville Syrjälä Sept. 7, 2022, 9:35 a.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have the ACPI vs. not ACPI DPMS bit polarity the
wrong way around. Fix it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jani Nikula Sept. 12, 2022, 1:06 p.m. UTC | #1 
On Wed, 07 Sep 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We have the ACPI vs. not ACPI DPMS bit polarity the
> wrong way around. Fix it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

For both patches,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index d06b35f17c6a..6119fb035357 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -491,7 +491,7 @@ struct bdb_general_definitions {
>  	u8 crt_ddc_gmbus_pin;
>  
>  	/* DPMS bits */
> -	u8 dpms_acpi:1;
> +	u8 dpms_non_acpi:1;
>  	u8 skip_boot_crt_detect:1;
>  	u8 dpms_aim:1;
>  	u8 rsvd1:5; /* finish byte */
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index d06b35f17c6a..6119fb035357 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -491,7 +491,7 @@  struct bdb_general_definitions {
 	u8 crt_ddc_gmbus_pin;
 
 	/* DPMS bits */
-	u8 dpms_acpi:1;
+	u8 dpms_non_acpi:1;
 	u8 skip_boot_crt_detect:1;
 	u8 dpms_aim:1;
 	u8 rsvd1:5; /* finish byte */