| Message ID | 20221021054719.2090900-1-chaitanya.kumar.borah@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/dg1: Remove require_force_probe protection | expand |
On Fri, Oct 21, 2022 at 11:17:19AM +0530, Chaitanya Kumar Borah wrote: > Remove force probe protection from DG1 platform as testing suggests > that the platform is stable enough. > > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> We do have a clean CI now that Umesh merged these patches: e746f84b8e81 ("i915/uncore: Acquire fw before loop in intel_uncore_read64_2x32") 529d95a6067b ("drm/i915/selftest: Bump up sample period for busy stats selftest") The suspend issue that we now see on our CI is a new non-gfx issue: <6> [781.604766] r8169 0000:06:00.0 enp6s0: Link is Down <3> [782.752413] e1000e 0000:00:1f.6: PM: pci_pm_suspend(): e1000e_pm_suspend+0x0/0x7a0 [e1000e] returns -2 <3> [782.752427] e1000e 0000:00:1f.6: PM: dpm_run_callback(): pci_pm_suspend+0x0/0x150 returns -2 <3> [782.752436] e1000e 0000:00:1f.6: PM: failed to suspend async: error -2 <3> [782.752492] PM: Some devices failed to suspend, or early wake event detected so, on this force_probe protection removal now: Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 19bf5ef6a20d..bbd3e8befb55 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -926,7 +926,6 @@ static const struct intel_device_info dg1_info = { > .__runtime.graphics.ip.rel = 10, > PLATFORM(INTEL_DG1), > .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), > - .require_force_probe = 1, > .__runtime.platform_engine_mask = > BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | > BIT(VCS0) | BIT(VCS2), > -- > 2.25.1 >
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 19bf5ef6a20d..bbd3e8befb55 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -926,7 +926,6 @@ static const struct intel_device_info dg1_info = { .__runtime.graphics.ip.rel = 10, PLATFORM(INTEL_DG1), .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), - .require_force_probe = 1, .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
Remove force probe protection from DG1 platform as testing suggests that the platform is stable enough. Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> --- drivers/gpu/drm/i915/i915_pci.c | 1 - 1 file changed, 1 deletion(-)