| Message ID | 20221107170917.3566758-9-imre.deak@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/tgl+: Enable DC power states on all eDP ports | expand |
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index b1f9bb45d90a2..b36c34f9adbee 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -867,8 +867,7 @@ intel_ddi_main_link_aux_domain(struct intel_digital_port *dig_port, */ if (crtc_state->has_psr) return intel_display_power_aux_io_domain(i915, dig_port->aux_ch); - else if (intel_crtc_has_dp_encoder(crtc_state) || - intel_phy_is_tc(i915, phy)) + else if (intel_phy_is_tc(i915, phy)) return intel_aux_power_domain(dig_port); else return POWER_DOMAIN_INVALID;
Combo PHY ports require the AUX_IO power only for eDP/PSR, so don't enable it otherwise on these ports. So far the external DP and eDP case was handled the same way due to unclarity when AUX_IO for the main link is needed. However Bspec is clear in which cases it's required: - eDP/PSR on all ports and platforms (presumably due to HW/FW initiated PSR transactions that won't enable AUX_IO) Bspec: 4301, 49296 - TypeC PHY ports on platforms before MTL in all TypeC modes (TBT, DP-alt, legacy) and for both HDMI and DP. The next patch will take into account the pre-MTL platform dependency. Bspec: 22243, 53339, 21750, 49190, 49191, 55424, 65448, 65750, 49294, 55480, 65380 Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)