diff mbox series

[2/2] drm/i915/ddi: Add missing wait-for-active for HDMI aligning with bspec updates

Message ID 20221127052232.3942831-3-ankit.k.nautiyal@intel.com (mailing list archive)
State New, archived
Headers show
Series Align DDI_BUF_CTL Active timeouts with Bspec updates | expand

Commit Message

Nautiyal, Ankit K Nov. 27, 2022, 5:22 a.m. UTC 
After enabling DDI_BUF_CTL, wait for DDI_BUF_CTL to be active.
Bspec:4232,53339,49191,54145

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Imre Deak Nov. 28, 2022, 12:25 p.m. UTC | #1 
On Sun, Nov 27, 2022 at 10:52:32AM +0530, Ankit Nautiyal wrote:
> After enabling DDI_BUF_CTL, wait for DDI_BUF_CTL to be active.
> Bspec:4232,53339,49191,54145
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Looks ok to me. On the series:

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 9e16db920bf2..13bf0142627b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2944,6 +2944,8 @@ static void intel_enable_ddi_hdmi(struct intel_atomic_state *state,
>  	}
>  	intel_de_write(dev_priv, DDI_BUF_CTL(port), buf_ctl);
>  
> +	intel_wait_ddi_buf_active(dev_priv, port);
> +
>  	intel_audio_codec_enable(encoder, crtc_state, conn_state);
>  }
>  
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 9e16db920bf2..13bf0142627b 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2944,6 +2944,8 @@  static void intel_enable_ddi_hdmi(struct intel_atomic_state *state,
 	}
 	intel_de_write(dev_priv, DDI_BUF_CTL(port), buf_ctl);
 
+	intel_wait_ddi_buf_active(dev_priv, port);
+
 	intel_audio_codec_enable(encoder, crtc_state, conn_state);
 }