| Message ID | 202212011053265568903@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: use sysfs_emit() to instead of scnprintf() | expand |
On Thu, 01 Dec 2022, <ye.xingchen@zte.com.cn> wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Replace the open-code with sysfs_emit() to simplify the code. I was going to push this, but noticed the function has a third scnprintf(), and the last two play together with count. It would be confusing to have a mix of sysfs_emit() and scnprintf(). The third one can't be blindly converted to sysfs_emit() because it writes at an offset not aligned by PAGE_SIZE. So I'm not taking this. BR, Jani. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/gpu/drm/i915/i915_mitigations.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_mitigations.c b/drivers/gpu/drm/i915/i915_mitigations.c > index def7302ef7fe..2b7aaaefb3a9 100644 > --- a/drivers/gpu/drm/i915/i915_mitigations.c > +++ b/drivers/gpu/drm/i915/i915_mitigations.c > @@ -102,10 +102,10 @@ static int mitigations_get(char *buffer, const struct kernel_param *kp) > bool enable; > > if (!local) > - return scnprintf(buffer, PAGE_SIZE, "%s\n", "off"); > + return sysfs_emit(buffer, "%s\n", "off"); > > if (local & BIT(BITS_PER_LONG - 1)) { > - count = scnprintf(buffer, PAGE_SIZE, "%s,", "auto"); > + count = sysfs_emit(buffer, "%s,", "auto"); > enable = false; > } else { > enable = true;
On Mon, Dec 05, 2022 at 12:50:53PM +0200, Jani Nikula wrote: > On Thu, 01 Dec 2022, <ye.xingchen@zte.com.cn> wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > > > Replace the open-code with sysfs_emit() to simplify the code. > > I was going to push this, but noticed the function has a third > scnprintf(), and the last two play together with count. It would be > confusing to have a mix of sysfs_emit() and scnprintf(). The third one > can't be blindly converted to sysfs_emit() because it writes at an > offset not aligned by PAGE_SIZE. > > So I'm not taking this. > Hi Jani, Fortunately you'd NAKed this patch from ZTE people, which are known for ignoring your (and others) patch review. Remember that they were used to send from cgel.zte gmail account [1], which after the address was banned from LKML, they tried to send from their own corporate account but Greg suspected that emails sent from them are spoofed [2]. Thanks. [1]: https://lore.kernel.org/lkml/878rn1dd8l.fsf@intel.com/ [2]: https://lore.kernel.org/lkml/Y3NqyDDGz%2FUKPgxM@kroah.com/
diff --git a/drivers/gpu/drm/i915/i915_mitigations.c b/drivers/gpu/drm/i915/i915_mitigations.c index def7302ef7fe..2b7aaaefb3a9 100644 --- a/drivers/gpu/drm/i915/i915_mitigations.c +++ b/drivers/gpu/drm/i915/i915_mitigations.c @@ -102,10 +102,10 @@ static int mitigations_get(char *buffer, const struct kernel_param *kp) bool enable; if (!local) - return scnprintf(buffer, PAGE_SIZE, "%s\n", "off"); + return sysfs_emit(buffer, "%s\n", "off"); if (local & BIT(BITS_PER_LONG - 1)) { - count = scnprintf(buffer, PAGE_SIZE, "%s,", "auto"); + count = sysfs_emit(buffer, "%s,", "auto"); enable = false; } else { enable = true;