| Message ID | 20221213121951.1515023-1-andrzej.hajda@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915: use proper helper in igt_vma_move_to_active_unlocked | expand |
On 13/12/2022 12:19, Andrzej Hajda wrote: > There is no need to use _i915_vma_move_to_active. > No functional changes. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > --- > drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > index 1379fbc1443126..71a3ca8a886506 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > @@ -38,7 +38,7 @@ igt_vma_move_to_active_unlocked(struct i915_vma *vma, struct i915_request *rq, > int err; > > i915_vma_lock(vma); > - err = _i915_vma_move_to_active(vma, rq, &rq->fence, flags); > + err = i915_vma_move_to_active(vma, rq, flags); > i915_vma_unlock(vma); > return err; > } Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
Hi Andrzej, On Tue, Dec 13, 2022 at 01:19:50PM +0100, Andrzej Hajda wrote: > There is no need to use _i915_vma_move_to_active. > No functional changes. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi > --- > drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > index 1379fbc1443126..71a3ca8a886506 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > @@ -38,7 +38,7 @@ igt_vma_move_to_active_unlocked(struct i915_vma *vma, struct i915_request *rq, > int err; > > i915_vma_lock(vma); > - err = _i915_vma_move_to_active(vma, rq, &rq->fence, flags); > + err = i915_vma_move_to_active(vma, rq, flags); > i915_vma_unlock(vma); > return err; > } > -- > 2.34.1
Hi Andrzej, On Tue, Dec 13, 2022 at 01:19:50PM +0100, Andrzej Hajda wrote: > There is no need to use _i915_vma_move_to_active. > No functional changes. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> both patches pushed in drm-intel-gt-next. Thanks, Andi > --- > drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > index 1379fbc1443126..71a3ca8a886506 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h > @@ -38,7 +38,7 @@ igt_vma_move_to_active_unlocked(struct i915_vma *vma, struct i915_request *rq, > int err; > > i915_vma_lock(vma); > - err = _i915_vma_move_to_active(vma, rq, &rq->fence, flags); > + err = i915_vma_move_to_active(vma, rq, flags); > i915_vma_unlock(vma); > return err; > } > -- > 2.34.1
diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h index 1379fbc1443126..71a3ca8a886506 100644 --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h @@ -38,7 +38,7 @@ igt_vma_move_to_active_unlocked(struct i915_vma *vma, struct i915_request *rq, int err; i915_vma_lock(vma); - err = _i915_vma_move_to_active(vma, rq, &rq->fence, flags); + err = i915_vma_move_to_active(vma, rq, flags); i915_vma_unlock(vma); return err; }
There is no need to use _i915_vma_move_to_active. No functional changes. Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> --- drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)