| Message ID | 20221222063428.3052172-1-ankit.k.nautiyal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/dsb: Remove check for dsb in dsb_commit | expand |
On 22.12.2022 07:34, Ankit Nautiyal wrote: > The dsb context should be already checked for NULL, before dsb_commit gets > called. So remove the check for dsb inside dsb_commit. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c > index 3d63c1bf1e4f..ce1f8e0c2cd9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsb.c > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c > @@ -228,7 +228,7 @@ void intel_dsb_commit(struct intel_dsb *dsb) > enum pipe pipe = crtc->pipe; > u32 tail; > > - if (!(dsb && dsb->free_pos)) > + if (!dsb->free_pos) Alternative would be allow passing NULL dsb, ie. removal of check on the caller. Anyway: Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > return; > > if (!intel_dsb_enable_engine(dev_priv, pipe, dsb->id))
On 12/29/2022 4:51 PM, Andrzej Hajda wrote: > On 22.12.2022 07:34, Ankit Nautiyal wrote: >> The dsb context should be already checked for NULL, before dsb_commit >> gets >> called. So remove the check for dsb inside dsb_commit. >> >> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c >> b/drivers/gpu/drm/i915/display/intel_dsb.c >> index 3d63c1bf1e4f..ce1f8e0c2cd9 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dsb.c >> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c >> @@ -228,7 +228,7 @@ void intel_dsb_commit(struct intel_dsb *dsb) >> enum pipe pipe = crtc->pipe; >> u32 tail; >> - if (!(dsb && dsb->free_pos)) >> + if (!dsb->free_pos) > > Alternative would be allow passing NULL dsb, ie. removal of check on > the caller. Thanks Andrzej. Yes that can be a way, I just went ahead with, what is followed in other function. Like most of the other dsb functions, we are already using dsb context to get crtc in the first line, so this check at later stage is not useful. Thanks & Regards, Ankit > Anyway: > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Regards > Andrzej > >> return; >> if (!intel_dsb_enable_engine(dev_priv, pipe, dsb->id)) >
> -----Original Message----- > From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com> > Sent: Thursday, December 22, 2022 12:04 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh <animesh.manna@intel.com>; > ville.syrjala@linux.intel.com > Subject: [PATCH] drm/i915/dsb: Remove check for dsb in dsb_commit > > The dsb context should be already checked for NULL, before dsb_commit > gets called. So remove the check for dsb inside dsb_commit. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Earlier intel_dsb_commit() is called without null checking of dsb context. Added the same by the following change. commit b358c3b98813b1557588a11c894b22915251a2ce Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Wed Nov 23 17:26:34 2022 +0200 drm/i915: Make DSB lower level The current change LGTM. Reviewed-by: Animesh Manna <animesh.manna@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c > b/drivers/gpu/drm/i915/display/intel_dsb.c > index 3d63c1bf1e4f..ce1f8e0c2cd9 100644 > --- a/drivers/gpu/drm/i915/display/intl_dsb.c > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c > @@ -228,7 +228,7 @@ void intel_dsb_commit(struct intel_dsb *dsb) > enum pipe pipe = crtc->pipe; > u32 tail; > > - if (!(dsb && dsb->free_pos)) > + if (!dsb->free_pos) > return; > > if (!intel_dsb_enable_engine(dev_priv, pipe, dsb->id)) > -- > 2.25.1
Hi Lakshmi/Sai
The following issues are known issues, not related to the patch:
*
igt@i915_selftest@live@execlists:
https://gitlab.freedesktop.org/drm/intel/-/issues/2940
fi-bsw-n3050: PASS
<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
-> INCOMPLETE
<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
*
igt@i915_selftest@live@guc_multi_lrc:
https://gitlab.freedesktop.org/drm/intel/-/issues/7174
o fi-kbl-soraka: PASS
<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
-> INCOMPLETE
<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
Regards,
Ankit
On 12/22/2022 10:21 PM, Patchwork wrote:
> Project List - Patchwork *Patch Details*
> *Series:* drm/i915/dsb: Remove check for dsb in dsb_commit
> *URL:* https://patchwork.freedesktop.org/series/112159/
> *State:* failure
> *Details:*
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html
>
>
> CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112159v1
>
>
> Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_112159v1 absolutely need
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_112159v1, please notify your bug team to allow
> them
> to document this new failure mode, which will reduce false positives
> in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html
>
>
> Participating hosts (44 -> 45)
>
> Additional (3): bat-adlm-1 bat-atsm-1 fi-tgl-dsi
> Missing (2): fi-hsw-4770 fi-pnv-d510
>
>
> Possible new issues
>
> Here are the unknown changes that may have been introduced in
> Patchwork_112159v1:
>
>
> IGT changes
>
>
> Possible regressions
>
> *
>
> igt@i915_selftest@live@execlists:
>
> o fi-bsw-n3050: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
> -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
> *
>
> igt@i915_selftest@live@guc_multi_lrc:
>
> o fi-kbl-soraka: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
> -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
>
>
> Known issues
>
> Here are the changes found in Patchwork_112159v1 that come from known
> issues:
>
>
> IGT changes
>
>
> Issues hit
>
> *
>
> igt@gem_exec_suspend@basic-s3@smem:
>
> o fi-rkl-11600: NOTRUN -> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html>
> (fdo#103375 <https://bugs.freedesktop.org/show_bug.cgi?id=103375>)
> *
>
> igt@kms_chamelium@common-hpd-after-suspend:
>
> o fi-rkl-11600: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html>
> (fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
> *
>
> igt@runner@aborted:
>
> o fi-bsw-n3050: NOTRUN -> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@runner@aborted.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>)
>
>
> Possible fixes
>
> *
>
> igt@i915_selftest@live@execlists:
>
> o fi-apl-guc: FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@execlists.html>
> -> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@execlists.html>
> +11 similar issues
> *
>
> igt@i915_selftest@live@gt_heartbeat:
>
> o fi-apl-guc: DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html>
> (i915#5334
> <https://gitlab.freedesktop.org/drm/intel/issues/5334>) ->
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html>
> *
>
> igt@i915_suspend@basic-s3-without-i915:
>
> o fi-rkl-11600: INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html>
> (i915#4817
> <https://gitlab.freedesktop.org/drm/intel/issues/4817>) ->
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html>
>
>
> Warnings
>
> * igt@kms_chamelium@common-hpd-after-suspend:
> o fi-apl-guc: SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
>
> {name}: This element is suppressed. This means it is ignored when
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
> Build changes
>
> * Linux: CI_DRM_12522 -> Patchwork_112159v1
>
> CI-20190529: 20190529
> CI_DRM_12522: d659fc77d1fd87f314c1bf510f3fbac009c2529d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_112159v1: d659fc77d1fd87f314c1bf510f3fbac009c2529d @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> Linux commits
>
> ebdee9911f99 drm/i915/dsb: Remove check for dsb in dsb_commit
>
Hi Ankit,
Can you please provide the patchwork series link (If there needed any re-reporting).
Thanks,
Y Sai Nandan
From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
Sent: Monday, January 2, 2023 2:17 PM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Yedireswarapu, SaiX Nandan <saix.nandan.yedireswarapu@intel.com>
Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit
Hi Lakshmi/Sai
The following issues are known issues, not related to the patch:
* igt@i915_selftest@live@execlists: https://gitlab.freedesktop.org/drm/intel/-/issues/2940
fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
* igt@i915_selftest@live@guc_multi_lrc: https://gitlab.freedesktop.org/drm/intel/-/issues/7174
* fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
Regards,
Ankit
On 12/22/2022 10:21 PM, Patchwork wrote:
Patch Details
Series:
drm/i915/dsb: Remove check for dsb in dsb_commit
URL:
https://patchwork.freedesktop.org/series/112159/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html
CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112159v1
Summary
FAILURE
Serious unknown changes coming with Patchwork_112159v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_112159v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html
Participating hosts (44 -> 45)
Additional (3): bat-adlm-1 bat-atsm-1 fi-tgl-dsi
Missing (2): fi-hsw-4770 fi-pnv-d510
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_112159v1:
IGT changes
Possible regressions
* igt@i915_selftest@live@execlists:
* fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html>
* igt@i915_selftest@live@guc_multi_lrc:
* fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html>
Known issues
Here are the changes found in Patchwork_112159v1 that come from known issues:
IGT changes
Issues hit
* igt@gem_exec_suspend@basic-s3@smem:
* fi-rkl-11600: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html> (fdo#103375<https://bugs.freedesktop.org/show_bug.cgi?id=103375>)
* igt@kms_chamelium@common-hpd-after-suspend:
* fi-rkl-11600: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
* igt@runner@aborted:
* fi-bsw-n3050: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@runner@aborted.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
Possible fixes
* igt@i915_selftest@live@execlists:
* fi-apl-guc: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@execlists.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@execlists.html> +11 similar issues
* igt@i915_selftest@live@gt_heartbeat:
* fi-apl-guc: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html>
* igt@i915_suspend@basic-s3-without-i915:
* fi-rkl-11600: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html> (i915#4817<https://gitlab.freedesktop.org/drm/intel/issues/4817>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html>
Warnings
* igt@kms_chamelium@common-hpd-after-suspend:
* fi-apl-guc: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
* Linux: CI_DRM_12522 -> Patchwork_112159v1
CI-20190529: 20190529
CI_DRM_12522: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112159v1: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux
Linux commits
ebdee9911f99 drm/i915/dsb: Remove check for dsb in dsb_commit
Hi, Series is too old, the results have already been deleted. Need a full re-run of this series. https://patchwork.freedesktop.org/series/112159/ Please provide the new patchwork series revision if issue is still observed. Thanks, Y Sai Nandan From: Yedireswarapu, SaiX Nandan Sent: Monday, January 2, 2023 2:49 PM To: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <Lakshminarayana.Vudum@intel.com> Cc: Veesam, RavitejaX <RavitejaX.Veesam@intel.com> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit Hi Ankit, Can you please provide the patchwork series link (If there needed any re-reporting). Thanks, Y Sai Nandan From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com<mailto:ankit.k.nautiyal@intel.com>> Sent: Monday, January 2, 2023 2:17 PM To: intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com<mailto:lakshminarayana.vudum@intel.com>>; Yedireswarapu, SaiX Nandan <saix.nandan.yedireswarapu@intel.com<mailto:saix.nandan.yedireswarapu@intel.com>> Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit Hi Lakshmi/Sai The following issues are known issues, not related to the patch: * igt@i915_selftest@live@execlists: https://gitlab.freedesktop.org/drm/intel/-/issues/2940 fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> * igt@i915_selftest@live@guc_multi_lrc: https://gitlab.freedesktop.org/drm/intel/-/issues/7174 * fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> Regards, Ankit On 12/22/2022 10:21 PM, Patchwork wrote: Patch Details Series: drm/i915/dsb: Remove check for dsb in dsb_commit URL: https://patchwork.freedesktop.org/series/112159/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112159v1 Summary FAILURE Serious unknown changes coming with Patchwork_112159v1 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_112159v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html Participating hosts (44 -> 45) Additional (3): bat-adlm-1 bat-atsm-1 fi-tgl-dsi Missing (2): fi-hsw-4770 fi-pnv-d510 Possible new issues Here are the unknown changes that may have been introduced in Patchwork_112159v1: IGT changes Possible regressions * igt@i915_selftest@live@execlists: * fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> * igt@i915_selftest@live@guc_multi_lrc: * fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> Known issues Here are the changes found in Patchwork_112159v1 that come from known issues: IGT changes Issues hit * igt@gem_exec_suspend@basic-s3@smem: * fi-rkl-11600: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html> (fdo#103375<https://bugs.freedesktop.org/show_bug.cgi?id=103375>) * igt@kms_chamelium@common-hpd-after-suspend: * fi-rkl-11600: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) * igt@runner@aborted: * fi-bsw-n3050: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@runner@aborted.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>) Possible fixes * igt@i915_selftest@live@execlists: * fi-apl-guc: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@execlists.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@execlists.html> +11 similar issues * igt@i915_selftest@live@gt_heartbeat: * fi-apl-guc: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> * igt@i915_suspend@basic-s3-without-i915: * fi-rkl-11600: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html> (i915#4817<https://gitlab.freedesktop.org/drm/intel/issues/4817>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html> Warnings * igt@kms_chamelium@common-hpd-after-suspend: * fi-apl-guc: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). Build changes * Linux: CI_DRM_12522 -> Patchwork_112159v1 CI-20190529: 20190529 CI_DRM_12522: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_112159v1: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux Linux commits ebdee9911f99 drm/i915/dsb: Remove check for dsb in dsb_commit
Thanks Sai, will submit for re-run. From: Yedireswarapu, SaiX Nandan <saix.nandan.yedireswarapu@intel.com> Sent: Monday, January 2, 2023 5:09 PM To: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Cc: Veesam, RavitejaX <ravitejax.veesam@intel.com>; Latvala, Petri <petri.latvala@intel.com> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit Hi, Series is too old, the results have already been deleted. Need a full re-run of this series. https://patchwork.freedesktop.org/series/112159/ Please provide the new patchwork series revision if issue is still observed. Thanks, Y Sai Nandan From: Yedireswarapu, SaiX Nandan Sent: Monday, January 2, 2023 2:49 PM To: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com<mailto:ankit.k.nautiyal@intel.com>>; intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>; Vudum, Lakshminarayana <Lakshminarayana.Vudum@intel.com<mailto:Lakshminarayana.Vudum@intel.com>> Cc: Veesam, RavitejaX <RavitejaX.Veesam@intel.com<mailto:RavitejaX.Veesam@intel.com>> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit Hi Ankit, Can you please provide the patchwork series link (If there needed any re-reporting). Thanks, Y Sai Nandan From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com<mailto:ankit.k.nautiyal@intel.com>> Sent: Monday, January 2, 2023 2:17 PM To: intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com<mailto:lakshminarayana.vudum@intel.com>>; Yedireswarapu, SaiX Nandan <saix.nandan.yedireswarapu@intel.com<mailto:saix.nandan.yedireswarapu@intel.com>> Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit Hi Lakshmi/Sai The following issues are known issues, not related to the patch: * igt@i915_selftest@live@execlists: https://gitlab.freedesktop.org/drm/intel/-/issues/2940 fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> * igt@i915_selftest@live@guc_multi_lrc: https://gitlab.freedesktop.org/drm/intel/-/issues/7174 * fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> Regards, Ankit On 12/22/2022 10:21 PM, Patchwork wrote: Patch Details Series: drm/i915/dsb: Remove check for dsb in dsb_commit URL: https://patchwork.freedesktop.org/series/112159/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112159v1 Summary FAILURE Serious unknown changes coming with Patchwork_112159v1 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_112159v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/index.html Participating hosts (44 -> 45) Additional (3): bat-adlm-1 bat-atsm-1 fi-tgl-dsi Missing (2): fi-hsw-4770 fi-pnv-d510 Possible new issues Here are the unknown changes that may have been introduced in Patchwork_112159v1: IGT changes Possible regressions * igt@i915_selftest@live@execlists: * fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> * igt@i915_selftest@live@guc_multi_lrc: * fi-kbl-soraka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html> Known issues Here are the changes found in Patchwork_112159v1 that come from known issues: IGT changes Issues hit * igt@gem_exec_suspend@basic-s3@smem: * fi-rkl-11600: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html> (fdo#103375<https://bugs.freedesktop.org/show_bug.cgi?id=103375>) * igt@kms_chamelium@common-hpd-after-suspend: * fi-rkl-11600: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) * igt@runner@aborted: * fi-bsw-n3050: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-bsw-n3050/igt@runner@aborted.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>) Possible fixes * igt@i915_selftest@live@execlists: * fi-apl-guc: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@execlists.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@execlists.html> +11 similar issues * igt@i915_selftest@live@gt_heartbeat: * fi-apl-guc: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> * igt@i915_suspend@basic-s3-without-i915: * fi-rkl-11600: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html> (i915#4817<https://gitlab.freedesktop.org/drm/intel/issues/4817>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html> Warnings * igt@kms_chamelium@common-hpd-after-suspend: * fi-apl-guc: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12522/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112159v1/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). Build changes * Linux: CI_DRM_12522 -> Patchwork_112159v1 CI-20190529: 20190529 CI_DRM_12522: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_112159v1: d659fc77d1fd87f314c1bf510f3fbac009c2529d @ git://anongit.freedesktop.org/gfx-ci/linux Linux commits ebdee9911f99 drm/i915/dsb: Remove check for dsb in dsb_commit
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index 3d63c1bf1e4f..ce1f8e0c2cd9 100644 --- a/drivers/gpu/drm/i915/display/intel_dsb.c +++ b/drivers/gpu/drm/i915/display/intel_dsb.c @@ -228,7 +228,7 @@ void intel_dsb_commit(struct intel_dsb *dsb) enum pipe pipe = crtc->pipe; u32 tail; - if (!(dsb && dsb->free_pos)) + if (!dsb->free_pos) return; if (!intel_dsb_enable_engine(dev_priv, pipe, dsb->id))
The dsb context should be already checked for NULL, before dsb_commit gets called. So remove the check for dsb inside dsb_commit. Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> --- drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)