| Message ID | 20221230183500.20553-1-nirmoy.das@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Use "%zu" to format size_t | expand |
Nirmoy, thanks for fixing it Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> On 12/30/22 8:35 PM, Nirmoy Das wrote: > Switch to %zu for printing size_t which will > fix compilation warning for 32-bit build. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > index e767791e40e0..114443096841 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > @@ -238,7 +238,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj) > goto rebuild_st; > } else { > dev_warn(i915->drm.dev, > - "Failed to DMA remap %lu pages\n", > + "Failed to DMA remap %zu pages\n", > obj->base.size >> PAGE_SHIFT); > goto err_pages; > }
On Fri, Dec 30, 2022 at 07:35:00PM +0100, Nirmoy Das wrote: > Switch to %zu for printing size_t which will > fix compilation warning for 32-bit build. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > index e767791e40e0..114443096841 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > @@ -238,7 +238,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj) > goto rebuild_st; > } else { > dev_warn(i915->drm.dev, > - "Failed to DMA remap %lu pages\n", > + "Failed to DMA remap %zu pages\n", > obj->base.size >> PAGE_SHIFT); > goto err_pages; > } > -- > 2.38.0
This fix has nothing to do with IGT Possible regression. This fixes the code that raised build warnings in 32-bit environments. And this patch has been merged. On 12/30/22 9:37 PM, Patchwork wrote: > *Patch Details* > *Series:* drm/i915: Use "%zu" to format size_t > *URL:* https://patchwork.freedesktop.org/series/112317/ > <https://patchwork.freedesktop.org/series/112317/> > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html> > > > CI Bug Log - changes from CI_DRM_12532 -> Patchwork_112317v1 > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_112317v1 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_112317v1, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html > > > Participating hosts (44 -> 43) > > Additional (1): fi-kbl-soraka > Missing (2): fi-rkl-11600 fi-snb-2520m > > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_112317v1: > > > IGT changes > > > Possible regressions > > * igt@i915_selftest@live@slpc: > o fi-kbl-soraka: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@i915_selftest@live@slpc.html> > > > Known issues > > Here are the changes found in Patchwork_112317v1 that come from known > issues: > > > IGT changes > > > Issues hit > > * > > igt@gem_exec_gttfill@basic: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +7 > similar issues > * > > igt@gem_huc_copy@huc-copy: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > * > > igt@gem_lmem_swapping@basic: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#4613 > <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 > similar issues > * > > igt@i915_selftest@live@gt_heartbeat: > > o fi-apl-guc: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> > -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> > (i915#5334 <https://gitlab.freedesktop.org/drm/intel/issues/5334>) > * > > igt@i915_selftest@live@gt_pm: > > o fi-kbl-soraka: NOTRUN -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> > (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>) > * > > igt@kms_chamelium@common-hpd-after-suspend: > > o fi-hsw-4770: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > * > > igt@kms_chamelium@hdmi-hpd-fast: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 > similar issues > > > Possible fixes > > * > > igt@i915_selftest@live@hangcheck: > > o fi-hsw-4770: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> > (i915#4785 > <https://gitlab.freedesktop.org/drm/intel/issues/4785>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> > * > > igt@i915_selftest@live@requests: > > o {bat-rpls-1}: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-1/igt@i915_selftest@live@requests.html> > (i915#6257 > <https://gitlab.freedesktop.org/drm/intel/issues/6257>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/bat-rpls-1/igt@i915_selftest@live@requests.html> > * > > igt@i915_selftest@live@reset: > > o {bat-rpls-2}: DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-2/igt@i915_selftest@live@reset.html> > (i915#4983 > <https://gitlab.freedesktop.org/drm/intel/issues/4983>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/bat-rpls-2/igt@i915_selftest@live@reset.html> > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > > Build changes > > * Linux: CI_DRM_12532 -> Patchwork_112317v1 > > CI-20190529: 20190529 > CI_DRM_12532: 91195847031b60062eb046b8bb0c9e64a2291e10 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7104: fe5def13049225967770eaaf19ec01ef80e2adc5 @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_112317v1: 91195847031b60062eb046b8bb0c9e64a2291e10 @ > git://anongit.freedesktop.org/gfx-ci/linux > > > Linux commits > > c0b7c80b83b2 drm/i915: Use "%zu" to format size_t >
Yes makes sense, thanks, G.G. On 1/3/2023 9:11 AM, Gwan-gyeong Mun wrote: > This fix has nothing to do with IGT Possible regression. > This fixes the code that raised build warnings in 32-bit environments. > And this patch has been merged. > > On 12/30/22 9:37 PM, Patchwork wrote: >> *Patch Details* >> *Series:* drm/i915: Use "%zu" to format size_t >> *URL:* https://patchwork.freedesktop.org/series/112317/ >> <https://patchwork.freedesktop.org/series/112317/> >> *State:* failure >> *Details:* >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html> >> >> >> CI Bug Log - changes from CI_DRM_12532 -> Patchwork_112317v1 >> >> >> Summary >> >> *FAILURE* >> >> Serious unknown changes coming with Patchwork_112317v1 absolutely >> need to be >> verified manually. >> >> If you think the reported changes have nothing to do with the changes >> introduced in Patchwork_112317v1, please notify your bug team to >> allow them >> to document this new failure mode, which will reduce false positives >> in CI. >> >> External URL: >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/index.html >> >> >> Participating hosts (44 -> 43) >> >> Additional (1): fi-kbl-soraka >> Missing (2): fi-rkl-11600 fi-snb-2520m >> >> >> Possible new issues >> >> Here are the unknown changes that may have been introduced in >> Patchwork_112317v1: >> >> >> IGT changes >> >> >> Possible regressions >> >> * igt@i915_selftest@live@slpc: >> o fi-kbl-soraka: NOTRUN -> INCOMPLETE >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@i915_selftest@live@slpc.html> >> >> >> Known issues >> >> Here are the changes found in Patchwork_112317v1 that come from known >> issues: >> >> >> IGT changes >> >> >> Issues hit >> >> * >> >> igt@gem_exec_gttfill@basic: >> >> o fi-kbl-soraka: NOTRUN -> SKIP >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html> >> (fdo#109271 >> <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +7 >> similar issues >> * >> >> igt@gem_huc_copy@huc-copy: >> >> o fi-kbl-soraka: NOTRUN -> SKIP >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> >> (fdo#109271 >> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / >> i915#2190 >> <https://gitlab.freedesktop.org/drm/intel/issues/2190>) >> * >> >> igt@gem_lmem_swapping@basic: >> >> o fi-kbl-soraka: NOTRUN -> SKIP >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> >> (fdo#109271 >> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / >> i915#4613 >> <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 >> similar issues >> * >> >> igt@i915_selftest@live@gt_heartbeat: >> >> o fi-apl-guc: PASS >> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> >> -> DMESG-FAIL >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> >> (i915#5334 >> <https://gitlab.freedesktop.org/drm/intel/issues/5334>) >> * >> >> igt@i915_selftest@live@gt_pm: >> >> o fi-kbl-soraka: NOTRUN -> DMESG-FAIL >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> >> (i915#1886 >> <https://gitlab.freedesktop.org/drm/intel/issues/1886>) >> * >> >> igt@kms_chamelium@common-hpd-after-suspend: >> >> o fi-hsw-4770: NOTRUN -> SKIP >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html> >> (fdo#109271 >> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / >> fdo#111827 >> <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) >> * >> >> igt@kms_chamelium@hdmi-hpd-fast: >> >> o fi-kbl-soraka: NOTRUN -> SKIP >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html> >> (fdo#109271 >> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / >> fdo#111827 >> <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 >> similar issues >> >> >> Possible fixes >> >> * >> >> igt@i915_selftest@live@hangcheck: >> >> o fi-hsw-4770: INCOMPLETE >> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> >> (i915#4785 >> <https://gitlab.freedesktop.org/drm/intel/issues/4785>) -> PASS >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> >> * >> >> igt@i915_selftest@live@requests: >> >> o {bat-rpls-1}: INCOMPLETE >> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-1/igt@i915_selftest@live@requests.html> >> (i915#6257 >> <https://gitlab.freedesktop.org/drm/intel/issues/6257>) -> PASS >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/bat-rpls-1/igt@i915_selftest@live@requests.html> >> * >> >> igt@i915_selftest@live@reset: >> >> o {bat-rpls-2}: DMESG-FAIL >> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-2/igt@i915_selftest@live@reset.html> >> (i915#4983 >> <https://gitlab.freedesktop.org/drm/intel/issues/4983>) -> PASS >> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112317v1/bat-rpls-2/igt@i915_selftest@live@reset.html> >> >> {name}: This element is suppressed. This means it is ignored when >> computing >> the status of the difference (SUCCESS, WARNING, or FAILURE). >> >> >> Build changes >> >> * Linux: CI_DRM_12532 -> Patchwork_112317v1 >> >> CI-20190529: 20190529 >> CI_DRM_12532: 91195847031b60062eb046b8bb0c9e64a2291e10 @ >> git://anongit.freedesktop.org/gfx-ci/linux >> IGT_7104: fe5def13049225967770eaaf19ec01ef80e2adc5 @ >> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git >> Patchwork_112317v1: 91195847031b60062eb046b8bb0c9e64a2291e10 @ >> git://anongit.freedesktop.org/gfx-ci/linux >> >> >> Linux commits >> >> c0b7c80b83b2 drm/i915: Use "%zu" to format size_t >>
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c index e767791e40e0..114443096841 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c @@ -238,7 +238,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj) goto rebuild_st; } else { dev_warn(i915->drm.dev, - "Failed to DMA remap %lu pages\n", + "Failed to DMA remap %zu pages\n", obj->base.size >> PAGE_SHIFT); goto err_pages; }
Switch to %zu for printing size_t which will fix compilation warning for 32-bit build. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)