| Message ID | 20230329172434.18744-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915: Fix fast wake AUX sync len | expand |
On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Fast wake should use 8 SYNC pulses for the preamble > and 10-16 SYNC pulses for the precharge. Recuce our > fast wake SYNC count to match the maximum value. > We also use the maximum precharge length for normal > AUX transactions. > > Cc: Jouni Högander <jouni.hogander@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c > b/drivers/gpu/drm/i915/display/intel_dp_aux.c > index eb07dc5d8709..ad0aac707219 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > @@ -164,7 +164,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp > *intel_dp, > DP_AUX_CH_CTL_TIME_OUT_MAX | > DP_AUX_CH_CTL_RECEIVE_ERROR | > (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) | > - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(32) | > + DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) | > DP_AUX_CH_CTL_SYNC_PULSE_SKL(32); > > if (intel_tc_port_in_tbt_alt_mode(dig_port))
This patch cause suspend to disk resume later hdmi out no sound. Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound work.
On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote: > This patch cause suspend to disk resume later hdmi out no sound. > Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound work. I find that hard to believe. Fast wake is a PSR2 thing, which has nothing to do with HDMI.
pcmC0D3p use for hdmi sound out, numid=13,iface=CARD,name='HDMI/DP,pcm=3 Jack' ; type=BOOLEAN,access=r-------,values=1 : values=on this patch cause 'HDMI/DP,pcm=3 Jack' value off, hdmi sound not work, replug hdmi cable no useful, still no sound, 'HDMI/DP,pcm=3 Jack' unable become on, have to reboot. 2023-04-25 17:31 GMT+08:00, Ville Syrjälä <ville.syrjala@linux.intel.com>: > On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote: >> This patch cause suspend to disk resume later hdmi out no sound. >> Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound >> work. > > I find that hard to believe. Fast wake is a PSR2 thing, which has > nothing to do with HDMI. > > -- > Ville Syrjälä > Intel >
When i from kernel 6.3rc7 update to 6.3 release, it happened this hdmi sound problem. I retest many times, the cause of the problem is not this patch, i'm so sorry. 2023-04-25 21:52 GMT+08:00, youling 257 <youling257@gmail.com>: > pcmC0D3p use for hdmi sound out, > numid=13,iface=CARD,name='HDMI/DP,pcm=3 Jack' > ; type=BOOLEAN,access=r-------,values=1 > : values=on > > this patch cause 'HDMI/DP,pcm=3 Jack' value off, hdmi sound not work, > replug hdmi cable no useful, still no sound, 'HDMI/DP,pcm=3 Jack' > unable become on, have to reboot. > > 2023-04-25 17:31 GMT+08:00, Ville Syrjälä <ville.syrjala@linux.intel.com>: >> On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote: >>> This patch cause suspend to disk resume later hdmi out no sound. >>> Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound >>> work. >> >> I find that hard to believe. Fast wake is a PSR2 thing, which has >> nothing to do with HDMI. >> >> -- >> Ville Syrjälä >> Intel >> >
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c index eb07dc5d8709..ad0aac707219 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c @@ -164,7 +164,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp, DP_AUX_CH_CTL_TIME_OUT_MAX | DP_AUX_CH_CTL_RECEIVE_ERROR | (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) | - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(32) | + DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) | DP_AUX_CH_CTL_SYNC_PULSE_SKL(32); if (intel_tc_port_in_tbt_alt_mode(dig_port))