| Message ID | 20230424133607.3736825-1-tejas.upadhyay@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/selftest: Record GT error for gt failure | expand |
Hi Tejas, On Mon, Apr 24, 2023 at 07:06:07PM +0530, Tejas Upadhyay wrote: > igt_live_test has pr_err dumped in case of some > GT failures. It will be more informative regarding > GT if we use gt_err instead. > > Cc: Andi Shyti <andi.shyti@intel.com> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com> Thanks for taking care of this. Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi
Hi Tejas, On Mon, Apr 24, 2023 at 07:06:07PM +0530, Tejas Upadhyay wrote: > igt_live_test has pr_err dumped in case of some > GT failures. It will be more informative regarding > GT if we use gt_err instead. > > Cc: Andi Shyti <andi.shyti@intel.com> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com> pushed to drm-intel-gt-next. Thanks, Andi
diff --git a/drivers/gpu/drm/i915/selftests/igt_live_test.c b/drivers/gpu/drm/i915/selftests/igt_live_test.c index 714b7afc490b..4ddc6d902752 100644 --- a/drivers/gpu/drm/i915/selftests/igt_live_test.c +++ b/drivers/gpu/drm/i915/selftests/igt_live_test.c @@ -6,6 +6,7 @@ #include "i915_drv.h" #include "gt/intel_gt.h" +#include "gt/intel_gt_print.h" #include "../i915_selftest.h" #include "igt_flush_test.h" @@ -30,7 +31,7 @@ int igt_live_test_begin(struct igt_live_test *t, err = intel_gt_wait_for_idle(gt, MAX_SCHEDULE_TIMEOUT); if (err) { - pr_err("%s(%s): failed to idle before, with err=%d!", + gt_err(gt, "%s(%s): GT failed to idle before, with err=%d!", func, name, err); return err; } @@ -69,7 +70,7 @@ int igt_live_test_end(struct igt_live_test *t) i915_reset_engine_count(&i915->gpu_error, engine)) continue; - pr_err("%s(%s): engine '%s' was reset %d times!\n", + gt_err(gt, "%s(%s): engine '%s' was reset %d times!\n", t->func, t->name, engine->name, i915_reset_engine_count(&i915->gpu_error, engine) - t->reset_engine[id]);
igt_live_test has pr_err dumped in case of some GT failures. It will be more informative regarding GT if we use gt_err instead. Cc: Andi Shyti <andi.shyti@intel.com> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com> --- drivers/gpu/drm/i915/selftests/igt_live_test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)