diff mbox series

drm/i915/display: Update the DDI_BUF_CTL active timeout for ADL-P

Message ID 20230505110917.1918957-1-ankit.k.nautiyal@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/display: Update the DDI_BUF_CTL active timeout for ADL-P | expand

Commit Message

Nautiyal, Ankit K May 5, 2023, 11:09 a.m. UTC
For ADL-P the timeout for DDI_BUF_CTL active is 500usec.
Update the same as per Bspec:55424.

Fixes: 5add4575c298 ("drm/i915/ddi: Align timeout for DDI_BUF_CTL active with Bspec")
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <stable@vger.kernel.org> # v6.3+

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Gustavo Sousa May 8, 2023, 1:43 p.m. UTC | #1
Quoting Ankit Nautiyal (2023-05-05 08:09:17)
>For ADL-P the timeout for DDI_BUF_CTL active is 500usec.
>Update the same as per Bspec:55424.

I think the Bspec number could go as a trailer. We could also add BSpec 49191
here.

Acked-by: Gustavo Sousa <gustavo.sousa@intel.com>

>
>Fixes: 5add4575c298 ("drm/i915/ddi: Align timeout for DDI_BUF_CTL active with Bspec")
>Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>Cc: Imre Deak <imre.deak@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: <stable@vger.kernel.org> # v6.3+
>
>Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>index 55f36d9d509c..6d8e4d7a784e 100644
>--- a/drivers/gpu/drm/i915/display/intel_ddi.c
>+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>@@ -216,8 +216,11 @@ static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv,
>        } else if (DISPLAY_VER(dev_priv) >= 12) {
>                if (intel_phy_is_tc(dev_priv, phy))
>                        timeout_us = 3000;
>+          else if (IS_ALDERLAKE_P(dev_priv))
>+                  timeout_us = 500;
>                else
>                        timeout_us = 1000;
>+
>        } else {
>                timeout_us = 500;
>        }
>-- 
>2.25.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 55f36d9d509c..6d8e4d7a784e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -216,8 +216,11 @@  static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv,
 	} else if (DISPLAY_VER(dev_priv) >= 12) {
 		if (intel_phy_is_tc(dev_priv, phy))
 			timeout_us = 3000;
+		else if (IS_ALDERLAKE_P(dev_priv))
+			timeout_us = 500;
 		else
 			timeout_us = 1000;
+
 	} else {
 		timeout_us = 500;
 	}