diff mbox series

drm/i915/gsc: use system include style for drm headers

Message ID 20230525094942.941123-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/gsc: use system include style for drm headers | expand

Commit Message

Jani Nikula May 25, 2023, 9:49 a.m. UTC
Use <> instead of "" for including headers from include/.

Fixes: 8a9bf29546a1 ("drm/i915/gsc: add initial support for GSC proxy")
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Luca Coelho May 25, 2023, 9:59 a.m. UTC | #1
On Thu, 2023-05-25 at 12:49 +0300, Jani Nikula wrote:
> Use <> instead of "" for including headers from include/.
> 
> Fixes: 8a9bf29546a1 ("drm/i915/gsc: add initial support for GSC proxy")
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> index ebee0b5a2c1d..5f138de3c14f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> @@ -5,8 +5,8 @@
>  
>  #include <linux/component.h>
>  
> -#include "drm/i915_component.h"
> -#include "drm/i915_gsc_proxy_mei_interface.h"
> +#include <drm/i915_component.h>
> +#include <drm/i915_gsc_proxy_mei_interface.h>
>  
>  #include "gt/intel_gt.h"
>  #include "gt/intel_gt_print.h"

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.
Daniele Ceraolo Spurio May 25, 2023, 4:32 p.m. UTC | #2
On 5/25/2023 2:49 AM, Jani Nikula wrote:
> Use <> instead of "" for including headers from include/.
>
> Fixes: 8a9bf29546a1 ("drm/i915/gsc: add initial support for GSC proxy")
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

dumb mistake, thanks for fixing it

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> index ebee0b5a2c1d..5f138de3c14f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> @@ -5,8 +5,8 @@
>   
>   #include <linux/component.h>
>   
> -#include "drm/i915_component.h"
> -#include "drm/i915_gsc_proxy_mei_interface.h"
> +#include <drm/i915_component.h>
> +#include <drm/i915_gsc_proxy_mei_interface.h>
>   
>   #include "gt/intel_gt.h"
>   #include "gt/intel_gt_print.h"
Jani Nikula May 26, 2023, 10:16 a.m. UTC | #3
On Thu, 25 May 2023, "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com> wrote:
> On 5/25/2023 2:49 AM, Jani Nikula wrote:
>> Use <> instead of "" for including headers from include/.
>>
>> Fixes: 8a9bf29546a1 ("drm/i915/gsc: add initial support for GSC proxy")
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> dumb mistake, thanks for fixing it

It happens, no worries.

> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Thanks for the reviews, pushed to drm-intel-gt-next.

BR,
Jani.


>
> Daniele
>
>> ---
>>   drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
>> index ebee0b5a2c1d..5f138de3c14f 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
>> @@ -5,8 +5,8 @@
>>   
>>   #include <linux/component.h>
>>   
>> -#include "drm/i915_component.h"
>> -#include "drm/i915_gsc_proxy_mei_interface.h"
>> +#include <drm/i915_component.h>
>> +#include <drm/i915_gsc_proxy_mei_interface.h>
>>   
>>   #include "gt/intel_gt.h"
>>   #include "gt/intel_gt_print.h"
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
index ebee0b5a2c1d..5f138de3c14f 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
@@ -5,8 +5,8 @@ 
 
 #include <linux/component.h>
 
-#include "drm/i915_component.h"
-#include "drm/i915_gsc_proxy_mei_interface.h"
+#include <drm/i915_component.h>
+#include <drm/i915_gsc_proxy_mei_interface.h>
 
 #include "gt/intel_gt.h"
 #include "gt/intel_gt_print.h"