| Message ID | 20230530101649.2549949-1-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/i915: Use 18 fast wake AUX sync len | expand |
On Tue, 2023-05-30 at 13:16 +0300, Jouni Högander wrote: > HW default for wake sync pulses is 18. 10 precarge and 8 preamble. There is Small typo: s/precarge/precharge/ > no reason to change this especially as it is causing problems with certain > eDP panels. > > v3: Change "Fixes:" commit > v2: Remove "fast wake" repeat from subject > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8475 > --- > drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c > index 0c27db8ae4f1..197c6e81db14 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) > > static int intel_dp_aux_fw_sync_len(void) > { > - int precharge = 16; /* 10-16 */ > + int precharge = 10; /* 10-16 */ > int preamble = 8; > > return precharge + preamble; If this really solves the problem, and since the comment clearly says that the range is from 10 to 16, it looks good to me. Reviewed-by: Luca Coelho <luciano.coelho@intel.com> -- Cheers, Luca.
On Fri, 2023-06-02 at 11:40 +0300, Luca Coelho wrote: > On Tue, 2023-05-30 at 13:16 +0300, Jouni Högander wrote: > > HW default for wake sync pulses is 18. 10 precarge and 8 preamble. > > There is > > Small typo: s/precarge/precharge/ > > > > no reason to change this especially as it is causing problems with > > certain > > eDP panels. > > > > v3: Change "Fixes:" commit > > v2: Remove "fast wake" repeat from subject > > > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > > Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8475 > > --- > > drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c > > b/drivers/gpu/drm/i915/display/intel_dp_aux.c > > index 0c27db8ae4f1..197c6e81db14 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > > @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) > > > > static int intel_dp_aux_fw_sync_len(void) > > { > > - int precharge = 16; /* 10-16 */ > > + int precharge = 10; /* 10-16 */ > > int preamble = 8; > > > > return precharge + preamble; > > If this really solves the problem, and since the comment clearly says > that the range is from 10 to 16, it looks good to me. > > Reviewed-by: Luca Coelho <luciano.coelho@intel.com> Thank you Luca for the review. This is now pushed with your rb tag and typo mentioned above fixed. > > -- > Cheers, > Luca.
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c index 0c27db8ae4f1..197c6e81db14 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) static int intel_dp_aux_fw_sync_len(void) { - int precharge = 16; /* 10-16 */ + int precharge = 10; /* 10-16 */ int preamble = 8; return precharge + preamble;
HW default for wake sync pulses is 18. 10 precarge and 8 preamble. There is no reason to change this especially as it is causing problems with certain eDP panels. v3: Change "Fixes:" commit v2: Remove "fast wake" repeat from subject Signed-off-by: Jouni Högander <jouni.hogander@intel.com> Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8475 --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)