| Message ID | 20230606191504.18099-9-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Load LUTs with DSB | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville > Syrjala > Sent: Wednesday, June 7, 2023 12:45 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 08/19] drm/i915/dsb: Introduce intel_dsb_noop() > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Add a helper for emitting a number of DSB NOOPs commands. Looks Good to me. Reviewed-by: Uma Shankar <uma.shankar@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_dsb.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_dsb.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c > b/drivers/gpu/drm/i915/display/intel_dsb.c > index 22c716ee75e2..4ef799c087b4 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsb.c > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c > @@ -234,6 +234,15 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, > } > } > > +void intel_dsb_noop(struct intel_dsb *dsb, int count) { > + int i; > + > + for (i = 0; i < count; i++) > + intel_dsb_emit(dsb, 0, > + DSB_OPCODE_NOOP << DSB_OPCODE_SHIFT); } > + > static void intel_dsb_align_tail(struct intel_dsb *dsb) { > u32 aligned_tail, tail; > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h > b/drivers/gpu/drm/i915/display/intel_dsb.h > index b8148b47022d..5a08bc21beda 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsb.h > +++ b/drivers/gpu/drm/i915/display/intel_dsb.h > @@ -19,6 +19,7 @@ void intel_dsb_finish(struct intel_dsb *dsb); void > intel_dsb_cleanup(struct intel_dsb *dsb); void intel_dsb_reg_write(struct > intel_dsb *dsb, > i915_reg_t reg, u32 val); > +void intel_dsb_noop(struct intel_dsb *dsb, int count); > void intel_dsb_commit(struct intel_dsb *dsb, > bool wait_for_vblank); > void intel_dsb_wait(struct intel_dsb *dsb); > -- > 2.39.3
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index 22c716ee75e2..4ef799c087b4 100644 --- a/drivers/gpu/drm/i915/display/intel_dsb.c +++ b/drivers/gpu/drm/i915/display/intel_dsb.c @@ -234,6 +234,15 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, } } +void intel_dsb_noop(struct intel_dsb *dsb, int count) +{ + int i; + + for (i = 0; i < count; i++) + intel_dsb_emit(dsb, 0, + DSB_OPCODE_NOOP << DSB_OPCODE_SHIFT); +} + static void intel_dsb_align_tail(struct intel_dsb *dsb) { u32 aligned_tail, tail; diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h index b8148b47022d..5a08bc21beda 100644 --- a/drivers/gpu/drm/i915/display/intel_dsb.h +++ b/drivers/gpu/drm/i915/display/intel_dsb.h @@ -19,6 +19,7 @@ void intel_dsb_finish(struct intel_dsb *dsb); void intel_dsb_cleanup(struct intel_dsb *dsb); void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val); +void intel_dsb_noop(struct intel_dsb *dsb, int count); void intel_dsb_commit(struct intel_dsb *dsb, bool wait_for_vblank); void intel_dsb_wait(struct intel_dsb *dsb);