| Message ID | 20230606221418.296888-1-vinay.belgaumkar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t] tests/gem_ctx_persistence: Skip hang subtest with GuC | expand |
On 07.06.2023 00:14, Vinay Belgaumkar wrote: > Hang subtest is not supported with GuC submission enabled > > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> Maybe providing more specific explanation would be better. Sth like: GuC does not support dynamically configurable options, particularly hangcheck disabling/enabling. This is at least what I understood from internal bug tracker. I wonder if it shouldn't be done also on driver level. Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > tests/i915/gem_ctx_persistence.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c > index df9b1c491..d2558354e 100644 > --- a/tests/i915/gem_ctx_persistence.c > +++ b/tests/i915/gem_ctx_persistence.c > @@ -577,6 +577,8 @@ static void test_nohangcheck_hang(int i915, const intel_ctx_cfg_t *cfg) > int testable_engines = 0; > int dir; > > + igt_require(!gem_using_guc_submission(i915)); > + > cleanup(i915); > > /*
Hi Vinay, On 2023-06-06 at 15:14:18 -0700, Vinay Belgaumkar wrote: > Hang subtest is not supported with GuC submission enabled. This is Guc which do not support some operations, so please improve description, maybe use Andrzej suggestions ? Regards, Kamil > > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> > --- > tests/i915/gem_ctx_persistence.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c > index df9b1c491..d2558354e 100644 > --- a/tests/i915/gem_ctx_persistence.c > +++ b/tests/i915/gem_ctx_persistence.c > @@ -577,6 +577,8 @@ static void test_nohangcheck_hang(int i915, const intel_ctx_cfg_t *cfg) > int testable_engines = 0; > int dir; > > + igt_require(!gem_using_guc_submission(i915)); > + > cleanup(i915); > > /* > -- > 2.38.1 >
diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c index df9b1c491..d2558354e 100644 --- a/tests/i915/gem_ctx_persistence.c +++ b/tests/i915/gem_ctx_persistence.c @@ -577,6 +577,8 @@ static void test_nohangcheck_hang(int i915, const intel_ctx_cfg_t *cfg) int testable_engines = 0; int dir; + igt_require(!gem_using_guc_submission(i915)); + cleanup(i915); /*
Hang subtest is not supported with GuC submission enabled. Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> --- tests/i915/gem_ctx_persistence.c | 2 ++ 1 file changed, 2 insertions(+)