diff mbox series

[2/2] drm/i915: debug log when GMD ID indicates there's no display

Message ID 20230804084600.1005818-2-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server | expand

Commit Message

Jani Nikula Aug. 4, 2023, 8:46 a.m. UTC 
Debug log similar to the device id based identification of no display.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Luca Coelho Aug. 9, 2023, 4:27 p.m. UTC | #1 
On Fri, 2023-08-04 at 11:46 +0300, Jani Nikula wrote:
> Debug log similar to the device id based identification of no display.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 3d6a262e037f..e4837f6fc01f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -822,9 +822,10 @@ probe_gmdid_display(struct drm_i915_private *i915, u16 *ver, u16 *rel, u16 *step
>  	val = ioread32(addr);
>  	pci_iounmap(pdev, addr);
>  
> -	if (val == 0)
> -		/* Platform doesn't have display */
> +	if (val == 0) {
> +		drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
>  		return &no_display;
> +	}
>  
>  	*ver = REG_FIELD_GET(GMD_ID_ARCH_MASK, val);
>  	*rel = REG_FIELD_GET(GMD_ID_RELEASE_MASK, val);

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index 3d6a262e037f..e4837f6fc01f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -822,9 +822,10 @@  probe_gmdid_display(struct drm_i915_private *i915, u16 *ver, u16 *rel, u16 *step
 	val = ioread32(addr);
 	pci_iounmap(pdev, addr);
 
-	if (val == 0)
-		/* Platform doesn't have display */
+	if (val == 0) {
+		drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
 		return &no_display;
+	}
 
 	*ver = REG_FIELD_GET(GMD_ID_ARCH_MASK, val);
 	*rel = REG_FIELD_GET(GMD_ID_RELEASE_MASK, val);