| Message ID | 20230815201344.298573-1-gustavo.sousa@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/display: Remove unused POWER_DOMAIN_MASK | expand |
On Tue, Aug 15, 2023 at 05:13:44PM -0300, Gustavo Sousa wrote: > That macro became unused with commit 323286c81245 ("drm/i915: Move the > power domain->well mappings to intel_display_power_map.c"). > > Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 9e01054c2430..71d70bd9fd82 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -338,8 +338,6 @@ void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv, > mutex_unlock(&power_domains->lock); > } > > -#define POWER_DOMAIN_MASK (GENMASK_ULL(POWER_DOMAIN_NUM - 1, 0)) > - > static void __async_put_domains_mask(struct i915_power_domains *power_domains, > struct intel_power_domain_mask *mask) > { > -- > 2.41.0 >
On Tue, Aug 15, 2023 at 10:51:20PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: Remove unused POWER_DOMAIN_MASK > URL : https://patchwork.freedesktop.org/series/122478/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13523 -> Patchwork_122478v1 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_122478v1 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_122478v1, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/index.html > > Participating hosts (41 -> 40) > ------------------------------ > > Missing (1): fi-snb-2520m > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_122478v1: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_busy@busy@all-engines: > - bat-mtlp-8: [PASS][1] -> [DMESG-FAIL][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-mtlp-8/igt@gem_busy@busy@all-engines.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-mtlp-8/igt@gem_busy@busy@all-engines.html GPU hang; not related to this patch. Removing the unused macro has no functional change, and the code still compiles properly, so no need to get full CI shard results. Applied to drm-intel-next; thanks for the patch. Matt > > > Known issues > ------------ > > Here are the changes found in Patchwork_122478v1 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_huc_copy@huc-copy: > - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html > > * igt@gem_lmem_swapping@basic: > - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html > > * igt@i915_selftest@live@gt_heartbeat: > - fi-glk-j4005: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html > > * igt@i915_selftest@live@gt_mocs: > - bat-mtlp-8: [PASS][7] -> [DMESG-FAIL][8] ([i915#7059]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html > > * igt@i915_selftest@live@gt_pm: > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886] / [i915#7913]) > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html > > * igt@i915_selftest@live@requests: > - bat-mtlp-8: [PASS][10] -> [DMESG-FAIL][11] ([i915#8497]) > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-mtlp-8/igt@i915_selftest@live@requests.html > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-mtlp-8/igt@i915_selftest@live@requests.html > > * igt@i915_selftest@live@slpc: > - bat-rpls-2: NOTRUN -> [DMESG-WARN][12] ([i915#6367]) > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-rpls-2/igt@i915_selftest@live@slpc.html > - bat-mtlp-8: [PASS][13] -> [DMESG-WARN][14] ([i915#6367]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-mtlp-8/igt@i915_selftest@live@slpc.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-mtlp-8/igt@i915_selftest@live@slpc.html > > * igt@kms_chamelium_frames@hdmi-crc-fast: > - fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271]) +15 similar issues > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html > > * igt@kms_chamelium_hpd@common-hpd-after-suspend: > - bat-rpls-2: NOTRUN -> [SKIP][16] ([i915#7828]) > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html > > * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence: > - bat-dg2-11: NOTRUN -> [SKIP][17] ([i915#1845] / [i915#5354]) +2 similar issues > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html > > * igt@kms_pipe_crc_basic@suspend-read-crc: > - bat-rpls-2: NOTRUN -> [SKIP][18] ([i915#1845]) > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html > > > #### Possible fixes #### > > * igt@fbdev@eof: > - fi-kbl-soraka: [ABORT][19] -> [PASS][20] > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/fi-kbl-soraka/igt@fbdev@eof.html > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/fi-kbl-soraka/igt@fbdev@eof.html > > * igt@i915_selftest@live@requests: > - bat-mtlp-6: [DMESG-FAIL][21] ([i915#8497]) -> [PASS][22] > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-mtlp-6/igt@i915_selftest@live@requests.html > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-mtlp-6/igt@i915_selftest@live@requests.html > > * igt@i915_selftest@live@reset: > - bat-rpls-2: [ABORT][23] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][24] > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13523/bat-rpls-2/igt@i915_selftest@live@reset.html > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/bat-rpls-2/igt@i915_selftest@live@reset.html > > > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 > [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 > [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 > [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 > [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 > [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 > [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 > [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 > [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 > [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 > [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497 > > > Build changes > ------------- > > * Linux: CI_DRM_13523 -> Patchwork_122478v1 > > CI-20190529: 20190529 > CI_DRM_13523: f36c6b28e71c7e471027cada71eb9d1cb6bd8f69 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_7436: 81e08c6d648e949df161a4f39118ed3eb1e354e9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_122478v1: f36c6b28e71c7e471027cada71eb9d1cb6bd8f69 @ git://anongit.freedesktop.org/gfx-ci/linux > > > ### Linux commits > > eebf68ff2848 drm/i915/display: Remove unused POWER_DOMAIN_MASK > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122478v1/index.html
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index 9e01054c2430..71d70bd9fd82 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -338,8 +338,6 @@ void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv, mutex_unlock(&power_domains->lock); } -#define POWER_DOMAIN_MASK (GENMASK_ULL(POWER_DOMAIN_NUM - 1, 0)) - static void __async_put_domains_mask(struct i915_power_domains *power_domains, struct intel_power_domain_mask *mask) {
That macro became unused with commit 323286c81245 ("drm/i915: Move the power domain->well mappings to intel_display_power_map.c"). Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 -- 1 file changed, 2 deletions(-)