diff mbox series

[i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3

Message ID 20230830233836.477940-1-vinay.belgaumkar@intel.com (mailing list archive)
State New, archived
Headers show
Series [i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3 | expand

Commit Message

Vinay Belgaumkar Aug. 30, 2023, 11:38 p.m. UTC
Test skips whenever S3 is not supported, use s2idle instead, which is
widely enabled.

Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/i915/i915_pm_freq_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Riana Tauro Aug. 31, 2023, 12:09 p.m. UTC | #1
On 8/31/2023 5:08 AM, Vinay Belgaumkar wrote:
> Test skips whenever S3 is not supported, use s2idle instead, which is
> widely enabled.
> 
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   tests/i915/i915_pm_freq_api.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c
> index 2912287c4..03bd0d05b 100644
> --- a/tests/i915/i915_pm_freq_api.c
> +++ b/tests/i915/i915_pm_freq_api.c
> @@ -125,7 +125,7 @@ static void test_suspend(int i915, int dirfd, int gt)
>   		igt_assert_eq(req_freq, rpn);
>   
>   	/* Manually trigger a suspend */
> -	igt_system_suspend_autoresume(SUSPEND_STATE_S3,
> +	igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE,
>   				      SUSPEND_TEST_NONE);
>   
>   	req_freq = get_freq(dirfd, RPS_CUR_FREQ_MHZ);
Gupta, Anshuman Aug. 31, 2023, 3:46 p.m. UTC | #2
> -----Original Message-----
> From: Belgaumkar, Vinay <vinay.belgaumkar@intel.com>
> Sent: Thursday, August 31, 2023 5:09 AM
> To: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
> Cc: Belgaumkar, Vinay <vinay.belgaumkar@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>
> Subject: [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3
> 
> Test skips whenever S3 is not supported, use s2idle instead, which is widely
> enabled.
> 
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_freq_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c
> index 2912287c4..03bd0d05b 100644
> --- a/tests/i915/i915_pm_freq_api.c
> +++ b/tests/i915/i915_pm_freq_api.c
> @@ -125,7 +125,7 @@ static void test_suspend(int i915, int dirfd, int gt)
>  		igt_assert_eq(req_freq, rpn);
> 
>  	/* Manually trigger a suspend */
> -	igt_system_suspend_autoresume(SUSPEND_STATE_S3,
> +	igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE,
>  				      SUSPEND_TEST_NONE);
> 
>  	req_freq = get_freq(dirfd, RPS_CUR_FREQ_MHZ);
> --
> 2.38.1
diff mbox series

Patch

diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c
index 2912287c4..03bd0d05b 100644
--- a/tests/i915/i915_pm_freq_api.c
+++ b/tests/i915/i915_pm_freq_api.c
@@ -125,7 +125,7 @@  static void test_suspend(int i915, int dirfd, int gt)
 		igt_assert_eq(req_freq, rpn);
 
 	/* Manually trigger a suspend */
-	igt_system_suspend_autoresume(SUSPEND_STATE_S3,
+	igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE,
 				      SUSPEND_TEST_NONE);
 
 	req_freq = get_freq(dirfd, RPS_CUR_FREQ_MHZ);