diff mbox series

[v3,2/5] drm/kmb: add trailing newlines to drm_dbg msgs

Message ID 20230906190224.583577-3-jim.cromie@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm/drm_dbg: add trailing newlines where missing | expand

Commit Message

Jim Cromie Sept. 6, 2023, 7:02 p.m. UTC
By at least strong convention, a print-buffer's trailing newline says
"message complete, send it".  The exception (no TNL, followed by a call
to pr_cont) proves the general rule.

Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
1288 drm_dbg.  Clean up the remainders, in maintainer sized chunks.

No functional changes.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 drivers/gpu/drm/kmb/kmb_crtc.c  | 10 +++++-----
 drivers/gpu/drm/kmb/kmb_plane.c |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Chrisanthus, Anitha Sept. 7, 2023, 12:12 a.m. UTC | #1
Acked-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

> -----Original Message-----
> From: Jim Cromie <jim.cromie@gmail.com>
> Sent: Wednesday, September 6, 2023 12:02 PM
> To: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-
> gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; intel-
> gfx@lists.freedesktop.org
> Cc: daniel.vetter@ffwll.ch; daniel@ffwll.ch; Nikula, Jani
> <jani.nikula@intel.com>; ville.syrjala@linux.intel.com;
> seanpaul@chromium.org; robdclark@gmail.com; Jim Cromie
> <jim.cromie@gmail.com>; Chrisanthus, Anitha
> <anitha.chrisanthus@intel.com>; Edmund Dea <edmund.j.dea@intel.com>;
> David Airlie <airlied@gmail.com>
> Subject: [PATCH v3 2/5] drm/kmb: add trailing newlines to drm_dbg msgs
> 
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it".  The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
> 
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg.  Clean up the remainders, in maintainer sized chunks.
> 
> No functional changes.
> 
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
>  drivers/gpu/drm/kmb/kmb_crtc.c  | 10 +++++-----
>  drivers/gpu/drm/kmb/kmb_plane.c |  6 +++---
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c
> b/drivers/gpu/drm/kmb/kmb_crtc.c
> index 647872f65bff..a58baf25322d 100644
> --- a/drivers/gpu/drm/kmb/kmb_crtc.c
> +++ b/drivers/gpu/drm/kmb/kmb_crtc.c
> @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc,
>  	vm.hback_porch = 0;
>  	vm.hsync_len = 28;
> 
> -	drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d
> h-active=%d h-bp=%d h-fp=%d hsync-l=%d",
> +	drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d
> h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n",
>  		__func__, __LINE__,
>  			m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch,
>  			vm.vsync_len, m->crtc_hdisplay, vm.hback_porch,
> @@ -194,24 +194,24 @@ static enum drm_mode_status
>  	int vfp = mode->vsync_start - mode->vdisplay;
> 
>  	if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) {
> -		drm_dbg(dev, "height = %d less than %d",
> +		drm_dbg(dev, "height = %d less than %d\n",
>  			mode->vdisplay, KMB_CRTC_MAX_HEIGHT);
>  		return MODE_BAD_VVALUE;
>  	}
>  	if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) {
> -		drm_dbg(dev, "width = %d less than %d",
> +		drm_dbg(dev, "width = %d less than %d\n",
>  			mode->hdisplay, KMB_CRTC_MAX_WIDTH);
>  		return MODE_BAD_HVALUE;
>  	}
>  	refresh = drm_mode_vrefresh(mode);
>  	if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) {
> -		drm_dbg(dev, "refresh = %d less than %d or greater than %d",
> +		drm_dbg(dev, "refresh = %d less than %d or greater than
> %d\n",
>  			refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH);
>  		return MODE_BAD;
>  	}
> 
>  	if (vfp < KMB_CRTC_MIN_VFP) {
> -		drm_dbg(dev, "vfp = %d less than %d", vfp,
> KMB_CRTC_MIN_VFP);
> +		drm_dbg(dev, "vfp = %d less than %d\n", vfp,
> KMB_CRTC_MIN_VFP);
>  		return MODE_BAD;
>  	}
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_plane.c
> b/drivers/gpu/drm/kmb/kmb_plane.c
> index 9e0562aa2bcb..308bd1cb50c8 100644
> --- a/drivers/gpu/drm/kmb/kmb_plane.c
> +++ b/drivers/gpu/drm/kmb/kmb_plane.c
> @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane
> *plane, u32 format)
>  	 * plane configuration is not supported.
>  	 */
>  	if (init_disp_cfg.format && init_disp_cfg.format != format) {
> -		drm_dbg(&kmb->drm, "Cannot change format after initial
> plane configuration");
> +		drm_dbg(&kmb->drm, "Cannot change format after initial
> plane configuration\n");
>  		return -EINVAL;
>  	}
>  	for (i = 0; i < plane->format_count; i++) {
> @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane
> *plane,
>  	if ((init_disp_cfg.width && init_disp_cfg.height) &&
>  	    (init_disp_cfg.width != fb->width ||
>  	    init_disp_cfg.height != fb->height)) {
> -		drm_dbg(&kmb->drm, "Cannot change plane height or width
> after initial configuration");
> +		drm_dbg(&kmb->drm, "Cannot change plane height or width
> after initial configuration\n");
>  		return -EINVAL;
>  	}
>  	can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY);
> @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct
> drm_plane *plane,
>  	spin_lock_irq(&kmb->irq_lock);
>  	if (kmb->kmb_under_flow || kmb->kmb_flush_done) {
>  		spin_unlock_irq(&kmb->irq_lock);
> -		drm_dbg(&kmb->drm, "plane_update:underflow!!!!
> returning");
> +		drm_dbg(&kmb->drm, "plane_update:underflow!!!!
> returning\n");
>  		return;
>  	}
>  	spin_unlock_irq(&kmb->irq_lock);
> --
> 2.41.0
diff mbox series

Patch

diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c
index 647872f65bff..a58baf25322d 100644
--- a/drivers/gpu/drm/kmb/kmb_crtc.c
+++ b/drivers/gpu/drm/kmb/kmb_crtc.c
@@ -94,7 +94,7 @@  static void kmb_crtc_set_mode(struct drm_crtc *crtc,
 	vm.hback_porch = 0;
 	vm.hsync_len = 28;
 
-	drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d",
+	drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n",
 		__func__, __LINE__,
 			m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch,
 			vm.vsync_len, m->crtc_hdisplay, vm.hback_porch,
@@ -194,24 +194,24 @@  static enum drm_mode_status
 	int vfp = mode->vsync_start - mode->vdisplay;
 
 	if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) {
-		drm_dbg(dev, "height = %d less than %d",
+		drm_dbg(dev, "height = %d less than %d\n",
 			mode->vdisplay, KMB_CRTC_MAX_HEIGHT);
 		return MODE_BAD_VVALUE;
 	}
 	if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) {
-		drm_dbg(dev, "width = %d less than %d",
+		drm_dbg(dev, "width = %d less than %d\n",
 			mode->hdisplay, KMB_CRTC_MAX_WIDTH);
 		return MODE_BAD_HVALUE;
 	}
 	refresh = drm_mode_vrefresh(mode);
 	if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) {
-		drm_dbg(dev, "refresh = %d less than %d or greater than %d",
+		drm_dbg(dev, "refresh = %d less than %d or greater than %d\n",
 			refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH);
 		return MODE_BAD;
 	}
 
 	if (vfp < KMB_CRTC_MIN_VFP) {
-		drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP);
+		drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP);
 		return MODE_BAD;
 	}
 
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index 9e0562aa2bcb..308bd1cb50c8 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -78,7 +78,7 @@  static unsigned int check_pixel_format(struct drm_plane *plane, u32 format)
 	 * plane configuration is not supported.
 	 */
 	if (init_disp_cfg.format && init_disp_cfg.format != format) {
-		drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration");
+		drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n");
 		return -EINVAL;
 	}
 	for (i = 0; i < plane->format_count; i++) {
@@ -124,7 +124,7 @@  static int kmb_plane_atomic_check(struct drm_plane *plane,
 	if ((init_disp_cfg.width && init_disp_cfg.height) &&
 	    (init_disp_cfg.width != fb->width ||
 	    init_disp_cfg.height != fb->height)) {
-		drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration");
+		drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n");
 		return -EINVAL;
 	}
 	can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY);
@@ -375,7 +375,7 @@  static void kmb_plane_atomic_update(struct drm_plane *plane,
 	spin_lock_irq(&kmb->irq_lock);
 	if (kmb->kmb_under_flow || kmb->kmb_flush_done) {
 		spin_unlock_irq(&kmb->irq_lock);
-		drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning");
+		drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n");
 		return;
 	}
 	spin_unlock_irq(&kmb->irq_lock);