| Message ID | 20230927151839.319008-1-andi.shyti@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC] drm/i915/gt: Apply Workaround 22016122933 to all the GT's | expand |
On Wed, Sep 27, 2023 at 05:18:39PM +0200, Andi Shyti wrote: > From: Nirmoy Das <nirmoy.das@intel.com> > > Commit f1530f912ed8 ("drm/i915/gt: Apply workaround 22016122933 > correctly") adds the workaround only in non media GT's, which is This is backwards; the workaround is applied only to the media GT and not to the primary GT. > GT-0 in case of MTL. It turns out that we need to apply it in > both the GT's. The workaround database indicates this should only applied to the media IP, not to the render IP, and the internal details further confirm that this is not necessary on the primary GT. Is there some other workaround (with a different lineage number) that asks us to do the same thing on the primary GT? Matt > > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > index 93062c35e072..7f7af1d4dc10 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -1022,5 +1022,5 @@ enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > > bool intel_gt_needs_wa_22016122933(struct intel_gt *gt) > { > - return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0) && gt->type == GT_MEDIA; > + return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0); > } > -- > 2.40.1 >
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 93062c35e072..7f7af1d4dc10 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1022,5 +1022,5 @@ enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, bool intel_gt_needs_wa_22016122933(struct intel_gt *gt) { - return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0) && gt->type == GT_MEDIA; + return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0); }