| Message ID | 20231002122032.23703-1-nirmoy.das@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Invalidate all GTs in flush_tlb_invalidate() | expand |
Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: > Don't return early if one of the GT doesn't require > any flushing. > > Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") > Cc: Chris Wilson <chris.p.wilson@linux.intel.com> > Cc: Fei Yang <fei.yang@intel.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: Nirmoy Das <nirmoy.das@intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > Cc: Andrzej Hajda <andrzej.hajda@intel.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> This patch has been sent already here: https://patchwork.freedesktop.org/patch/560309/?series=124472&rev=1 Can we take it from there? Andi
Hi Andi, On 10/2/2023 3:45 PM, Andi Shyti wrote: > Hi Nirmoy, > > On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: >> Don't return early if one of the GT doesn't require >> any flushing. >> >> Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") >> Cc: Chris Wilson <chris.p.wilson@linux.intel.com> >> Cc: Fei Yang <fei.yang@intel.com> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >> Cc: Andi Shyti <andi.shyti@linux.intel.com> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >> Cc: Nirmoy Das <nirmoy.das@intel.com> >> Cc: Matthew Auld <matthew.auld@intel.com> >> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com> >> Cc: "Christian König" <christian.koenig@amd.com> >> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> >> Cc: Matt Roper <matthew.d.roper@intel.com> >> Cc: intel-gfx@lists.freedesktop.org >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > This patch has been sent already here: > > https://patchwork.freedesktop.org/patch/560309/?series=124472&rev=1 > > Can we take it from there? Missed it. Sure, works for me. Thanks, Nirmoy > > Andi
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c index 6b6d22c19411..0ba955611dfb 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c @@ -198,7 +198,7 @@ static void flush_tlb_invalidate(struct drm_i915_gem_object *obj) for_each_gt(gt, i915, id) { if (!obj->mm.tlb[id]) - return; + continue; intel_gt_invalidate_tlb_full(gt, obj->mm.tlb[id]); obj->mm.tlb[id] = 0;
Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson <chris.p.wilson@linux.intel.com> Cc: Fei Yang <fei.yang@intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Andi Shyti <andi.shyti@linux.intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Nirmoy Das <nirmoy.das@intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)