| Message ID | 20231008164824.919262-1-andi.shyti@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake | expand |
On 08/10/2023 17:48, Andi Shyti wrote: > From: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > Meteor Lake has demonstrated consistent stability for some time. > All user-space API modifications tide to its core platform > functions are operational. > > The necessary firmware components are set up and comprehensive > testing has been condused over a period. > > Given the recent faborable CI results, as well, we believe it's > time to eliminate the 'force_probe' prerequisite and activate the > platform by default. > > Signed-off-by: Aditya Chauhan <aditya.chauhan@intel.com> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > Hello, > > This patch eliminates the 'force probe' for the MTL platforms. Over the recent > weeks, MTL has demonstrated stability, consistently passing BAT tests with > success rates ranging from 98% to 100%. > > There's a single issue hindering us from achieving a 100% BAT test coverage. > Fortunately, we've identified the issue, and the proposed solution can be found > here[*]. The CI results are encouraging. > > Once all reviews are addressed, we plan to submit this series with the "Fixes:" > tag. > > Thank you and best regards, > Andi and Radhakrishna > > [*] https://patchwork.freedesktop.org/series/124744/ Have there been any more recent developments, given https://patchwork.freedesktop.org/series/124866/, or proposal is still to remove force probe? Regards, Tvrtko > > drivers/gpu/drm/i915/i915_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index df7c261410f7..fe748906c06f 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = { > .has_pxp = 1, > .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, > .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0), > - .require_force_probe = 1, > MTL_CACHELEVEL, > }; >
Hi Tvrtko, > > Meteor Lake has demonstrated consistent stability for some time. > > All user-space API modifications tide to its core platform > > functions are operational. > > > > The necessary firmware components are set up and comprehensive > > testing has been condused over a period. > > > > Given the recent faborable CI results, as well, we believe it's > > time to eliminate the 'force_probe' prerequisite and activate the > > platform by default. > > > > Signed-off-by: Aditya Chauhan <aditya.chauhan@intel.com> > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com> > > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > --- > > Hello, > > > > This patch eliminates the 'force probe' for the MTL platforms. Over the recent > > weeks, MTL has demonstrated stability, consistently passing BAT tests with > > success rates ranging from 98% to 100%. > > > > There's a single issue hindering us from achieving a 100% BAT test coverage. > > Fortunately, we've identified the issue, and the proposed solution can be found > > here[*]. The CI results are encouraging. > > > > Once all reviews are addressed, we plan to submit this series with the "Fixes:" > > tag. > > > > Thank you and best regards, > > Andi and Radhakrishna > > > > [*] https://patchwork.freedesktop.org/series/124744/ > > Have there been any more recent developments, given > https://patchwork.freedesktop.org/series/124866/, or proposal is still to > remove force probe? I think that patch is functional to the force_probe removal because it would have been the fix we needed in order to have a full 100% green CI results. But unfortunately, the patch doesn't fix it. I think the GuC TLB invalidation is still the best fix. Andi
Hi Shawn, On Wed, Oct 11, 2023 at 10:03:08AM +0200, Lee, Shawn C wrote: > > From: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > > > Meteor Lake has demonstrated consistent stability for some time. > > All user-space API modifications tide to its core platform > > functions are operational. > > > > The necessary firmware components are set up and comprehensive > > testing has been condused over a period. > > > > Given the recent faborable CI results, as well, we believe it's > > time to eliminate the 'force_probe' prerequisite and activate the > > platform by default. > > > > Signed-off-by: Aditya Chauhan <aditya.chauhan@intel.com> > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com> > > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > --- > > Hello, > > > > This patch eliminates the 'force probe' for the MTL platforms. Over the recent > > weeks, MTL has demonstrated stability, consistently passing BAT tests with > > success rates ranging from 98% to 100%. > > > > There's a single issue hindering us from achieving a 100% BAT test coverage. > > Fortunately, we've identified the issue, and the proposed solution can be found > > here[*]. The CI results are encouraging. > > > > Once all reviews are addressed, we plan to submit this series with the "Fixes:" > > tag. > > > > Thank you and best regards, > > Andi and Radhakrishna > > > > [*] https://patchwork.freedesktop.org/series/124744/ > > > > drivers/gpu/drm/i915/i915_pci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > > index df7c261410f7..fe748906c06f 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = { > > .has_pxp = 1, > > .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, > > .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0), > > - .require_force_probe = 1, > > MTL_CACHELEVEL, > > }; > > > > Test on my MTL device and it works properly. > > Acked-by: Lee Shawn C <shawn.c.lee@intel.com> > Tested-by: Lee Shawn C <shawn.c.lee@intel.com> Thanks a lot for your ack! In your original mail[*] the "Reply-To" and the "In-Reply-To" fields were swapped. I fixed it and added the correct Cc chain. Thanks, Andi [*] https://lore.kernel.org/intel-gfx/BYAPR11MB27101EF88CCBDBA430108CD5A3CCA@BYAPR11MB2710.namprd11.prod.outlook.com/
Hi, On 10/8/2023 10:18 PM, Andi Shyti wrote: > From: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > Meteor Lake has demonstrated consistent stability for some time. > All user-space API modifications tide to its core platform > functions are operational. > > The necessary firmware components are set up and comprehensive > testing has been condused over a period. > > Given the recent faborable CI results, as well, we believe it's > time to eliminate the 'force_probe' prerequisite and activate the > platform by default. > > Signed-off-by: Aditya Chauhan <aditya.chauhan@intel.com> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Verified with the latest drmtip(CI_DRM_13736) on eDP+HDMI config on MTL. System is booting seamlessly into Ubuntu UI and played around with a few display settings as well.(Single display, clone and extended modes). Also tried hot-unplug and plug for the HDMI and is working as expected. Basic video playback was also verified on both eDP and HDMI. Tested-by: Karthik B S <karthik.b.s@intel.com> > --- > Hello, > > This patch eliminates the 'force probe' for the MTL platforms. Over the recent > weeks, MTL has demonstrated stability, consistently passing BAT tests with > success rates ranging from 98% to 100%. > > There's a single issue hindering us from achieving a 100% BAT test coverage. > Fortunately, we've identified the issue, and the proposed solution can be found > here[*]. The CI results are encouraging. > > Once all reviews are addressed, we plan to submit this series with the "Fixes:" > tag. > > Thank you and best regards, > Andi and Radhakrishna > > [*] https://patchwork.freedesktop.org/series/124744/ > > drivers/gpu/drm/i915/i915_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index df7c261410f7..fe748906c06f 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = { > .has_pxp = 1, > .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, > .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0), > - .require_force_probe = 1, > MTL_CACHELEVEL, > }; >
Hi, > Meteor Lake has demonstrated consistent stability for some time. > All user-space API modifications tide to its core platform > functions are operational. > > The necessary firmware components are set up and comprehensive > testing has been condused over a period. > > Given the recent faborable CI results, as well, we believe it's > time to eliminate the 'force_probe' prerequisite and activate the > platform by default. > > Signed-off-by: Aditya Chauhan <aditya.chauhan@intel.com> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > Signed-off-by: Chris Wilson <chris.p.wilson@linux.intel.com> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> merged in drm-intel-next. Thanks everyone for this effort! > --- > Hello, > > This patch eliminates the 'force probe' for the MTL platforms. Over the recent > weeks, MTL has demonstrated stability, consistently passing BAT tests with > success rates ranging from 98% to 100%. > > There's a single issue hindering us from achieving a 100% BAT test coverage. > Fortunately, we've identified the issue, and the proposed solution can be found > here[*]. The CI results are encouraging. > > Once all reviews are addressed, we plan to submit this series with the "Fixes:" > tag. > > Thank you and best regards, > Andi and Radhakrishna > > [*] https://patchwork.freedesktop.org/series/124744/ The fix has been just applied. Thanks, Andi
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index df7c261410f7..fe748906c06f 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = { .has_pxp = 1, .memory_regions = REGION_SMEM | REGION_STOLEN_LMEM, .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0), - .require_force_probe = 1, MTL_CACHELEVEL, };