| Message ID | 20231024130448.576297-2-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915: fix Makefile sort and indent | expand |
On 10/24/2023 3:04 PM, Jani Nikula wrote: > Keep the display build lists together. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/Makefile | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index bc785dd89c19..e92682424915 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -95,9 +95,7 @@ i915-$(CONFIG_COMPAT) += \ > i915_ioc32.o > i915-$(CONFIG_DEBUG_FS) += \ > i915_debugfs.o \ > - i915_debugfs_params.o \ > - display/intel_display_debugfs.o \ > - display/intel_pipe_crc.o > + i915_debugfs_params.o > i915-$(CONFIG_PERF_EVENTS) += \ > i915_pmu.o > > @@ -318,6 +316,9 @@ i915-$(CONFIG_ACPI) += \ > display/intel_opregion.o > i915-$(CONFIG_DRM_FBDEV_EMULATION) += \ > display/intel_fbdev.o > +i915-$(CONFIG_DEBUG_FS) += \ > + display/intel_display_debugfs.o \ > + display/intel_pipe_crc.o From a quick look, I am not sure how this file is related to debugfs. I will try to find out but that is unrelated to this patch so Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> > > # modesetting output/encoder code > i915-y += \
On Wed, 25 Oct 2023, Nirmoy Das <nirmoy.das@linux.intel.com> wrote: > On 10/24/2023 3:04 PM, Jani Nikula wrote: >> Keep the display build lists together. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/Makefile | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile >> index bc785dd89c19..e92682424915 100644 >> --- a/drivers/gpu/drm/i915/Makefile >> +++ b/drivers/gpu/drm/i915/Makefile >> @@ -95,9 +95,7 @@ i915-$(CONFIG_COMPAT) += \ >> i915_ioc32.o >> i915-$(CONFIG_DEBUG_FS) += \ >> i915_debugfs.o \ >> - i915_debugfs_params.o \ >> - display/intel_display_debugfs.o \ >> - display/intel_pipe_crc.o >> + i915_debugfs_params.o >> i915-$(CONFIG_PERF_EVENTS) += \ >> i915_pmu.o >> >> @@ -318,6 +316,9 @@ i915-$(CONFIG_ACPI) += \ >> display/intel_opregion.o >> i915-$(CONFIG_DRM_FBDEV_EMULATION) += \ >> display/intel_fbdev.o >> +i915-$(CONFIG_DEBUG_FS) += \ >> + display/intel_display_debugfs.o \ >> + display/intel_pipe_crc.o > > From a quick look, I am not sure how this file is related to debugfs. I > will try to find out but that is The pipe crc is only available via drm debugfs. > > unrelated to this patch so > > Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Thanks, Jani. > >> >> # modesetting output/encoder code >> i915-y += \
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index bc785dd89c19..e92682424915 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -95,9 +95,7 @@ i915-$(CONFIG_COMPAT) += \ i915_ioc32.o i915-$(CONFIG_DEBUG_FS) += \ i915_debugfs.o \ - i915_debugfs_params.o \ - display/intel_display_debugfs.o \ - display/intel_pipe_crc.o + i915_debugfs_params.o i915-$(CONFIG_PERF_EVENTS) += \ i915_pmu.o @@ -318,6 +316,9 @@ i915-$(CONFIG_ACPI) += \ display/intel_opregion.o i915-$(CONFIG_DRM_FBDEV_EMULATION) += \ display/intel_fbdev.o +i915-$(CONFIG_DEBUG_FS) += \ + display/intel_display_debugfs.o \ + display/intel_pipe_crc.o # modesetting output/encoder code i915-y += \
Keep the display build lists together. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)