From patchwork Wed Oct 25 14:13:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 13436261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60530C07545 for ; Wed, 25 Oct 2023 14:14:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6B7410E66B; Wed, 25 Oct 2023 14:14:02 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E09EA10E662 for ; Wed, 25 Oct 2023 14:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698243240; x=1729779240; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=MaIIC5+jLotuZfswE6jbxOhim++eaDpNW2KNVSpJeug=; b=drLmNvewqqE6GUwwmYBlG8B8FeyZO/HfMk/3g1R0hYgIJ3ASYHpPBxd0 RgeFDY7xYAQWpWKP+HRvmLBdZPwhjd9CqB2bzlUQHZ9Do/wU0Pzq2/hSH DdwAI09MS6aqetS6Lb7ZVPeZP96rc1AUEz7kPqBWBfSqR/TApmmaty7Iz D7eMXalFQoT0G5vA235HfFDNfOKr/aYs+uaMd17ElvlCgg97pEXjtfksS Hjdqe/UonQLMN7By6A34WI3dz6SE0mflLBY3i+cSRY5nR+ZxgL6SzX3MU chtZcw9M3/DSRdoUSTACIGPZBwrYfI+A3TACi3rhp8/6EN/sEKIbaocgM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="372367150" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="372367150" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 07:14:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="882458751" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="882458751" Received: from lab-ah.igk.intel.com ([10.102.138.202]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 07:13:59 -0700 From: Andrzej Hajda Date: Wed, 25 Oct 2023 16:13:43 +0200 MIME-Version: 1.0 Message-Id: <20231025-wabb-v5-4-398e42309e9d@intel.com> References: <20231025-wabb-v5-0-398e42309e9d@intel.com> In-Reply-To: <20231025-wabb-v5-0-398e42309e9d@intel.com> To: intel-gfx@lists.freedesktop.org X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=andrzej.hajda@intel.com; h=from:subject:message-id; bh=9gE7Hw27KBcB9MG25aFN/4oXxak8vUVcOmAtGhnJbio=; b=owEB7QES/pANAwAKASNispPeEP3XAcsmYgBlOSKeoVb2Fs7Nd1q/c1Jp/3W8VYA9VEMQMqUi/woJ x76rxYCJAbMEAAEKAB0WIQT8qEQxNN2/XeF/A00jYrKT3hD91wUCZTkingAKCRAjYrKT3hD918tJC/ sFfqUIiyS1ld6LduCf+9YZslcVhU2u/cUvlh5xSl38gSnuSGDjnq+fdcyGW+oXX5N0ni296VkVEvob pYHDKsKyuOAx5umtmxcL7IqmZl7n0KrI7oG8tHDvPOhr3hAwVRexBpi45Yi0KEWa6eaBbhWlOfMoWL b6yLZ4A7wJng+yI3RBH51JLpHaEiPhwiFSiMrWok07lOjzMbHsUsBvwx2b1BXoy1aGW/zzCN+AAT6S VMudMyBiTEZW7s8hVEtZSJfKKVFXO5LLlSKJkJN1bY7V1AsvQwf3k64uWLAjHcduEqLSjgWo07PuYA a1XV1xoaI9UJa4whT4V834Ncn4dg0/caGNxuN7AXPgjvoUKeh2PWu/297mfYcJX/tmrcskAMJQtIEW QDAlmJiqI3C3O1Ms+0L5wwgnVzfkzP3wHCynMuZQd1whNLajjSahdhmOo+V5i51a2DTu2fpjs00y7p IotlCxpMWI5pN4qFGIVv/qpUEi74rce9tRjLZ92LX7aAQ= X-Developer-Key: i=andrzej.hajda@intel.com; a=openpgp; fpr=FCA8443134DDBF5DE17F034D2362B293DE10FDD7 Subject: [Intel-gfx] [PATCH v5 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Cavitt , Andrzej Hajda , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_regs.h b/drivers/gpu/drm/i915/gt/intel_engine_regs.h index b8618ee3e3041a..c0c8c12edea104 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_regs.h +++ b/drivers/gpu/drm/i915/gt/intel_engine_regs.h @@ -124,6 +124,9 @@ #define RING_INDIRECT_CTX(base) _MMIO((base) + 0x1c4) /* gen8+ */ #define RING_INDIRECT_CTX_OFFSET(base) _MMIO((base) + 0x1c8) /* gen8+ */ #define ECOSKPD(base) _MMIO((base) + 0x1d0) +#define XEHP_BLITTER_SCHEDULING_MODE_MASK REG_GENMASK(12, 11) +#define XEHP_BLITTER_ROUND_ROBIN_MODE \ + REG_FIELD_PREP(XEHP_BLITTER_SCHEDULING_MODE_MASK, 1) #define ECO_CONSTANT_BUFFER_SR_DISABLE REG_BIT(4) #define ECO_GATING_CX_ONLY REG_BIT(3) #define GEN6_BLITTER_FBC_NOTIFY REG_BIT(3) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 192ac0e59afa13..108d9326735910 100644 --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -2782,6 +2782,11 @@ xcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) RING_SEMA_WAIT_POLL(engine->mmio_base), 1); } + /* Wa_16018031267, Wa_16018063123 */ + if (NEEDS_FASTCOLOR_BLT_WABB(engine)) + wa_masked_field_set(wal, ECOSKPD(engine->mmio_base), + XEHP_BLITTER_SCHEDULING_MODE_MASK, + XEHP_BLITTER_ROUND_ROBIN_MODE); } static void