diff mbox series

[v2] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions

Message ID 20231130231510.221143-1-khaled.almahallawy@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions | expand

Commit Message

Almahallawy, Khaled Nov. 30, 2023, 11:15 p.m. UTC
DP2.1 Specs added new DPCDs definitions for square pattern configs[1]
These new definitions are used for UHBR Source Transmitter
Equalizations tests[2]. Add the 3 new values for square pattern.

v2: rebase

[1]: DP2.1 Specs - 2.12.3.6.5 Square Pattern
[2]: DP2.1 PHY CTS specs - 4.3 UHBR Source Transmitter Equalization

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
---
 include/drm/display/drm_dp.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Almahallawy, Khaled Dec. 1, 2023, 7:52 p.m. UTC | #1
On Fri, 2023-12-01 at 03:34 +0000, Patchwork wrote:
> Patch Details
> Series:	drm/display/dp: Add the remaining Square PHY patterns
> DPCD register definitions (rev2)
> URL:	https://patchwork.freedesktop.org/series/123149/
> State:	failure
> Details:	
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123149v2/index.html
> CI Bug Log - changes from CI_DRM_13956 -> Patchwork_123149v2
> Summary
> FAILURE
> 
> Serious unknown changes coming with Patchwork_123149v2 absolutely
> need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_123149v2, please notify your bug team (
> I915-ci-infra@lists.freedesktop.org) to allow them
> to document this new failure mode, which will reduce false positives
> in CI.
> 
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123149v2/index.html
> 
> Participating hosts (39 -> 38)
> Additional (1): bat-dg2-8 
> Missing (2): fi-snb-2520m fi-bsw-n3050
> 
> Possible new issues
> Here are the unknown changes that may have been introduced in
> Patchwork_123149v2:
> 
> IGT changes
> Possible regressions
> igt@i915_selftest@live@execlists:
> bat-atsm-1: PASS -> INCOMPLETE

This patch has no functional changes. It is just adds 3 defs will be
used later. The failures/incomplete is not caused by this patch.

Could you please report?

Thanks
khaled

> Known issues
> Here are the changes found in Patchwork_123149v2 that come from known
> issues:
> 
> IGT changes
> Issues hit
> igt@gem_lmem_swapping@basic:
> 
> fi-apl-guc: NOTRUN -> SKIP (fdo#109271 / i915#4613) +3 other tests
> skip
> igt@gem_mmap@basic:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4083)
> igt@gem_mmap_gtt@basic:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4077) +2 other tests skip
> igt@gem_tiled_pread_basic:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4079) +1 other test skip
> igt@i915_pm_rps@basic-api:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#6621)
> igt@i915_selftest@live@mman:
> 
> bat-rpls-1: PASS -> TIMEOUT (i915#6794 / i915#7392)
> igt@i915_suspend@basic-s2idle-without-i915:
> 
> bat-rpls-1: PASS -> WARN (i915#8747)
> igt@i915_suspend@basic-s3-without-i915:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#6645)
> igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#5190)
> igt@kms_addfb_basic@basic-y-tiled-legacy:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4215 / i915#5190)
> igt@kms_addfb_basic@framebuffer-vs-set-tiling:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4212) +6 other tests skip
> igt@kms_addfb_basic@tile-pitch-mismatch:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4212 / i915#5608)
> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#4103 / i915#4213 / i915#5608) +1
> other test skip
> igt@kms_force_connector_basic@force-load-detect:
> 
> bat-dg2-8: NOTRUN -> SKIP (fdo#109285)
> igt@kms_force_connector_basic@prune-stale-modes:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#5274)
> igt@kms_hdmi_inject@inject-audio:
> 
> fi-kbl-guc: PASS -> FAIL (IGT#3)
> igt@kms_pipe_crc_basic@nonblocking-crc:
> 
> bat-dg2-11: NOTRUN -> SKIP (i915#1845 / i915#9197)
> igt@kms_pipe_crc_basic@suspend-read-crc:
> 
> bat-rpls-1: NOTRUN -> SKIP (i915#1845)
> igt@kms_setmode@basic-clone-single-crtc:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#3555 / i915#4098)
> igt@prime_vgem@basic-fence-flip:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#3708)
> igt@prime_vgem@basic-fence-mmap:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#3708 / i915#4077) +1 other test skip
> igt@prime_vgem@basic-write:
> 
> bat-dg2-8: NOTRUN -> SKIP (i915#3291 / i915#3708) +2 other tests skip
> Possible fixes
> igt@core_hotunplug@unbind-rebind:
> 
> fi-apl-guc: ABORT (i915#8213 / i915#8668) -> PASS
> igt@gem_exec_suspend@basic-s3@smem:
> 
> bat-rpls-1: ABORT (i915#7978) -> PASS
> {name}: This element is suppressed. This means it is ignored when
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> Build changes
> Linux: CI_DRM_13956 -> Patchwork_123149v2
> CI-20190529: 20190529
> CI_DRM_13956: b59a0a6520764f36a79ba6b4c590e243ac6b913d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7612: b5c47966901ee1060bcb9d4bccdd3ccec9651ef4 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_123149v2: b59a0a6520764f36a79ba6b4c590e243ac6b913d @
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> Linux commits
> d052b555afc8 drm/display/dp: Add the remaining Square PHY patterns
> DPCD register definitions
Jani Nikula Dec. 4, 2023, 11:14 a.m. UTC | #2
On Thu, 30 Nov 2023, Khaled Almahallawy <khaled.almahallawy@intel.com> wrote:
> DP2.1 Specs added new DPCDs definitions for square pattern configs[1]
> These new definitions are used for UHBR Source Transmitter
> Equalizations tests[2]. Add the 3 new values for square pattern.
>
> v2: rebase
>
> [1]: DP2.1 Specs - 2.12.3.6.5 Square Pattern
> [2]: DP2.1 PHY CTS specs - 4.3 UHBR Source Transmitter Equalization
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com>

Thanks for the patch, pushed to drm-misc-next.

BR,
Jani.


> ---
>  include/drm/display/drm_dp.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 83d2039c018b..3731828825bd 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -651,6 +651,9 @@
>  # define DP_LINK_QUAL_PATTERN_PRSBS31       0x38
>  # define DP_LINK_QUAL_PATTERN_CUSTOM        0x40
>  # define DP_LINK_QUAL_PATTERN_SQUARE        0x48
> +# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DISABLED                   0x49
> +# define DP_LINK_QUAL_PATTERN_SQUARE_DEEMPHASIS_DISABLED                 0x4a
> +# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DEEMPHASIS_DISABLED        0x4b
>  
>  #define DP_TRAINING_LANE0_1_SET2	    0x10f
>  #define DP_TRAINING_LANE2_3_SET2	    0x110
diff mbox series

Patch

diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
index 83d2039c018b..3731828825bd 100644
--- a/include/drm/display/drm_dp.h
+++ b/include/drm/display/drm_dp.h
@@ -651,6 +651,9 @@ 
 # define DP_LINK_QUAL_PATTERN_PRSBS31       0x38
 # define DP_LINK_QUAL_PATTERN_CUSTOM        0x40
 # define DP_LINK_QUAL_PATTERN_SQUARE        0x48
+# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DISABLED                   0x49
+# define DP_LINK_QUAL_PATTERN_SQUARE_DEEMPHASIS_DISABLED                 0x4a
+# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DEEMPHASIS_DISABLED        0x4b
 
 #define DP_TRAINING_LANE0_1_SET2	    0x10f
 #define DP_TRAINING_LANE2_3_SET2	    0x110