diff mbox series

[7/7] drm/i915/psr: Disable early transport by default

Message ID 20231218175004.52875-8-jouni.hogander@intel.com (mailing list archive)
State New, archived
Headers show
Series Early Transport for Panel Replay and PSR | expand

Commit Message

Hogander, Jouni Dec. 18, 2023, 5:50 p.m. UTC
Early transport validation is currently incomplete. Due to this disable the
feature by default.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mika Kahola Jan. 9, 2024, 12:57 p.m. UTC | #1
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jouni Högander
> Sent: Monday, December 18, 2023 7:50 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [PATCH 7/7] drm/i915/psr: Disable early transport by default
> 
> Early transport validation is currently incomplete. Due to this disable the feature by default.
> 

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index c29fd708608a..7835afee4283 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -2851,6 +2851,9 @@ void intel_psr_init(struct intel_dp *intel_dp)
>  	else
>  		intel_dp->psr.source_support = true;
> 
> +	/* Disable early transport for now */
> +	intel_dp->psr.debug |= I915_PSR_DEBUG_SU_REGION_ET_DISABLE;
> +
>  	/* Set link_standby x link_off defaults */
>  	if (DISPLAY_VER(dev_priv) < 12)
>  		/* For new platforms up to TGL let's respect VBT back again */
> --
> 2.34.1
Hogander, Jouni Jan. 10, 2024, 6:05 a.m. UTC | #2
On Tue, 2024-01-09 at 12:57 +0000, Kahola, Mika wrote:
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > Of Jouni Högander
> > Sent: Monday, December 18, 2023 7:50 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [PATCH 7/7] drm/i915/psr: Disable early transport by
> > default
> > 
> > Early transport validation is currently incomplete. Due to this
> > disable the feature by default.
> > 
> 
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>

Thank you Mika for reviewing my patches. This whole set is now pushed
to drm-intel-next.

BR,

Jouni Högander

> 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index c29fd708608a..7835afee4283 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -2851,6 +2851,9 @@ void intel_psr_init(struct intel_dp
> > *intel_dp)
> >         else
> >                 intel_dp->psr.source_support = true;
> > 
> > +       /* Disable early transport for now */
> > +       intel_dp->psr.debug |= I915_PSR_DEBUG_SU_REGION_ET_DISABLE;
> > +
> >         /* Set link_standby x link_off defaults */
> >         if (DISPLAY_VER(dev_priv) < 12)
> >                 /* For new platforms up to TGL let's respect VBT
> > back again */
> > --
> > 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index c29fd708608a..7835afee4283 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2851,6 +2851,9 @@  void intel_psr_init(struct intel_dp *intel_dp)
 	else
 		intel_dp->psr.source_support = true;
 
+	/* Disable early transport for now */
+	intel_dp->psr.debug |= I915_PSR_DEBUG_SU_REGION_ET_DISABLE;
+
 	/* Set link_standby x link_off defaults */
 	if (DISPLAY_VER(dev_priv) < 12)
 		/* For new platforms up to TGL let's respect VBT back again */