diff mbox series

[v2,02/13] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay

Message ID 20240110131304.2470006-3-jouni.hogander@intel.com (mailing list archive)
State New, archived
Headers show
Series Panel replay selective update support | expand

Commit Message

Hogander, Jouni Jan. 10, 2024, 1:12 p.m. UTC
Currently intel_psr_pause and intel_psr_resume do nothing in case of panel
replay. Change them to perform pause and return also in case of panel
replay.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Animesh Manna Jan. 11, 2024, 6:01 a.m. UTC | #1
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jouni
> Högander
> Sent: Wednesday, January 10, 2024 6:43 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [PATCH v2 02/13] drm/i915/psr: Intel_psr_pause/resume needs to
> support panel replay
> 
> Currently intel_psr_pause and intel_psr_resume do nothing in case of panel
> replay. Change them to perform pause and return also in case of panel
> replay.
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Changes looks good to me.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 9705a75e063a..3e287a9f0e09 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1829,7 +1829,7 @@ void intel_psr_pause(struct intel_dp *intel_dp)
>  	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
>  	struct intel_psr *psr = &intel_dp->psr;
> 
> -	if (!CAN_PSR(intel_dp))
> +	if (!CAN_PSR(intel_dp) && !CAN_PANEL_REPLAY(intel_dp))
>  		return;
> 
>  	mutex_lock(&psr->lock);
> @@ -1862,7 +1862,7 @@ void intel_psr_resume(struct intel_dp *intel_dp)  {
>  	struct intel_psr *psr = &intel_dp->psr;
> 
> -	if (!CAN_PSR(intel_dp))
> +	if (!CAN_PSR(intel_dp) && !CAN_PANEL_REPLAY(intel_dp))
>  		return;
> 
>  	mutex_lock(&psr->lock);
> --
> 2.34.1
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 9705a75e063a..3e287a9f0e09 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1829,7 +1829,7 @@  void intel_psr_pause(struct intel_dp *intel_dp)
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 	struct intel_psr *psr = &intel_dp->psr;
 
-	if (!CAN_PSR(intel_dp))
+	if (!CAN_PSR(intel_dp) && !CAN_PANEL_REPLAY(intel_dp))
 		return;
 
 	mutex_lock(&psr->lock);
@@ -1862,7 +1862,7 @@  void intel_psr_resume(struct intel_dp *intel_dp)
 {
 	struct intel_psr *psr = &intel_dp->psr;
 
-	if (!CAN_PSR(intel_dp))
+	if (!CAN_PSR(intel_dp) && !CAN_PANEL_REPLAY(intel_dp))
 		return;
 
 	mutex_lock(&psr->lock);