| Message ID | 20240110131304.2470006-9-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Panel replay selective update support | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jouni > Högander > Sent: Wednesday, January 10, 2024 6:43 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 08/13] drm/i915/psr: Add sink_panel_replay_su_support > to intel_psr > > Add new boolean to store panel replay selective update support of sink. > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h > b/drivers/gpu/drm/i915/display/intel_display_types.h > index 8315ec307d5f..3151741f49f5 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1721,6 +1721,7 @@ struct intel_psr { > u16 su_y_granularity; > bool source_panel_replay_support; > bool sink_panel_replay_support; > + bool sink_panel_replay_su_support; This patch can be squashed with the patch which is using the variable. Early patches psr2 get modified to sel_update .. can we have similar approach? Then we do not need extra variable. Regards, Animesh > bool panel_replay_enabled; > u32 dc3co_exitline; > u32 dc3co_exit_delay; > -- > 2.34.1
On Fri, 2024-01-12 at 11:19 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf > > Of Jouni > > Högander > > Sent: Wednesday, January 10, 2024 6:43 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 08/13] drm/i915/psr: Add > > sink_panel_replay_su_support > > to intel_psr > > > > Add new boolean to store panel replay selective update support of > > sink. > > > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display_types.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h > > b/drivers/gpu/drm/i915/display/intel_display_types.h > > index 8315ec307d5f..3151741f49f5 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > > @@ -1721,6 +1721,7 @@ struct intel_psr { > > u16 su_y_granularity; > > bool source_panel_replay_support; > > bool sink_panel_replay_support; > > + bool sink_panel_replay_su_support; > > This patch can be squashed with the patch which is using the > variable. > Early patches psr2 get modified to sel_update .. can we have similar > approach? Then we do not need extra variable. I don't know if there will be eDP1.5 panels supporting both PSR2 and panel replay -> added separate boolean for this. Please note also my TODO comment in "drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay" BR, Jouni Högander > > Regards, > Animesh > > bool panel_replay_enabled; > > u32 dc3co_exitline; > > u32 dc3co_exit_delay; > > -- > > 2.34.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 8315ec307d5f..3151741f49f5 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -1721,6 +1721,7 @@ struct intel_psr { u16 su_y_granularity; bool source_panel_replay_support; bool sink_panel_replay_support; + bool sink_panel_replay_su_support; bool panel_replay_enabled; u32 dc3co_exitline; u32 dc3co_exit_delay;
Add new boolean to store panel replay selective update support of sink. Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+)